[AppService]: fix #21820 Fixed Set-AzWebApp isue with Set-AzWebApp when piping in Get-AzWebApp object (#21973)

* [AppService]: fix #21820 Fixed Set-AzWebApp isue with `Set-AzWebApp` when piping in Get-AzWebApp object

* Code changes are addressed

* updated the code as per review comments

Author: Kotasudhakarreddy

src/Websites/Websites.Test/ScenarioTests/WebAppSlotTests.ps1

@@ -446,7 +446,7 @@ function Test-SetWebAppSlot
 		Assert-AreEqual $appWithSlotName $slot.Name
 		Assert-AreEqual $serverFarm1.Id $slot.ServerFarmId
         Assert-Null $webApp.Identity
-		Assert-AreEqual "AllAllowed" $slot.SiteConfig.FtpsState
+		Assert-AreEqual "FtpsOnly" $slot.SiteConfig.FtpsState
 
 		# Change service plan & set site and SiteConfig properties
 		$job = Set-AzWebAppSlot -ResourceGroupName $rgname -Name $appname -Slot $slotname -AppServicePlan $planName2 -HttpsOnly $true -AlwaysOn $true -AsJob
@@ -462,7 +462,7 @@ function Test-SetWebAppSlot
 		# Set config properties
 		$slot.SiteConfig.HttpLoggingEnabled = $true
 		$slot.SiteConfig.RequestTracingEnabled = $true
-		$slot.SiteConfig.FtpsState = "FtpsOnly"
+		$slot.SiteConfig.FtpsState = "AllAllowed"
 		$slot.SiteConfig.MinTlsVersion = "1.0"
 		$slot.SiteConfig.HealthCheckPath = "/api/path"
 
@@ -473,7 +473,7 @@ function Test-SetWebAppSlot
 		Assert-AreEqual $serverFarm2.Id $slot.ServerFarmId
 		Assert-AreEqual $true $slot.SiteConfig.HttpLoggingEnabled
 		Assert-AreEqual $true $slot.SiteConfig.RequestTracingEnabled
-		Assert-AreEqual "FtpsOnly" $slot.SiteConfig.FtpsState
+		Assert-AreEqual "AllAllowed" $slot.SiteConfig.FtpsState
 		Assert-AreEqual "1.0" $slot.SiteConfig.MinTlsVersion
 		Assert-AreEqual "/api/path" $slot.SiteConfig.HealthCheckPath
 
@@ -524,7 +524,7 @@ function Test-SetWebAppSlot
 		# Assert
 		Assert-AreEqual $appWithSlotName $slot.Name
 		Assert-Null $webApp.Identity
-		Assert-AreEqual "AllAllowed" $slot.SiteConfig.FtpsState
+		Assert-AreEqual "FtpsOnly" $slot.SiteConfig.FtpsState
 
 		# Get the deployment slot
 
@@ -533,7 +533,7 @@ function Test-SetWebAppSlot
 		# Set config properties
 		$slot.SiteConfig.HttpLoggingEnabled = $true
 		$slot.SiteConfig.RequestTracingEnabled = $true
-		$slot.SiteConfig.FtpsState = "FtpsOnly"
+		$slot.SiteConfig.FtpsState = "AllAllowed"
 		$slot.SiteConfig.MinTlsVersion = "1.0"
 
 		$slot = $slot | Set-AzWebAppSlot
@@ -542,7 +542,7 @@ function Test-SetWebAppSlot
 		Assert-AreEqual $appWithSlotName $slot.Name
 		Assert-AreEqual $true $slot.SiteConfig.HttpLoggingEnabled
 		Assert-AreEqual $true $slot.SiteConfig.RequestTracingEnabled
-		Assert-AreEqual "FtpsOnly" $slot.SiteConfig.FtpsState
+		Assert-AreEqual "AllAllowed" $slot.SiteConfig.FtpsState
 		Assert-AreEqual "1.0" $slot.SiteConfig.MinTlsVersion
 	}
 	finally

src/Websites/Websites.Test/ScenarioTests/WebAppTests.ps1

@@ -934,7 +934,7 @@ function Test-SetWebApp
 		Assert-Null $webApp.Identity
 		Assert-NotNull $webApp.SiteConfig.phpVersion
 		Assert-AreEqual $false $webApp.HttpsOnly
-		Assert-AreEqual "AllAllowed" $webApp.SiteConfig.FtpsState
+		Assert-AreEqual "FtpsOnly" $webApp.SiteConfig.FtpsState
 
 		# Change service plan & set site properties
 		$job = Set-AzWebApp -ResourceGroupName $rgname -Name $webAppName -AppServicePlan $appServicePlanName2 -HttpsOnly $true -AlwaysOn $false -AsJob
@@ -952,7 +952,7 @@ function Test-SetWebApp
 		# Set config properties
 		$webapp.SiteConfig.HttpLoggingEnabled = $true
 		$webapp.SiteConfig.RequestTracingEnabled = $true
-		$webapp.SiteConfig.FtpsState = "FtpsOnly"
+		$webapp.SiteConfig.FtpsState = "AllAllowed"
 		$webApp.SiteConfig.MinTlsVersion = "1.0"
 		$webApp.SiteConfig.HealthCheckPath = "/api/path"
 
@@ -967,7 +967,7 @@ function Test-SetWebApp
 		Assert-AreEqual $true $webApp.SiteConfig.HttpLoggingEnabled
 		Assert-AreEqual $true $webApp.SiteConfig.RequestTracingEnabled
 		Assert-AreEqual $false $webApp.SiteConfig.AlwaysOn
-		Assert-AreEqual "FtpsOnly" $webApp.SiteConfig.FtpsState
+		Assert-AreEqual "AllAllowed" $webApp.SiteConfig.FtpsState
 		Assert-AreEqual "1.0" $webApp.SiteConfig.MinTlsVersion
 		Assert-AreEqual "/api/path" $webApp.SiteConfig.HealthCheckPath
 

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppSlotTests/TestSetWebAppSlot.json

@@ -19,6 +19,7 @@
 -->
 ## Upcoming Release
 * Increased timeout for Publish-AzWebApp command
+* Fixed Set-AzWebApp isue with `Set-AzWebApp` when piping in Get-AzWebApp object [#21820]
 
 ## Version 3.0.0
 * Removed `New-AzWebAppContainerPSSession` and `Enter-AzWebAppContainerPSSession` cmdlets

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestSetWebApp.json

@@ -112,6 +112,10 @@ public void UpdateWebApp(string resourceGroupName, string location, string webAp
 
             if (siteEnvelope != null)
             {
+                if (siteEnvelope is PSSite)
+                {
+                    ((PSSite)siteEnvelope).VnetInfo = null;
+                }
                 webSiteToUpdate = siteEnvelope;
             }