bug fix (#12342)

Author: VeryEarly

src/Monitor/Monitor/ChangeLog.md

@@ -19,6 +19,7 @@
 -->
 
 ## Upcoming Release
+* Fixed bug for `Get-AzDiagnosticSetting` when metrics or logs are null [#12272]
 
 ## Version 2.0.1
 * Fixed input object parameter for `Set-AzActivityLogAlert`

src/Monitor/Monitor/OutputClasses/PSServiceDiagnosticSettings.cs

@@ -62,16 +62,23 @@ public PSServiceDiagnosticSettings(DiagnosticSettingsResource serviceDiagnosticS
                 this.EventHubName = serviceDiagnosticSettings.EventHubName;
                 this.ServiceBusRuleId = serviceDiagnosticSettings.ServiceBusRuleId;
                 this.EventHubAuthorizationRuleId = serviceDiagnosticSettings.EventHubAuthorizationRuleId;
-                this.Metrics = new List<Management.Monitor.Management.Models.MetricSettings>();
-                foreach (MetricSettings metricSettings in serviceDiagnosticSettings.Metrics)
+
+                if (serviceDiagnosticSettings.Metrics != null)
                 {
-                    this.Metrics.Add(new PSMetricSettings(metricSettings));
+                    this.Metrics = new List<Management.Monitor.Management.Models.MetricSettings>();
+                    foreach (MetricSettings metricSettings in serviceDiagnosticSettings.Metrics)
+                    {
+                        this.Metrics.Add(new PSMetricSettings(metricSettings));
+                    }
                 }
 
-                this.Logs = new List<Management.Monitor.Management.Models.LogSettings>();
-                foreach (LogSettings logSettings in serviceDiagnosticSettings.Logs)
+                if (serviceDiagnosticSettings.Logs != null)
                 {
-                    this.Logs.Add(new PSLogSettings(logSettings));
+                    this.Logs = new List<Management.Monitor.Management.Models.LogSettings>();
+                    foreach (LogSettings logSettings in serviceDiagnosticSettings.Logs)
+                    {
+                        this.Logs.Add(new PSLogSettings(logSettings));
+                    }
                 }
 
                 this.WorkspaceId = serviceDiagnosticSettings.WorkspaceId;