[Network] - Update New-AzPublicIpPrefix and New-AzPublicIpAddress to require Location parameter (#22909)

* Update New-AzPublicIpPrefix to require Location parameter

* Update changelog.md

* Update New-AzPublicIpAddress

* Create BreakingChangeIssues.csv for network

---------

Co-authored-by: Yabo Hu <[email protected]>

Author: phrazfipho

src/Network/Network/ChangeLog.md

@@ -19,6 +19,7 @@
 --->
 
 ## Upcoming Release
+* Updated cmdlet `New-AzPublicIpPrefix` and `New-PublicIpAddress` to require Location parameter
 * Updated cmdlet `New-AzLoadBalancerBackendAddressPool` to support managed IP based backend
 * Added cmdlet `New-AzSaaSNetworkVirtualAppliance` for creating a NetworkVirtualAppliance of SaaS type.
 

src/Network/Network/PublicIpAddress/NewAzurePublicIpAddressCommand.cs

@@ -49,7 +49,7 @@ public class NewAzurePublicIpAddressCommand : PublicIpAddressBaseCmdlet
         public virtual string ResourceGroupName { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             ValueFromPipelineByPropertyName = true,
             HelpMessage = "The public IP address location.")]
         [LocationCompleter("Microsoft.Network/publicIPAddresses")]

src/Network/Network/PublicIpPrefix/NewAzurePublicIpPrefixCommand.cs

@@ -47,7 +47,7 @@ public class NewAzurePublicIpPrefixCommand : PublicIpPrefixBaseCmdlet
         public virtual string ResourceGroupName { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             ValueFromPipelineByPropertyName = true,
             HelpMessage = "The public IP prefix location.")]
         [LocationCompleter("Microsoft.Network/publicIPPrefixes")]

src/Network/Network/help/New-AzPublicIpAddress.md

@@ -14,12 +14,13 @@ Creates a public IP address.
 ## SYNTAX
 
 ```
-New-AzPublicIpAddress [-Name <String>] -ResourceGroupName <String> [-Location <String>] [-EdgeZone <String>]
+New-AzPublicIpAddress [-Name <String>] -ResourceGroupName <String> -Location <String> [-EdgeZone <String>]
  [-Sku <String>] [-Tier <String>] -AllocationMethod <String> [-IpAddressVersion <String>]
- [-DomainNameLabel <String>] [-DomainNameLabelScope <String>][-IpTag <PSPublicIpTag[]>] [-PublicIpPrefix <PSPublicIpPrefix>]
- [-DdosProtectionMode <String>] [-DdosProtectionPlanId <String>] [-ReverseFqdn <String>]
- [-IdleTimeoutInMinutes <Int32>] [-Zone <String[]>] [-IpAddress <String>] [-Tag <Hashtable>] [-Force] [-AsJob]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-DomainNameLabel <String>] [-DomainNameLabelScope <PSDomainNameLabelScopeType>] [-IpTag <PSPublicIpTag[]>]
+ [-PublicIpPrefix <PSPublicIpPrefix>] [-DdosProtectionMode <String>] [-DdosProtectionPlanId <String>]
+ [-ReverseFqdn <String>] [-IdleTimeoutInMinutes <Int32>] [-Zone <String[]>] [-IpAddress <String>]
+ [-Tag <Hashtable>] [-Force] [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
+ [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -202,7 +203,7 @@ Accept wildcard characters: False
 Specifies the HashedReusePolicy for DNS name for a public IP address.
 
 ```yaml
-Type: System.String
+Type: System.Nullable`1[Microsoft.Azure.Commands.Network.Models.PSDomainNameLabelScopeType]
 Parameter Sets: (All)
 Aliases:
 Accepted values: TenantReuse, SubscriptionReuse, ResourceGroupReuse, NoReuse
@@ -313,7 +314,7 @@ Type: System.String
 Parameter Sets: (All)
 Aliases:
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: True (ByPropertyName)

src/Network/Network/help/New-AzPublicIpPrefix.md

@@ -13,7 +13,7 @@ Creates a Public IP Prefix
 ## SYNTAX
 
 ```
-New-AzPublicIpPrefix -Name <String> -ResourceGroupName <String> [-Location <String>] [-Sku <String>]
+New-AzPublicIpPrefix -Name <String> -ResourceGroupName <String> -Location <String> [-Sku <String>]
  [-Tier <String>] -PrefixLength <UInt16> [-IpAddressVersion <String>] [-IpTag <PSPublicIpPrefixTag[]>]
  [-Zone <String[]>] [-CustomIpPrefix <PSCustomIpPrefix>] [-EdgeZone <String>] [-Tag <Hashtable>] [-Force]
  [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
@@ -165,7 +165,7 @@ Type: System.String
 Parameter Sets: (All)
 Aliases:
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: True (ByPropertyName)

tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv

@@ -0,0 +1,3 @@
+"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
+"Az.Network","Microsoft.Azure.Commands.Network.NewAzurePublicIpAddressCommand","New-AzPublicIpAddress","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzPublicIpAddress' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzPublicIpAddress'."
+"Az.Network","Microsoft.Azure.Commands.Network.NewAzurePublicIpPrefixCommand","New-AzPublicIpPrefix","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzPublicIpPrefix' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzPublicIpPrefix'."