Skip to content

Commit bedf3b2

Browse files
authored
[NetAppFiles] Bug Fix for coolnessPeriod min value (#25308)
* Fix for coolnessPeriod min * changelog
1 parent d7ea4aa commit bedf3b2

File tree

8 files changed

+32
-30
lines changed

8 files changed

+32
-30
lines changed

src/NetAppFiles/NetAppFiles.Management.Sdk/Custom/Models/VolumePatch.cs

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/NetAppFiles/NetAppFiles.Management.Sdk/Generated/Models/Volume.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -831,9 +831,9 @@ public override void Validate()
831831
{
832832
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMaximum, "CoolnessPeriod", 183);
833833
}
834-
if (this.CoolnessPeriod < 7)
834+
if (this.CoolnessPeriod < 2)
835835
{
836-
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "CoolnessPeriod", 7);
836+
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "CoolnessPeriod", 2);
837837
}
838838
}
839839

src/NetAppFiles/NetAppFiles.Management.Sdk/Generated/Models/VolumeGroupVolumeProperties.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -840,9 +840,9 @@ public virtual void Validate()
840840
{
841841
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMaximum, "CoolnessPeriod", 183);
842842
}
843-
if (this.CoolnessPeriod < 7)
843+
if (this.CoolnessPeriod < 2)
844844
{
845-
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "CoolnessPeriod", 7);
845+
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "CoolnessPeriod", 2);
846846
}
847847
}
848848

src/NetAppFiles/NetAppFiles.Management.Sdk/Generated/Models/VolumePatch.cs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ public VolumePatch()
5252
/// <param name="exportPolicy">Set of export policy rules
5353
/// </param>
5454

55+
/// <param name="protocolTypes">Set of protocol types, default NFSv3, CIFS for SMB protocol
56+
/// </param>
57+
5558
/// <param name="throughputMibps">Maximum throughput in MiB/s that can be achieved by this volume and this
5659
/// will be accepted as input only for manual qosType volume
5760
/// </param>
@@ -108,7 +111,7 @@ public VolumePatch()
108111
/// <param name="smbNonBrowsable">Enables non-browsable property for SMB Shares. Only applicable for
109112
/// SMB/DualProtocol volume
110113
/// Possible values include: &#39;Disabled&#39;, &#39;Enabled&#39;</param>
111-
public VolumePatch(string location = default(string), string id = default(string), string name = default(string), string type = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), string serviceLevel = default(string), long? usageThreshold = default(long?), VolumePatchPropertiesExportPolicy exportPolicy = default(VolumePatchPropertiesExportPolicy), double? throughputMibps = default(double?), VolumePatchPropertiesDataProtection dataProtection = default(VolumePatchPropertiesDataProtection), bool? isDefaultQuotaEnabled = default(bool?), long? defaultUserQuotaInKiBs = default(long?), long? defaultGroupQuotaInKiBs = default(long?), string unixPermissions = default(string), bool? coolAccess = default(bool?), int? coolnessPeriod = default(int?), string coolAccessRetrievalPolicy = default(string), bool? snapshotDirectoryVisible = default(bool?), string smbAccessBasedEnumeration = default(string), string smbNonBrowsable = default(string))
114+
public VolumePatch(string location = default(string), string id = default(string), string name = default(string), string type = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), string serviceLevel = default(string), long? usageThreshold = default(long?), VolumePatchPropertiesExportPolicy exportPolicy = default(VolumePatchPropertiesExportPolicy), System.Collections.Generic.IList<string> protocolTypes = default(System.Collections.Generic.IList<string>), double? throughputMibps = default(double?), VolumePatchPropertiesDataProtection dataProtection = default(VolumePatchPropertiesDataProtection), bool? isDefaultQuotaEnabled = default(bool?), long? defaultUserQuotaInKiBs = default(long?), long? defaultGroupQuotaInKiBs = default(long?), string unixPermissions = default(string), bool? coolAccess = default(bool?), int? coolnessPeriod = default(int?), string coolAccessRetrievalPolicy = default(string), bool? snapshotDirectoryVisible = default(bool?), string smbAccessBasedEnumeration = default(string), string smbNonBrowsable = default(string))
112115

113116
{
114117
this.Location = location;
@@ -119,6 +122,7 @@ public VolumePatch()
119122
this.ServiceLevel = serviceLevel;
120123
this.UsageThreshold = usageThreshold;
121124
this.ExportPolicy = exportPolicy;
125+
this.ProtocolTypes = protocolTypes;
122126
this.ThroughputMibps = throughputMibps;
123127
this.DataProtection = dataProtection;
124128
this.IsDefaultQuotaEnabled = isDefaultQuotaEnabled;
@@ -191,6 +195,12 @@ public VolumePatch()
191195
[Newtonsoft.Json.JsonProperty(PropertyName = "properties.exportPolicy")]
192196
public VolumePatchPropertiesExportPolicy ExportPolicy {get; set; }
193197

198+
/// <summary>
199+
/// Gets or sets set of protocol types, default NFSv3, CIFS for SMB protocol
200+
/// </summary>
201+
[Newtonsoft.Json.JsonProperty(PropertyName = "properties.protocolTypes")]
202+
public System.Collections.Generic.IList<string> ProtocolTypes {get; set; }
203+
194204
/// <summary>
195205
/// Gets or sets maximum throughput in MiB/s that can be achieved by this
196206
/// volume and this will be accepted as input only for manual qosType volume
@@ -311,6 +321,7 @@ public virtual void Validate()
311321
}
312322

313323

324+
314325
if (this.UnixPermissions != null)
315326
{
316327
if (this.UnixPermissions.Length > 4)

src/NetAppFiles/NetAppFiles.Management.Sdk/Generated/Models/VolumePatchProperties.cs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ public VolumePatchProperties()
3636
/// <param name="exportPolicy">Set of export policy rules
3737
/// </param>
3838

39+
/// <param name="protocolTypes">Set of protocol types, default NFSv3, CIFS for SMB protocol
40+
/// </param>
41+
3942
/// <param name="throughputMibps">Maximum throughput in MiB/s that can be achieved by this volume and this
4043
/// will be accepted as input only for manual qosType volume
4144
/// </param>
@@ -92,12 +95,13 @@ public VolumePatchProperties()
9295
/// <param name="smbNonBrowsable">Enables non-browsable property for SMB Shares. Only applicable for
9396
/// SMB/DualProtocol volume
9497
/// Possible values include: &#39;Disabled&#39;, &#39;Enabled&#39;</param>
95-
public VolumePatchProperties(string serviceLevel = default(string), long? usageThreshold = default(long?), VolumePatchPropertiesExportPolicy exportPolicy = default(VolumePatchPropertiesExportPolicy), double? throughputMibps = default(double?), VolumePatchPropertiesDataProtection dataProtection = default(VolumePatchPropertiesDataProtection), bool? isDefaultQuotaEnabled = default(bool?), long? defaultUserQuotaInKiBs = default(long?), long? defaultGroupQuotaInKiBs = default(long?), string unixPermissions = default(string), bool? coolAccess = default(bool?), int? coolnessPeriod = default(int?), string coolAccessRetrievalPolicy = default(string), bool? snapshotDirectoryVisible = default(bool?), string smbAccessBasedEnumeration = default(string), string smbNonBrowsable = default(string))
98+
public VolumePatchProperties(string serviceLevel = default(string), long? usageThreshold = default(long?), VolumePatchPropertiesExportPolicy exportPolicy = default(VolumePatchPropertiesExportPolicy), System.Collections.Generic.IList<string> protocolTypes = default(System.Collections.Generic.IList<string>), double? throughputMibps = default(double?), VolumePatchPropertiesDataProtection dataProtection = default(VolumePatchPropertiesDataProtection), bool? isDefaultQuotaEnabled = default(bool?), long? defaultUserQuotaInKiBs = default(long?), long? defaultGroupQuotaInKiBs = default(long?), string unixPermissions = default(string), bool? coolAccess = default(bool?), int? coolnessPeriod = default(int?), string coolAccessRetrievalPolicy = default(string), bool? snapshotDirectoryVisible = default(bool?), string smbAccessBasedEnumeration = default(string), string smbNonBrowsable = default(string))
9699

97100
{
98101
this.ServiceLevel = serviceLevel;
99102
this.UsageThreshold = usageThreshold;
100103
this.ExportPolicy = exportPolicy;
104+
this.ProtocolTypes = protocolTypes;
101105
this.ThroughputMibps = throughputMibps;
102106
this.DataProtection = dataProtection;
103107
this.IsDefaultQuotaEnabled = isDefaultQuotaEnabled;
@@ -140,6 +144,12 @@ public VolumePatchProperties()
140144
[Newtonsoft.Json.JsonProperty(PropertyName = "exportPolicy")]
141145
public VolumePatchPropertiesExportPolicy ExportPolicy {get; set; }
142146

147+
/// <summary>
148+
/// Gets or sets set of protocol types, default NFSv3, CIFS for SMB protocol
149+
/// </summary>
150+
[Newtonsoft.Json.JsonProperty(PropertyName = "protocolTypes")]
151+
public System.Collections.Generic.IList<string> ProtocolTypes {get; set; }
152+
143153
/// <summary>
144154
/// Gets or sets maximum throughput in MiB/s that can be achieved by this
145155
/// volume and this will be accepted as input only for manual qosType volume
@@ -255,6 +265,7 @@ public virtual void Validate()
255265
}
256266

257267

268+
258269
if (this.UnixPermissions != null)
259270
{
260271
if (this.UnixPermissions.Length > 4)

src/NetAppFiles/NetAppFiles.Management.Sdk/Generated/Models/VolumeProperties.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -783,9 +783,9 @@ public virtual void Validate()
783783
{
784784
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMaximum, "CoolnessPeriod", 183);
785785
}
786-
if (this.CoolnessPeriod < 7)
786+
if (this.CoolnessPeriod < 2)
787787
{
788-
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "CoolnessPeriod", 7);
788+
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "CoolnessPeriod", 2);
789789
}
790790
}
791791

src/NetAppFiles/NetAppFiles.Management.Sdk/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ description: Microsoft NetApp Files Azure Resource Provider specification
2525
2626
###
2727
``` yaml
28-
commit: c3cc9abe085093ba880ee3eeb792edb4fa789553
28+
commit: c54a97d08c5afd7dc04f87a5df65d9dc84c96159
2929
input-file:
3030
- https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/netapp/resource-manager/Microsoft.NetApp/stable/2023-11-01/netapp.json
3131
output-folder: Generated

src/NetAppFiles/NetAppFiles/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
-->
2020
## Upcoming Release
2121
* Updated to api-version 2023-11-01
22+
* Fixed some minor issues
2223

2324
## Version 0.15.2
2425
* Upgraded Azure.Core to 1.37.0.

0 commit comments

Comments
 (0)