Skip to content

Commit c0df399

Browse files
author
ianna1-admin
committed
fix error discovered in unit test
1 parent c599d5f commit c0df399

File tree

4 files changed

+52
-18
lines changed

4 files changed

+52
-18
lines changed

src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/BackupInstance/Initialize-AzDataProtectionBackupInstance.ps1

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,14 @@
185185
throw $errormsg
186186
}
187187

188+
if($manifest.enableDataSourceSetInfo -eq $true)
189+
{
190+
$backupInstanceResource.Property.DataSourceSetInfo = GetDatasourceInfo -ResourceId $DatasourceId -ResourceLocation $DatasourceLocation -DatasourceType $DatasourceType
191+
$tmpVar = $backupInstance.DataSourceSetInfo = GetDatasourceSetInfo -DatasourceInfo $backupInstance.DataSourceInfo -DatasourceType $DatasourceType
192+
193+
$backupInstanceResource.Property.DataSourceSetInfo.ObjectType = $tmpVar.ObjectType
194+
}
195+
188196
return $backupInstanceResource
189197
}
190198
}

src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Vault/Set-AzDataProtectionMSIPermission.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
$vaultIdentity = $vault.Identity.UserAssignedIdentity[$UserAssignedIdentityARMId].PrincipalID
1616
Write-Host "Using Vault UAMI with ARMId: $UserAssignedIdentityARMId with Principal ID: $vaultIdentity"
1717
} else {
18-
$vaultIdentity = $vault.Identity.PrincipalId
18+
$vaultIdentity = $vault.IdentityPrincipalId
1919
Write-Host "Using system-assigned identity with Principal ID: $vaultIdentity"
2020
}
2121

src/DataProtection/DataProtection.Autorest/custom/Helpers/CommonHelpers.ps1

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ function GetDatasourceSetInfo
3737
$DataSourceSetInfo.ResourceUri = ""
3838
}
3939

40+
if($DataSourceSetInfo.PSObject.Properties.Name -contains "ResourceProperties")
41+
{
42+
$DataSourceSetInfo.PSObject.Properties.Remove("ResourceProperties") | Out-Null
43+
}
44+
4045
return $DataSourceSetInfo
4146
}
4247
}

src/DataProtection/DataProtection.Autorest/test/utils.ps1

Lines changed: 38 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -182,24 +182,44 @@ function setupEnv() {
182182

183183
$BlobHardeningVariables = @{
184184
SubscriptionId = "38304e13-357e-405e-9e9a-220351dcce8c"
185-
CrossSubscriptionId = "62b829ee-7936-40c9-a1c9-47a93f9f3965"
185+
CrossSubscriptionId = "349ea464-dc60-42e9-8c5d-46fa013b9546"
186186
Location = "eastus"
187-
ResourceGroupName = "blob-eus-pstest-rg"
188-
VaultName = "blob-eus-pstest-vault"
189-
PolicyName = "operational-vaulted-policy"
190-
UpdatePolicyName = "op-vault-pstest-policy"
191-
UpdatedContainersList = @( "conaaa", "conabb", "coneee", "conwxy", "conzzz" )
192-
StorageAccountName = "blobeuspstestsa"
193-
OperationalPolicyName = "op-pstest-policy"
194-
VaultPolicyName = "vaulted-pstest-policy"
195-
OperationalVaultedPolicyName = "op-vault-pstest-policy"
196-
StorageAccId = "/subscriptions/38304e13-357e-405e-9e9a-220351dcce8c/resourceGroups/blob-eus-pstest-rg/providers/Microsoft.Storage/storageAccounts/blobeuspstestsa"
197-
TargetStorageAccId = "/subscriptions/38304e13-357e-405e-9e9a-220351dcce8c/resourceGroups/hiagarg/providers/Microsoft.Storage/storageAccounts/hiagaeussa"
198-
TargetStorageAccountName = "hiagaeussa"
199-
TargetStorageAccountRGName = "hiagarg"
200-
TargetCrossSubStorageAccId = "/subscriptions/62b829ee-7936-40c9-a1c9-47a93f9f3965/resourceGroups/hiagaTestRG/providers/Microsoft.Storage/storageAccounts/hiagatestsa"
201-
TargetCrossSubStorageAccountName = "hiagatestsa"
202-
TargetCrossSubStorageAccountRGName = "hiagaTestRG"
187+
ResourceGroupName = "dataprotectionpstest-rg"
188+
VaultName = "dataprotectionpstest-bv"
189+
PolicyName = "opvaultpolicy"
190+
UpdatePolicyName = "opvaultpolicy2"
191+
UpdatedContainersList = @( "con1", "con2", "con3", "con4", "con5" )
192+
StorageAccountName = "blobsourcesa1"
193+
OperationalPolicyName = "operationalpol2"
194+
VaultPolicyName = "vaultpolicy"
195+
OperationalVaultedPolicyName = "opvaultpolicy"
196+
StorageAccId = "/subscriptions/38304e13-357e-405e-9e9a-220351dcce8c/resourceGroups/dataprotectionpstest-rg/providers/Microsoft.Storage/storageAccounts/blobsourcesa1"
197+
TargetStorageAccId = "/subscriptions/38304e13-357e-405e-9e9a-220351dcce8c/resourceGroups/dataprotectionpstest-rg/providers/Microsoft.Storage/storageAccounts/blobtargetsa"
198+
TargetStorageAccountName = "blobtargetsa"
199+
TargetStorageAccountRGName = "dataprotectionpstest-rg"
200+
TargetCrossSubStorageAccId = "/subscriptions/349ea464-dc60-42e9-8c5d-46fa013b9546/resourceGroups/dataprotectionpstest2-rg/providers/Microsoft.Storage/storageAccounts/crrblobtargetsa"
201+
TargetCrossSubStorageAccountName = "crrblobtargetsa"
202+
TargetCrossSubStorageAccountRGName = "dataprotectionpstest2-rg"
203+
}
204+
205+
$AdlsBlobHardeningVariables = @{
206+
SubscriptionId = "38304e13-357e-405e-9e9a-220351dcce8c"
207+
CrossSubscriptionId = "349ea464-dc60-42e9-8c5d-46fa013b9546"
208+
Location = "eastus"
209+
ResourceGroupName = "dataprotectionpstest-rg"
210+
VaultName = "dataprotectionpstest-bv"
211+
PolicyName = "adlsvaultpolicy"
212+
UpdatePolicyName = "adlsvaultpolicy2"
213+
UpdatedContainersList = @( "con1", "con2", "con3", "con4", "con5" )
214+
StorageAccountName = "adlsblobsourcesa"
215+
VaultPolicyName = "adlsvaultpolicy"
216+
StorageAccId = "/subscriptions/38304e13-357e-405e-9e9a-220351dcce8c/resourceGroups/dataprotectionpstest-rg/providers/Microsoft.Storage/storageAccounts/adlsblobsourcesa"
217+
TargetStorageAccId = "/subscriptions/38304e13-357e-405e-9e9a-220351dcce8c/resourceGroups/dataprotectionpstest-rg/providers/Microsoft.Storage/storageAccounts/adlsblobtargetsa"
218+
TargetStorageAccountName = "adlsblobtargetsa"
219+
TargetStorageAccountRGName = "dataprotectionpstest-rg"
220+
TargetCrossSubStorageAccId = "/subscriptions/349ea464-dc60-42e9-8c5d-46fa013b9546/resourceGroups/dataprotectionpstest2-rg/providers/Microsoft.Storage/storageAccounts/crradlsblobtargetsa"
221+
TargetCrossSubStorageAccountName = "crradlsblobtargetsa"
222+
TargetCrossSubStorageAccountRGName = "dataprotectionpstest2-rg"
203223
}
204224

205225
$UpdateBIWithUAMIVariables = @{
@@ -309,6 +329,7 @@ function setupEnv() {
309329
$env.add("TestAksPolicyScenario", $AksPolicyVariables) | Out-Null
310330
$env.add("TestAksRestoreScenario", $AksRestoreVariables) | Out-Null
311331
$env.add("TestBlobHardeningScenario", $BlobHardeningVariables) | Out-Null
332+
$env.add("TestAdlsBlobHardeningScenario", $AdlsBlobHardeningVariables) | Out-Null
312333
$env.add("TestCrossSubscriptionRestoreScenario", $CrossSubscriptionRestoreVariables) | Out-Null
313334
$env.add("TestCrossRegionRestoreScenario", $CrossRegionRestoreVariables) | Out-Null
314335
$env.add("TestSoftDelete", $SoftDeleteVariables) | Out-Null

0 commit comments

Comments
 (0)