[Recovery Services] Bug fix for update cmdlet in HyperV to Azure provider scenario of Azure Site recovery (#26528)

* Fix the issue that UXMetadata generate null in example.parameters (#26505)

* Fixing bug for update RPI with UseManagedDiskForReplication

* More changes

* Updated changelog

* Minor fix

---------

Co-authored-by: Yunchi Wang <[email protected]>

Author: vidyadharijami

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/B2A/AsrB2ATests.cs

@@ -146,5 +146,14 @@ public void CreateRPIWithMangedDisksForReplication()
                 $"Import-Module {_testModule.AsAbsoluteLocation()}",
                 $"Test-CreateRPIWithMangedDisksForReplication -vaultSettingsFilePath \"{_credModule.AsAbsoluteLocation()}\"");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void UpdateRPIWithMangedDisksForReplication()
+        {
+            TestRunner.RunTestScript(
+                $"Import-Module {_testModule.AsAbsoluteLocation()}",
+                $"Test-UpdateRPIWithMangedDisksForReplication -vaultSettingsFilePath \"{_credModule.AsAbsoluteLocation()}\"");
+        }
     }
 }

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/B2A/AsrB2ATests.ps1

@@ -949,4 +949,30 @@ function Test-CreateRPIWithMangedDisksForReplication
     WaitForJobCompletion -JobId $EnableDRjob.Name
     $Job = Get-AzRecoveryServicesAsrJob -Name $EnableDRjob.Name
     Assert-True { $Job.State -eq "Succeeded" }
+}
+
+<#
+.SYNOPSIS
+Site Recovery Update RPI with managed disks for replication
+#>
+function Test-UpdateRPIWithMangedDisksForReplication
+{
+    param([string] $vaultSettingsFilePath)
+
+    Import-AzRecoveryServicesAsrVaultSettingsFile -Path $vaultSettingsFilePath
+    $PrimaryFabricName = "powershelltest"
+    $fabric =  Get-AsrFabric -FriendlyName $PrimaryFabricName
+    $pc =  Get-ASRProtectionContainer -Fabric $fabric
+    $ProtectionContainerMapping = Get-ASRProtectionContainerMapping -ProtectionContainer $pc
+    $policy = Get-AzRecoveryServicesAsrPolicy -Name $PolicyName
+    $VMName = "powershellvm2"
+
+    $rpi = Get-AzRecoveryServicesAsrReplicationProtectedItem -ProtectionContainer $pc -FriendlyName $VMName
+    $Updatejob = Set-AzRecoveryServicesAsrReplicationProtectedItem `
+    -InputObject $rpi `
+    -SqlServerLicenseType AHUB
+
+    WaitForJobCompletion -JobId $Updatejob.Name
+    $Job = Get-AzRecoveryServicesAsrJob -Name $Updatejob.Name
+    Assert-True { $Job.State -eq "Succeeded" }
 }

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/SessionRecords/RecoveryServices.SiteRecovery.Test.AsrB2ATests/UpdateRPIWithMangedDisksForReplication.json

@@ -513,11 +513,17 @@ public override void ExecuteSiteRecoveryCmdlet()
                                       useManagedDisk));
                     }
 
-                    var deploymentType = Utilities.GetValueFromArmId(
-                        providerSpecificDetails.RecoveryAzureStorageAccount,
-                        ARMResourceTypeConstants.Providers);
-                    if (deploymentType.ToLower()
-                        .Contains(Constants.Classic.ToLower()))
+                    string deploymentType = Constants.ResourceManager;
+
+                    if (!string.IsNullOrEmpty(providerSpecificDetails.RecoveryAzureStorageAccount))
+                    {
+                        deploymentType = Utilities.GetValueFromArmId(
+                            providerSpecificDetails.RecoveryAzureStorageAccount,
+                            ARMResourceTypeConstants.Providers);
+                    }
+
+                    if (!string.IsNullOrEmpty(deploymentType) && deploymentType.ToLower()
+                            .Contains(Constants.Classic.ToLower()))
                     {
                         providerSpecificInput =
                             new HyperVReplicaAzureUpdateReplicationProtectedItemInput

src/RecoveryServices/RecoveryServices.SiteRecovery/ReplicationProtectedItem/SetAzureRmRecoveryServicesAsrReplicationProtectedItem.cs

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fixed bug in `Set-ASRReplicationProtectedItem` cmdlet of H2A for replication to MD scenario.
 
 ## Version 7.2.0
 * Fixed bug for making RecoveryAzureStorageAccountId parameter optional in `New-ASRReplicationProtectedItem` cmdlet of H2A.

src/RecoveryServices/RecoveryServices/ChangeLog.md

@@ -178,6 +178,10 @@ private void ValidateMetadata(IssueLoggerContext context, string UXMetadataConte
 
         private void ValidateExample(IssueLoggerContext context, UXMetadataCommand command, CmdletMetadata cmdletMetadata, UXMetadataCommandExample example, ReportLogger<UXMetadataIssue> issueLogger)
         {
+            if (example.Parameters == null)
+            {
+                return;
+            }
             List<string> parameterListConvertedFromAlias = example.Parameters.Select(x =>
             {
                 string parameterNameInExample = x.Name.Trim('-');