[Az.ServiceFabric] Add parameters to New-AzServiceFabricManagedCluster, Set-AzServiceFabricManagedCluster, New-AzServiceFabricManagedNodeType, and Set-AzServiceFabricManagedNodeType (#28591)

Author: iliu816

src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.cs

@@ -41,6 +41,13 @@ public void TestNodeTypeOperations()
             TestRunner.RunTestScript("Test-NodeTypeOperations");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestNodeTypeUpdate()
+        {
+            TestRunner.RunTestScript("Test-NodeTypeUpdate");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestNodeTypeVmSizeChange()

src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.ps1

@@ -24,10 +24,17 @@ function Test-CreateBasicCluster
 	Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
 
 	$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-		-AdminPassword $pass -Sku Basic -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
+		-AdminPassword $pass -Sku Basic -ClientCertThumbprint $testClientTp -Tag $tags -AllowRdpAccess -EnableAutoOsUpgrade -Verbose
 	Assert-AreEqual "Succeeded" $cluster.ProvisioningState
 	Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
 	Assert-AreEqual "Wave0" $cluster.ClusterUpgradeCadence
+	Assert-True { $cluster.EnableAutoOsUpgrade }
+	Assert-True { $cluster.AllowRdpAccess }
+
+	$updatedCluster = Set-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -EnableAutoOsUpgrade $false -AllowRdpAccess $false -Verbose
+	Assert-AreEqual "Succeeded" $updatedCluster.ProvisioningState
+	Assert-False { $updatedCluster.EnableAutoOsUpgrade }
+	Assert-False { $updatedCluster.AllowRdpAccess }
 
 	$pnt = New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -DiskType Standard_LRS -Primary
 	Assert-AreEqual 5 $pnt.VmInstanceCount
@@ -50,6 +57,52 @@ function Test-CreateBasicCluster
 	Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName } "NotFound"
 }
 
+function Test-NodeTypeUpdate
+{
+	$resourceGroupName = "sfmcps-rg-" + (getAssetname)
+	$clusterName = "sfmcps-" + (getAssetname)
+	$location = "southcentralus"
+	$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
+	$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
+	$clusterTags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.UseUnmonitoredAutoClusterUpgradePolicy"="True"; "testName"="Test-NodeTypeUpdate"}
+
+	Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
+
+	$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -UpgradeMode Automatic -UpgradeCadence Wave1 -Location $location `
+		-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $clusterTags -Verbose
+	Assert-AreEqual "Succeeded" $cluster.ProvisioningState
+	Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
+	Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
+	Assert-AreEqual "Wave1" $cluster.ClusterUpgradeCadence
+
+	New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary -DiskType Premium_LRS -VmSize "Standard_DS2" -AsJob
+	New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -InstanceCount 6 -Zone @("1", "2") -ZoneBalance -EnableOverProvisioning -IsStateless -AsJob
+
+	#wait for nodetypes
+	WaitForAllJob
+
+	$pnt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt
+	Assert-AreEqual "Premium_LRS" $pnt.DataDiskType
+	Assert-False { $pnt.IsStateless }
+
+	$snt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt
+	Assert-AreEqual "StandardSSD_LRS" $snt.DataDiskType
+	Assert-True { $snt.IsStateless }
+	Assert-AreEqual 2 $snt.Zones.Count
+	Assert-True { $snt.EnableOverProvisioning }
+	Assert-True { $snt.ZoneBalance }
+
+	$snt = Set-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -Zone @("1", "2", "3")
+	Assert-AreEqual 3 $snt.Zones.Count
+
+	$snt = Set-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name snt -ZoneBalance $false -EnableOverProvisioning $false
+	Assert-False { $snt.EnableOverProvisioning }
+	Assert-False { $snt.ZoneBalance }
+
+	$removeResponse = $cluster | Remove-AzServiceFabricManagedCluster -PassThru
+	Assert-True { $removeResponse }
+}
+
 function Test-NodeTypeOperations
 {
 	$resourceGroupName = "sfmcps-rg-" + (getAssetname)