Authentication.csproj should not be referenced by module project (#12311)

* Recovery service project should not reference Authentication project directly

* update changelog

* Update ChangeLog.md

* remove project reference to Authentication.csproj from AnalysisServices project

* Update ChangeLog.md

Co-authored-by: Yabo Hu <[email protected]>

Author: erich-wang

src/AnalysisServices/AnalysisServices.Dataplane/AnalysisServices.Dataplane.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <PsModuleName>AnalysisServices</PsModuleName>
@@ -10,9 +10,4 @@
     <AssemblyName>$(AzAssemblyPrefix)$(PsModuleName).Dataplane</AssemblyName>
     <RootNamespace>$(LegacyAssemblyPrefix)$(PsModuleName).Dataplane</RootNamespace>
   </PropertyGroup>
-
-  <ItemGroup>
-    <ProjectReference Include="..\..\Accounts\Authentication\Authentication.csproj" />
-  </ItemGroup>
-
 </Project>

src/AnalysisServices/AnalysisServices.Dataplane/Models/AsAzureDataplaneCmdletBase.cs

@@ -134,7 +134,7 @@ internal static AsAzureDataplaneClient CreateAsAzureDataplaneClient(string hostU
         {
             if (context == null)
             {
-                throw new ArgumentException(Common.Authentication.Properties.Resources.ArmAccountNotFound);
+                throw new ArgumentException(Resources.ArmAccountNotFound);
             }
 
             if (string.IsNullOrEmpty(hostUri))

src/AnalysisServices/AnalysisServices.Dataplane/Properties/Resources.Designer.cs

@@ -164,4 +164,7 @@ Use the Enable-AzDataCollection cmdlet to turn the feature On. The cmdlet can be
   <data name="SyncASPollStatusUnknownMessage" xml:space="preserve">
     <value>Failed to get the status of the synchronization request for the specified database. ServerName: {0}, RootActivityId: {1}, Date (UTC): {2}, Details: {3}.</value>
   </data>
+  <data name="ArmAccountNotFound" xml:space="preserve">
+    <value>No account found in the context. Please login using Connect-AzAccount.</value>
+  </data>
 </root>

src/AnalysisServices/AnalysisServices.Dataplane/Properties/Resources.resx

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Removed project reference to Authentication
 
 ## Version 1.1.3
 * Updated assembly version of data plane cmdlets

src/AnalysisServices/AnalysisServices/ChangeLog.md

@@ -18,9 +18,11 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Removed project reference to Authentication
 * Azure Backup tuned cmdlets help text to be more accurate.
 * Azure Backup added support for fetching MAB agent jobs using `Get-AzRecoveryServicesBackupJob` cmdlet.
 
+
 ## Version 2.10.0
 * Azure Backup added support for fetching MAB items.
 * Azure Site Recovery support to update failover and test failover NIC names, existing NIC reuse.

src/RecoveryServices/RecoveryServices/ChangeLog.md

@@ -14,15 +14,14 @@
 
 using System;
 using System.Collections.Generic;
-using System.Configuration;
 using System.Diagnostics.CodeAnalysis;
 using System.Net.Security;
+using Microsoft.Azure.Commands.Common.Authentication;
+using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
 using Microsoft.Azure.Management.Internal.Resources;
 using Microsoft.Azure.Management.RecoveryServices;
-using Microsoft.Azure.Portal.RecoveryServices.Models.Common;
-using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
-using Microsoft.Azure.Common.Authentication;
 using Microsoft.Azure.Management.RecoveryServices.Backup;
+using Microsoft.Azure.Portal.RecoveryServices.Models.Common;
 
 namespace Microsoft.Azure.Commands.RecoveryServices
 {
@@ -114,14 +113,14 @@ public PSRecoveryServicesClient(IAzureContext defaultContext)
             }
 
             this.recoveryServicesClient =
-            AzureSession.ClientFactory.CreateArmClient<RecoveryServicesClient>(
+            AzureSession.Instance.ClientFactory.CreateArmClient<RecoveryServicesClient>(
                 defaultContext, AzureEnvironment.Endpoint.ResourceManager);
 
             this.recoveryServicesBackupClient =
-            AzureSession.ClientFactory.CreateArmClient<RecoveryServicesBackupClient>(
+            AzureSession.Instance.ClientFactory.CreateArmClient<RecoveryServicesBackupClient>(
                 defaultContext, AzureEnvironment.Endpoint.ResourceManager);
 
-            resourceManagementClient = AzureSession.ClientFactory.CreateArmClient<ResourceManagementClient>(defaultContext, AzureEnvironment.Endpoint.ResourceManager);
+            resourceManagementClient = AzureSession.Instance.ClientFactory.CreateArmClient<ResourceManagementClient>(defaultContext, AzureEnvironment.Endpoint.ResourceManager);
         }
 
         private static bool IgnoreCertificateErrorHandler

src/RecoveryServices/RecoveryServices/Common/PSRecoveryServicesClient.cs

@@ -16,10 +16,6 @@
     <PackageReference Include="System.Security.Cryptography.Cng" Version="4.4.0" />
   </ItemGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\..\Accounts\Authentication\Authentication.csproj" />
-  </ItemGroup>
-
   <ItemGroup>
     <Compile Update="Properties\Resources.Designer.cs">
       <DesignTime>True</DesignTime>