[Monitor]Fixed New-AzMetricAlertRuleV2DimensionSelection to have exclude or in… (#22469)

* Fixed New-AzMetricAlertRuleV2DimensionSelection to have exclude or include values only

* suppress breaking change warning

Author: VeryEarly

src/Monitor/Monitor/Alerts/NewAzureRmMetricAlertRuleV2CriteriaCommand.cs

@@ -165,7 +165,7 @@ protected override void ProcessRecordInternal()
                     {
                         metricDimensions.Add(new MetricDimension(dimension.Dimension, "Include", dimension.IncludeValues));
                     }
-                    if (dimension.ExcludeValues != null && dimension.ExcludeValues.Count() > 0)
+                    else if (dimension.ExcludeValues != null && dimension.ExcludeValues.Count() > 0)
                     {
                         metricDimensions.Add(new MetricDimension(dimension.Dimension, "Exclude", dimension.ExcludeValues));
                     }

src/Monitor/Monitor/Alerts/NewAzureRmMetricAlertRuleV2DimensionSelectionCommand.cs

@@ -21,7 +21,7 @@ namespace Microsoft.Azure.Commands.Insights.Alerts
     /// <summary>
     /// Create Dimension object
     /// </summary>
-    [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "MetricAlertRuleV2DimensionSelection"), OutputType(typeof(PSMetricDimension))]
+    [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "MetricAlertRuleV2DimensionSelection", DefaultParameterSetName = "IncludeParameterSet"), OutputType(typeof(PSMetricDimension))]
     public class NewAzureRmMetricAlertRuleV2DimensionSelectionCommand : MonitorCmdletBase
     {
         /// <summary>
@@ -33,13 +33,13 @@ public class NewAzureRmMetricAlertRuleV2DimensionSelectionCommand : MonitorCmdle
         /// <summary>
         /// Gets or sets IncludeValues parameter of the cmdlet
         /// </summary>
-        [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The IncludeValues")]
+        [Parameter(ParameterSetName = "IncludeParameterSet", Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The IncludeValues")]
         public String[] ValuesToInclude { get; set; }
 
         /// <summary>
         /// Gets or sets ExcludeValues parameter of the cmdlet
         /// </summary>
-        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The ExcludeValues")]
+        [Parameter(ParameterSetName = "ExcludeParameterSet", Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The ExcludeValues")]
         public String[] ValuesToExclude { get; set; }
 
 

src/Monitor/Monitor/ChangeLog.md

@@ -19,6 +19,7 @@
 -->
 
 ## Upcoming Release
+* Fixed `New-AzMetricAlertRuleV2DimensionSelection` to have "exclude" or "include" values only [#22256]
 * Fixed `Add-AzMetriAlertRuleV2` and `Get-AzMetricAlertRuleV2` to support web tests criteria [#22350]
 * Added parameter `Dimension` for `Get-AzMetric` to easily filter metrics by dimensions [#22320]
 

src/Monitor/Monitor/help/New-AzMetricAlertRuleV2DimensionSelection.md

@@ -12,9 +12,16 @@ Creates a local dimension selection object that can be used to construct a metri
 
 ## SYNTAX
 
+### IncludeParameterSet (Default)
 ```
 New-AzMetricAlertRuleV2DimensionSelection -DimensionName <String> -ValuesToInclude <String[]>
- [-ValuesToExclude <String[]>] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+ [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+```
+
+### ExcludeParameterSet
+```
+New-AzMetricAlertRuleV2DimensionSelection -DimensionName <String> -ValuesToExclude <String[]>
+ [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -73,10 +80,10 @@ The ExcludeValues
 
 ```yaml
 Type: System.String[]
-Parameter Sets: (All)
+Parameter Sets: ExcludeParameterSet
 Aliases:
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: True (ByPropertyName)
@@ -88,7 +95,7 @@ The IncludeValues
 
 ```yaml
 Type: System.String[]
-Parameter Sets: (All)
+Parameter Sets: IncludeParameterSet
 Aliases:
 
 Required: True

tools/StaticAnalysis/Exceptions/Az.Monitor/BreakingChangeIssues.csv

@@ -0,0 +1,2 @@
+"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
+"Az.Monitor","Microsoft.Azure.Commands.Insights.Alerts.NewAzureRmMetricAlertRuleV2DimensionSelectionCommand","New-AzMetricAlertRuleV2DimensionSelection","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzMetricAlertRuleV2DimensionSelection' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzMetricAlertRuleV2DimensionSelection'."