release-2020-08-28

Author: dingmeng-xue

ChangeLog.md

@@ -1,3 +1,7 @@
+## 4.6.1 - August 2020
+#### Az.Compute
+* Patched '-EncryptionAtHost' parameter in 'New-AzVm' to remove default value of false [#12776]
+
 ## 4.6.0 - August 2020
 #### Az.Accounts
 * Loaded all public cloud environments when discovery endpoint doesn't return default AzureCloud or other public environments [#12633]

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs

@@ -291,6 +291,13 @@ public void TestLowPriorityVirtualMachine()
             TestRunner.RunTestScript("Test-LowPriorityVirtualMachine");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestEncryptionAtHostVMNull()
+        {
+            TestRunner.RunTestScript("Test-EncryptionAtHostVMNull");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestEncryptionAtHostVM()

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1

@@ -3905,6 +3905,47 @@ function Test-LowPriorityVirtualMachine
     }
 }
 
+<#
+.SYNOPSIS
+Test EncryptionAtHost Virtual Machine
+#>
+function Test-EncryptionAtHostVMNull
+{
+    # Setup
+    $rgname = Get-ComputeTestResourceName
+
+    try
+    {
+        $loc = Get-ComputeVMLocation;
+        New-AzResourceGroup -Name $rgname -Location $loc -Force;
+
+        # VM Profile & Hardware
+        $vmsize = 'Standard_DS2_v2';
+        $vmname = 'vm' + $rgname;
+        [string]$domainNameLabel = "$vmname-$vmname".tolower();
+
+        $user = "Foo2";
+        $password = $PLACEHOLDER;
+        $securePassword = ConvertTo-SecureString $password -AsPlainText -Force;
+        $cred = New-Object System.Management.Automation.PSCredential ($user, $securePassword);
+        $computerName = 'test';
+
+        $vm = New-AzVM -ResourceGroupName $rgname -Name $vmname -Credential $cred -DomainNameLabel $domainNameLabel;
+        Assert-AreEqual $null $vm.SecurityProfile.encryptionathost
+
+        # Get VM
+        $vm = Get-AzVM -ResourceGroupName $rgname -Name $vmname;
+        Assert-AreEqual $null $vm.SecurityProfile.encryptionAtHost
+        Assert-AreEqual $null $vm.encryptionAtHost
+
+    }
+    finally
+    {
+        # Cleanup
+        Clean-ResourceGroup $rgname
+    }
+}
+
 <#
 .SYNOPSIS
 Test EncryptionAtHost Virtual Machine

src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests/TestEncryptionAtHostVMNull.json

@@ -3,7 +3,7 @@
 #
 # Generated by: Microsoft Corporation
 #
-# Generated on: 8/21/2020
+# Generated on: 8/28/2020
 #
 
 @{
@@ -12,7 +12,7 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '4.3.0'
+ModuleVersion = '4.3.1'
 
 # Supported PSEditions
 CompatiblePSEditions = 'Core', 'Desktop'
@@ -205,10 +205,7 @@ PrivateData = @{
         # IconUri = ''
 
         # ReleaseNotes of this module
-        ReleaseNotes = '* Added ''-EncryptionAtHost'' parameter to ''New-AzVm'', ''New-AzVmss'', ''New-AzVMConfig'', ''New-AzVmssConfig'', ''Update-AzVM'', and ''Update-AzVmss''
-* Added ''SecurityProfile'' to ''Get-AzVM'' and ''Get-AzVmss'' return object
-* Added ''-InstanceView'' switch as optional parameter to ''Get-AzHostGroup''
-* Added new cmdlet ''Invoke-AzVmPatchAssessment'''
+        ReleaseNotes = '* Patched ''-EncryptionAtHost'' parameter in ''New-AzVm'' to remove default value of false [#12776]'
 
         # Prerelease string of this module
         # Prerelease = ''

src/Compute/Compute/Az.Compute.psd1

@@ -26,6 +26,9 @@
 * Added the '-InstanceView' switch as optional parameter to Get-AzHostGroup
 * Added the '-HostGroupId' parameter to New-AzVm and New-AzVmss
 
+## Version 4.3.1
+* Patched `-EncryptionAtHost` parameter in `New-AzVm` to remove default value of false [#12776]
+
 ## Version 4.3.0
 * Added `-EncryptionAtHost` parameter to `New-AzVm`, `New-AzVmss`, `New-AzVMConfig`, `New-AzVmssConfig`, `Update-AzVM`, and `Update-AzVmss`
 * Added `SecurityProfile` to `Get-AzVM` and `Get-AzVmss` return object

src/Compute/Compute/ChangeLog.md

@@ -25,8 +25,8 @@
 [assembly: ComVisible(false)]
 [assembly: CLSCompliant(false)]
 [assembly: Guid("91792853-487B-4DC2-BE6C-DD09A0A1BC10")]
-[assembly: AssemblyVersion("4.3.0")]
-[assembly: AssemblyFileVersion("4.3.0")]
+[assembly: AssemblyVersion("4.3.1")]
+[assembly: AssemblyFileVersion("4.3.1")]
 #if !SIGN
 [assembly: InternalsVisibleTo("Microsoft.Azure.PowerShell.Cmdlets.Compute.Test")]
 #endif

src/Compute/Compute/Properties/AssemblyInfo.cs

@@ -82,10 +82,7 @@ internal static ResourceConfig<VirtualMachineScaleSet> CreateVirtualMachineScale
                     AdditionalCapabilities = ultraSSDEnabled ? new AdditionalCapabilities(true) : null,
                     VirtualMachineProfile = new VirtualMachineScaleSetVMProfile
                     {
-                        SecurityProfile = new SecurityProfile
-                        {
-                            EncryptionAtHost = encryptionAtHost
-                        },
+                        SecurityProfile = (encryptionAtHost == true) ? new SecurityProfile(encryptionAtHost) : null,
                         OsProfile = new VirtualMachineScaleSetOSProfile
                         {
                             ComputerNamePrefix = name.Substring(0, Math.Min(name.Length, 9)),

src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs

@@ -57,7 +57,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
             string priority,
             string evictionPolicy,
             double? maxPrice,
-            bool? encryptionAtHostEnabled)
+            bool encryptionAtHostPresent)
 
             => Strategy.CreateResourceConfig(
                 resourceGroup: resourceGroup,
@@ -99,7 +99,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
                     Priority = priority,
                     EvictionPolicy = evictionPolicy,
                     BillingProfile = (maxPrice == null) ? null : new BillingProfile(maxPrice),
-                    SecurityProfile = (encryptionAtHostEnabled == null) ? null : new SecurityProfile(encryptionAtHostEnabled)
+                    SecurityProfile = (encryptionAtHostPresent == true) ? new SecurityProfile(encryptionAtHostPresent) : null
                 });
 
         public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
@@ -120,7 +120,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
             string priority,
             string evictionPolicy,
             double? maxPrice,
-            bool? encryptionAtHostEnabled
+            bool encryptionAtHostPresent
             )
             => Strategy.CreateResourceConfig(
                 resourceGroup: resourceGroup,
@@ -159,10 +159,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
                     Priority = priority,
                     EvictionPolicy = evictionPolicy,
                     BillingProfile = (maxPrice == null) ? null : new BillingProfile(maxPrice),
-                    SecurityProfile = new SecurityProfile
-                    {
-                        EncryptionAtHost = encryptionAtHostEnabled
-                    }
+                    SecurityProfile = (encryptionAtHostPresent == true) ? new SecurityProfile(encryptionAtHostPresent) : null
                 });
     }
 }

src/Compute/Compute/Strategies/ComputeRp/VirtualMachineStrategy.cs

@@ -122,7 +122,7 @@ public class NewAzureVMConfigCommand : Microsoft.Azure.Commands.ResourceManager.
            Mandatory = false,
            ValueFromPipelineByPropertyName = false,
            HelpMessage = "EncryptionAtHost property can be used by user in the request to enable or disable the Host Encryption for the virtual machine. This will enable the encryption for all the disks including Resource/Temp disk at host itself.")]
-        public SwitchParameter EncryptionAtHost { get; set; } = false;
+        public SwitchParameter EncryptionAtHost { get; set; }
 
         protected override bool IsUsageMetricEnabled
         {