Addressed PR comments, Added Linux Help Cmmnts, Updated Session Recordings

ookoka · ookoka · commit cd8d5efb8041 · 2025-10-14T13:24:19.000-04:00
diff --git a/src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1 b/src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1
@@ -6001,14 +6001,14 @@ function Test-VirtualMachineScaleSetAddProxyAgentExtension
 
         # Update vmss to add proxy agent extension 
         $VMSS = Get-AzVmss -ResourceGroupName $rgname -VMScaleSetName $vmssName
-        $VMSS = Set-AzVmssProxyAgentSetting -VirtualMachineScaleSet $VMSS -EnableProxyAgent $true -AddProxyAgentExtension $true
+        $VMSS = Set-AzVmssProxyAgentSetting -VirtualMachineScaleSet $VMSS -EnableProxyAgent $true -AddProxyAgentExtension $false
         $vmssUpdated = Update-AzVmss -ResourceGroupName $rgname -Name $vmssName -VirtualMachineScaleSet $VMSS
 
         
 
         # Validate 
         Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.Enabled $true
-        Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.AddProxyAgentExtension $true
+        Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.AddProxyAgentExtension $false
     }
     finally
     {
diff --git a/src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests/TestVirtualMachineScaleSetAddProxyAgentExtension.json b/src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests/TestVirtualMachineScaleSetAddProxyAgentExtension.json
diff --git a/src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests/TestVirtualMachineAddProxyAgentExtension.json b/src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests/TestVirtualMachineAddProxyAgentExtension.json
diff --git a/src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/SetAzVmssProxyAgentSetting.cs b/src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/SetAzVmssProxyAgentSetting.cs
@@ -72,7 +72,7 @@ public class SetAzureVmssProxySetting : Microsoft.Azure.Commands.ResourceManager
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
-            HelpMessage = "Specifies whether to add installation of the ProxyAgent extension.")]
+            HelpMessage = "Specify whether to implicitly install the ProxyAgent Extension. This option is currently applicable only for Linux Os.")]
         public bool? AddProxyAgentExtension { get; set; }
 
         public override void ExecuteCmdlet()
diff --git a/src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs b/src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs
@@ -296,7 +296,7 @@ public partial class NewAzureRmVmss : ComputeAutomationBaseCmdlet
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
             ParameterSetName = SimpleParameterSet,
-            HelpMessage = "Specifies whether to add installation of the ProxyAgent extension.")]
+            HelpMessage = "Specify whether to implicitly install the ProxyAgent Extension. This option is currently applicable only for Linux Os.")]
         public SwitchParameter AddProxyAgentExtension { get; set; }
 
         private void ConfigureSecuritySettings()
diff --git a/src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs b/src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
@@ -115,7 +115,7 @@ internal static ResourceConfig<VirtualMachineScaleSet> CreateVirtualMachineScale
                                 EncryptionAtHost = encryptionAtHost,
                                 UefiSettings = (enableVtpm != null || enableSecureBoot != null) ? new UefiSettings(enableSecureBoot, enableVtpm) : null,
                                 SecurityType = securityType,
-                                ProxyAgentSettings = (enableProxyAgent != null || addProxyAgentExtension != null) ? new ProxyAgentSettings(enableProxyAgent) { AddProxyAgentExtension = addProxyAgentExtension } : null,
+                                ProxyAgentSettings = (enableProxyAgent != null || addProxyAgentExtension != null) ? new ProxyAgentSettings(enabled: enableProxyAgent, addProxyAgentExtension: addProxyAgentExtension): null,
                             },
                             OsProfile = new VirtualMachineScaleSetOSProfile
                             {
@@ -287,7 +287,7 @@ internal static ResourceConfig<VirtualMachineScaleSet> CreateVirtualMachineScale
                                 EncryptionAtHost = encryptionAtHost,
                                 UefiSettings = (enableVtpm != null || enableSecureBoot != null) ? new UefiSettings(enableSecureBoot, enableVtpm) : null,
                                 SecurityType = securityType,
-                                ProxyAgentSettings = (enableProxyAgent != null || addProxyAgentExtension != null) ? new ProxyAgentSettings(enableProxyAgent) { AddProxyAgentExtension = addProxyAgentExtension } : null,
+                                ProxyAgentSettings = (enableProxyAgent != null || addProxyAgentExtension != null) ? new ProxyAgentSettings(enabled: enableProxyAgent, addProxyAgentExtension: addProxyAgentExtension) : null,
                             },
                             OsProfile = new VirtualMachineScaleSetOSProfile
                             {
diff --git a/src/Compute/Compute/Strategies/ComputeRp/VirtualMachineStrategy.cs b/src/Compute/Compute/Strategies/ComputeRp/VirtualMachineStrategy.cs
@@ -164,7 +164,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
                             EncryptionAtHost = encryptionAtHostPresent,
                             UefiSettings = (enableVtpm != null || enableSecureBoot != null) ? new UefiSettings(enableSecureBoot, enableVtpm) : null,
                             SecurityType = securityType,
-                            ProxyAgentSettings = (enableProxyAgent != null || addProxyAgentExtension != null) ? new ProxyAgentSettings(enableProxyAgent) { AddProxyAgentExtension = addProxyAgentExtension } : null,
+                            ProxyAgentSettings = (enableProxyAgent != null || addProxyAgentExtension != null) ? new ProxyAgentSettings(enabled: enableProxyAgent, addProxyAgentExtension: addProxyAgentExtension): null,
                         },
                         CapacityReservation = string.IsNullOrEmpty(capacityReservationGroupId) ? null : new CapacityReservationProfile
                         {
diff --git a/src/Compute/Compute/VirtualMachine/Config/SetAzVMProxyAgentSetting.cs b/src/Compute/Compute/VirtualMachine/Config/SetAzVMProxyAgentSetting.cs
@@ -76,7 +76,7 @@ public class SetAzureVMProxySetting : Microsoft.Azure.Commands.ResourceManager.C
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
-            HelpMessage = "Specifies whether to add installation of the ProxyAgent extension.")]
+            HelpMessage = "Specify whether to implicitly install the ProxyAgent Extension. This option is currently applicable only for Linux Os.")]
         public bool? AddProxyAgentExtension { get; set; }
 
         public override void ExecuteCmdlet()
diff --git a/src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs b/src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs
@@ -501,7 +501,7 @@ public class NewAzureVMCommand : VirtualMachineBaseCmdlet
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
             ParameterSetName = SimpleParameterSet,
-            HelpMessage = "Specifies whether to add installation of the ProxyAgent extension.")]
+            HelpMessage = "Specify whether to implicitly install the ProxyAgent Extension. This option is currently applicable only for Linux Os.")]
         public SwitchParameter AddProxyAgentExtension { get; set; }
 
         public override void ExecuteCmdlet()

Original file line number	Diff line number	Diff line change
`@@ -6001,14 +6001,14 @@ function Test-VirtualMachineScaleSetAddProxyAgentExtension`
`6001`	`6001`
`6002`	`6002`	`# Update vmss to add proxy agent extension`
`6003`	`6003`	`$VMSS = Get-AzVmss -ResourceGroupName $rgname -VMScaleSetName $vmssName`
`6004`		`- $VMSS = Set-AzVmssProxyAgentSetting -VirtualMachineScaleSet $VMSS -EnableProxyAgent $true -AddProxyAgentExtension $true`
	`6004`	`+ $VMSS = Set-AzVmssProxyAgentSetting -VirtualMachineScaleSet $VMSS -EnableProxyAgent $true -AddProxyAgentExtension $false`
`6005`	`6005`	`$vmssUpdated = Update-AzVmss -ResourceGroupName $rgname -Name $vmssName -VirtualMachineScaleSet $VMSS`
`6006`	`6006`
`6007`	`6007`
`6008`	`6008`
`6009`	`6009`	`# Validate`
`6010`	`6010`	`Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.Enabled $true`
`6011`		`- Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.AddProxyAgentExtension $true`
	`6011`	`+ Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.AddProxyAgentExtension $false`
`6012`	`6012`	`}`
`6013`	`6013`	`finally`
`6014`	`6014`	`{`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(`
`164`	`164`	`EncryptionAtHost = encryptionAtHostPresent,`
`165`	`165`	`UefiSettings = (enableVtpm != null \|\| enableSecureBoot != null) ? new UefiSettings(enableSecureBoot, enableVtpm) : null,`
`166`	`166`	`SecurityType = securityType,`
`167`		`- ProxyAgentSettings = (enableProxyAgent != null \|\| addProxyAgentExtension != null) ? new ProxyAgentSettings(enableProxyAgent) { AddProxyAgentExtension = addProxyAgentExtension } : null,`
	`167`	`+ ProxyAgentSettings = (enableProxyAgent != null \|\| addProxyAgentExtension != null) ? new ProxyAgentSettings(enabled: enableProxyAgent, addProxyAgentExtension: addProxyAgentExtension): null,`
`168`	`168`	`},`
`169`	`169`	`CapacityReservation = string.IsNullOrEmpty(capacityReservationGroupId) ? null : new CapacityReservationProfile`
`170`	`170`	`{`