Added support for AlwaysOn soft delete state (#22817)

* Added support for AlwaysOn soft delete state

* suppressed false positive example issues

Author: hiaga

src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Vault/SetAzureRmRecoveryServicesVaultProperty.cs

@@ -33,7 +33,7 @@ public class SetAzureRmRecoveryServicesVaultProperty : RSBackupVaultCmdletBase
 
         [Parameter(Mandatory = false, ValueFromPipeline = false, ParameterSetName = AzureRSVaultSoftDelteParameterSet)]
         [ValidateNotNullOrEmpty]
-        [ValidateSet("Enable", "Disable")]
+        [ValidateSet("Enable", "Disable", "AlwaysON")]
         public string SoftDeleteFeatureState { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipeline = false, ParameterSetName = AzureRSVaultSoftDelteParameterSet, HelpMessage = ParamHelpMsgs.ResourceGuard.AuxiliaryAccessToken)]
@@ -80,9 +80,10 @@ public override void ExecuteCmdlet()
                     {
                         BackupResourceVaultConfigResource currentConfig = ServiceClientAdapter.GetVaultProperty(vaultName, resourceGroupName);
                         BackupResourceVaultConfigResource param = new BackupResourceVaultConfigResource();
-                        param.Properties = new BackupResourceVaultConfig();                        
+                        param.Properties = new BackupResourceVaultConfig();
+
+                        param.Properties.SoftDeleteFeatureState = (SoftDeleteFeatureState.ToLower() == "alwayson") ? "AlwaysON" : ((SoftDeleteFeatureState != null) ? SoftDeleteFeatureState + "d" : currentConfig.Properties.SoftDeleteFeatureState);
 
-                        param.Properties.SoftDeleteFeatureState = (SoftDeleteFeatureState != null) ? SoftDeleteFeatureState + "d" : currentConfig.Properties.SoftDeleteFeatureState;
                         param.Properties.EnhancedSecurityState = (DisableHybridBackupSecurityFeature != null) ? (((bool)DisableHybridBackupSecurityFeature) ? "Disabled" : "Enabled") : currentConfig.Properties.EnhancedSecurityState;
 
                         bool isMUAProtected = checkMUAForSoftDelete(currentConfig, param);

src/RecoveryServices/RecoveryServices/ChangeLog.md

@@ -20,6 +20,7 @@
 ## Upcoming Release
 * Added support for custom RG with suffix while creating or modifying policy for workload type AzureVM.
 * Added TLaD warning https://aka.ms/TLaD for Azure Site Recovery and Backup.
+* Added support for setting AlwaysON soft delete state for recovery services vault.
 
 ## Version 6.5.1
 * Added StorageAccountName property to AzureFileShare job.

src/RecoveryServices/RecoveryServices/help/Set-AzRecoveryServicesVaultProperty.md

@@ -29,7 +29,7 @@ Set-AzRecoveryServicesVaultProperty [-VaultId <String>] [-DefaultProfile <IAzure
 ```
 
 ## DESCRIPTION
-The **Set-AzRecoveryServicesVaultProperty** cmdlet updates properties of a Recovery services vault. This cmdlet can be used to enable/disable soft delete or set CMK encryption for a vault with two different parameter sets. 
+The **Set-AzRecoveryServicesVaultProperty** cmdlet updates properties of a Recovery services vault. This cmdlet can be used to Enable/Disable/AlwaysON soft delete or set CMK encryption for a vault with two different parameter sets. 
 **SoftDeleteFeatureState** property of a vault can be disabled only if there are no registered containers in the vault. InfrastructurEncryption can only be set the first time a user updates the CMK vault.
 
 ## EXAMPLES
@@ -41,7 +41,7 @@ $props = Set-AzRecoveryServicesVaultProperty -VaultId $vault.Id -SoftDeleteFeatu
 ```
 
 The first command gets a Vault object and then stores it in the $vault variable.
-The second command Updates the SoftDeleteFeatureState property of the vault to "Enabled" state.
+The second command Updates the SoftDeleteFeatureState property of the vault to "Enabled" state. Allowed values for SoftDeleteFeatureState are Disable, Enable, AlwaysON.
 
 ### Example 2: Update CMK encryption of a vault to use SystemAssigned MSIdentity
 
@@ -155,7 +155,7 @@ Accept wildcard characters: False
 ```
 
 ### -SoftDeleteFeatureState
-SoftDeleteFeatureState of the Recovery Services Vault.
+SoftDeleteFeatureState of the Recovery Services Vault. Allowed values are Disable, Enable, AlwaysON.
 
 ```yaml
 Type: System.String

tools/StaticAnalysis/Exceptions/Az.RecoveryServices/ExampleIssues.csv

@@ -1,3 +1,7 @@
 "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
 "Az.RecoveryServices","Set-AzRecoveryServicesBackupProtectionPolicy","1","19","Invalid_Parameter_Name","5011","1","Set-AzRecoveryServicesBackupProtectionPolicy -BackupSnapshotResourceGroup is not a valid parameter name.","-BackupSnapshotResourceGroup","Check validity of the parameter -BackupSnapshotResourceGroup."
 "Az.RecoveryServices","Set-AzRecoveryServicesBackupProtectionPolicy","1","19","Invalid_Parameter_Name","5011","1","Set-AzRecoveryServicesBackupProtectionPolicy -BackupSnapshotResourceGroupSuffix is not a valid parameter name.","-BackupSnapshotResourceGroupSuffix","Check validity of the parameter -BackupSnapshotResourceGroupSuffix."
+"Az.RecoveryServices","Set-AzRecoveryServicesVaultProperty","2","2","Invalid_Cmdlet","5000","1","Get-AzKeyVault is not a valid command name.","Get-AzKeyVault -VaultName 'keyVaultName' -ResourceGroupName 'RGName'","Check the spell of Get-AzKeyVault."
+"Az.RecoveryServices","Set-AzRecoveryServicesVaultProperty","2","3","Invalid_Cmdlet","5000","1","Get-AzKeyVaultKey is not a valid command name.","Get-AzKeyVaultKey -VaultName 'keyVaultName' -Name 'keyName'","Check the spell of Get-AzKeyVaultKey."
+"Az.RecoveryServices","Set-AzRecoveryServicesVaultProperty","3","2","Invalid_Cmdlet","5000","1","Get-AzKeyVault is not a valid command name.","Get-AzKeyVault -VaultName 'keyVaultName' -ResourceGroupName 'RGName'","Check the spell of Get-AzKeyVault."
+"Az.RecoveryServices","Set-AzRecoveryServicesVaultProperty","3","3","Invalid_Cmdlet","5000","1","Get-AzKeyVaultKey is not a valid command name.","Get-AzKeyVaultKey -VaultName 'keyVaultName' -Name 'keyName'","Check the spell of Get-AzKeyVaultKey."