[Breaking Change] Renamed the property ResouceType of ASRVaultSettings to ResourceType (#23873)

* Renamed the property ResouceType of ASRVaultSettings to ResourceType

* Add a space to trigger CI.

---------

Co-authored-by: Yan Xu <[email protected]>

Author: wyunchi-ms

src/RecoveryServices/RecoveryServices.SiteRecovery/Models/PSObjects.cs

@@ -49,7 +49,7 @@ public ASRVaultSettings(
             this.ResourceName = asrVaultCreds.ResourceName;
             this.ResourceGroupName = asrVaultCreds.ResourceGroupName;
             this.ResourceNamespace = asrVaultCreds.ResourceNamespace;
-            this.ResouceType = asrVaultCreds.ARMResourceType;
+            this.ResourceType = asrVaultCreds.ARMResourceType;
         }
 
         #region Properties
@@ -72,7 +72,7 @@ public ASRVaultSettings(
         /// <summary>
         ///     Gets or sets Resource Type.
         /// </summary>
-        public string ResouceType { get; set; }
+        public string ResourceType { get; set; }
 
         #endregion Properties
     }

src/RecoveryServices/RecoveryServices.SiteRecovery/Vault/GetAzureRmRecoveryServicesAsrVaultContext.cs

@@ -21,7 +21,6 @@ namespace Microsoft.Azure.Commands.RecoveryServices.SiteRecovery
     /// <summary>
     ///     Gets ASR vault settings information for the Recovery Services vault.
     /// </summary>
-    [CmdletOutputBreakingChangeWithVersion(typeof(ASRVaultSettings), "12.0.0", "7.0.0", DeprecatedOutputProperties = new string[] { "ResouceType" }, NewOutputProperties = new string[] { "ResourceType" })]
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "RecoveryServicesAsrVaultContext")]
     [OutputType(typeof(ASRVaultSettings))]
     [Alias(

src/RecoveryServices/RecoveryServices.SiteRecovery/Vault/ImportAzureRmRecoveryServicesAsrVaultSettingsFile.cs

@@ -28,7 +28,6 @@ namespace Microsoft.Azure.Commands.RecoveryServices.SiteRecovery
     ///     Imports the specified ASR vault settings file to set the vault context(PowerShell session context)
     ///     for subsequent ASR operations in the PowerShell session. 
     /// </summary>
-    [CmdletOutputBreakingChangeWithVersion(typeof(ASRVaultSettings), "12.0.0", "7.0.0", DeprecatedOutputProperties = new string[] { "ResouceType" }, NewOutputProperties = new string[] { "ResourceType" })]
     [Cmdlet("Import", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "RecoveryServicesAsrVaultSettingsFile",SupportsShouldProcess = true)]
     [OutputType(typeof(ASRVaultSettings))]
     [Alias(

src/RecoveryServices/RecoveryServices.SiteRecovery/Vault/SetAzureRmRecoveryServicesAsrVaultContext.cs

@@ -26,7 +26,6 @@ namespace Microsoft.Azure.Commands.RecoveryServices.SiteRecovery
     /// <summary>
     ///     Sets the Recovery Services vault context to be used for subsequent Azure Site Recovery operations in the current PowerShell session.
     /// </summary>
-    [CmdletOutputBreakingChangeWithVersion(typeof(ASRVaultSettings), "12.0.0", "7.0.0", DeprecatedOutputProperties = new string[] { "ResouceType" }, NewOutputProperties = new string[] { "ResourceType" })]
     [Cmdlet("Set", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "RecoveryServicesAsrVaultContext", DefaultParameterSetName = ASRParameterSets.ARSVault, SupportsShouldProcess = true)]
     [Alias(
         "Set-ASRVaultContext",

src/RecoveryServices/RecoveryServices/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* [Breaking Change] Renamed the property `ResouceType` of `ASRVaultSettings` to `ResourceType`. 
 * Added support for MUA for disabling vault Immutability, increasing RPO for policy schedule, restore, stop protection with retain data.
 * Added support for Enabling/Disabling the azure monitor and email notification alerts for site recovery in recovery services vault.
 

tools/StaticAnalysis/Exceptions/Az.RecoveryServices/BreakingChangeIssues.csv

@@ -1,4 +1,7 @@
 "Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
 "Az.RecoveryServices","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.AddAzureRmRecoveryServicesAsrReplicationProtectedItemDisk","Add-AzRecoveryServicesAsrReplicationProtectedItemDisk","0","3010","The property 'RecoveryLBBackendAddressPoolIds' of type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails' has been removed.","Add the property 'RecoveryLBBackendAddressPoolIds' back to type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails'."
 "Az.RecoveryServices","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.AddAzureRmRecoveryServicesAsrReplicationProtectedItemDisk","Add-AzRecoveryServicesAsrReplicationProtectedItemDisk","0","3010","The property 'TfoLBBackendAddressPoolIds' of type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails' has been removed.","Add the property 'TfoLBBackendAddressPoolIds' back to type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails'."
-"Az.RecoveryServices","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.AddAzureRmRecoveryServicesAsrReplicationProtectedItemDisk","Add-AzRecoveryServicesAsrReplicationProtectedItemDisk","0","3010","The property 'IpAddressType' of type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails' has been removed.","Add the property 'IpAddressType' back to type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails'."
+"Az.RecoveryServices","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.AddAzureRmRecoveryServicesAsrReplicationProtectedItemDisk","Add-AzRecoveryServicesAsrReplicationProtectedItemDisk","0","3010","The property 'IpAddressType' of type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails' has been removed.","Add the property 'IpAddressType' back to type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.IPConfigDetails'."
+"Az.RecoveryServices","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrVaultSettings","Get-AzRecoveryServicesAsrVaultContext","0","3010","The property 'ResouceType' of type 'Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRVaultSettings' has been removed.","Add the property 'ResouceType' back to type 'Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRVaultSettings'."
+"Az.RecoveryServices","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ImportAzureRmRecoveryServicesAsrVaultSettingsFile","Import-AzRecoveryServicesAsrVaultSettingsFile","0","3010","The property 'ResouceType' of type 'Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRVaultSettings' has been removed.","Add the property 'ResouceType' back to type 'Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRVaultSettings'."
+"Az.RecoveryServices","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.SetAzureRmRecoveryServicesAsrVaultSettings","Set-AzRecoveryServicesAsrVaultContext","0","3010","The property 'ResouceType' of type 'Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRVaultSettings' has been removed.","Add the property 'ResouceType' back to type 'Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRVaultSettings'."