CI Error Fixes

Added default parameter set

Added PSPoolSpecificiation alias property for MaxTasksPerComputeNode

Author: paterasMSFT

src/Batch/Batch.Test/ScenarioTests/CertificateTests.ps1

@@ -65,5 +65,5 @@ function Test-TestCancelCertificateDelete
     $filter = "state eq 'active'";
     $cert = Get-AzBatchCertificate -Filter $filter -BatchContext $context
 
-    Assert-True { $cert.Thumbprint.ToLowerInvariant() -Contains $thumbprint }
+    Assert-ContainsItem $cert.Thumbprint.ToLowerInvariant() $thumbprint
 }

src/Batch/Batch/ComputeNodeExtensions/GetBatchComputeNodeExtensionCommand.cs

@@ -21,7 +21,7 @@
 
 namespace Microsoft.Azure.Commands.Batch
 {
-    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchComputeNodeExtension"), OutputType(typeof(PSNodeVMExtension))]
+    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchComputeNodeExtension", DefaultParameterSetName = Constants.IdParameterSet), OutputType(typeof(PSNodeVMExtension))]
     public class GetBatchComputeNodeExtensionCommand : BatchObjectModelCmdletBase
     {
         private int maxCount = Constants.DefaultMaxCount;

src/Batch/Batch/Models/PSPoolSpecification.cs

@@ -0,0 +1,43 @@
+// -----------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// -----------------------------------------------------------------------------
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by a tool.
+//     Runtime Version:5.0.13
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+namespace Microsoft.Azure.Commands.Batch.Models
+{    
+    public partial class PSPoolSpecification
+    {
+        /// <summary>
+        /// This property is an alias of TaskSlotsPerNode.
+        /// </summary>
+        public int? MaxTasksPerComputeNode
+        {
+            get
+            {
+                return TaskSlotsPerNode;
+            }
+            set
+            {
+                TaskSlotsPerNode = value;
+            }
+        }
+    }
+}

src/Batch/Batch/help/Get-AzBatchComputeNodeExtension.md

@@ -12,7 +12,7 @@ Gets Batch compute node extensions from a compute node.
 
 ## SYNTAX
 
-### Id
+### Id (Default)
 ```
 Get-AzBatchComputeNodeExtension [-PoolId] <String> [-ComputeNodeId] <String> [[-ExtensionName] <String>]
  [-Select <String>] [-MaxCount <Int32>] -BatchContext <BatchAccountContext>

tools/ScenarioTest.ResourceManager/Assert.ps1

@@ -215,6 +215,30 @@ function Assert-NotNull
   return $true
 }
 
+###################
+#
+# Verify that the given string is not null or empty
+#
+#    param [string] $actual  : The actual string
+#    param [string] $message : The message to return if the given script does not return true
+####################
+function Assert-NotNullOrEmpty
+{
+  param([string] $actual, [string] $message)
+
+  if (!$message)
+  {
+    $message = "Assertion failed because the string is null or empty: " + $actual
+  }
+
+  if ([string]::IsNullOrEmpty($actual))
+  {
+    throw $message
+  }
+
+  return $true
+}
+
 ######################
 #
 # Assert that the given file exists
@@ -390,7 +414,7 @@ function Assert-StartsWith
 {
     param([string] $expectedPrefix, [string] $actual, [string] $message)
 
-  Assert-NotNull $actual
+  Assert-NotNullOrEmpty $actual
 
   if (!$message)
   {
@@ -417,7 +441,7 @@ function Assert-Match
 {
     param([string] $regex, [string] $actual, [string] $message)
 
-  Assert-NotNull $actual
+  Assert-NotNullOrEmpty $actual
 
   if (!$message)
   {
@@ -444,7 +468,7 @@ function Assert-NotMatch
 {
     param([string] $regex, [string] $actual, [string] $message)
 
-  Assert-NotNull $actual
+  Assert-NotNullOrEmpty $actual
 
   if (!$message)
   {
@@ -456,5 +480,35 @@ function Assert-NotMatch
       throw $message
   }
 
+  return $true
+}
+
+###################
+#
+# Verify that the a space-delimited string contains an item matching a specific value.
+#
+#    param [string] $actual   : The actual string
+#    param [string] $expected : The expected value.
+#    param [string] $message  : The message to return if the actual string does not contain the expected value.
+####################
+function Assert-ContainsItem
+{
+    param([string] $actual, [string] $expected, [string] $message)
+
+  Assert-NotNullOrEmpty $actual
+  Assert-NotNullOrEmpty $expected
+
+  if (!$message)
+  {
+      $message = "Assertion failed because actual '$actual' does not contain an item matching '$expected'"
+  }
+
+  $split = $actual -Split ' '
+
+  if (!$split.contains($expected))
+  {
+      throw $message
+  }
+
   return $true
 }