[Network] DestinationPortBehavior in Get-AzNetworkWatcherConnectionMonitor is not getting information with powershell command (#20578)

* resolved the destinationportbehaviour issue

* Update the change log for fix [#15996]

* resolved the "DestinationPortBehavior" issue while create and update the CM

* removed the redundant line

* Update ChangeLog.md

Co-authored-by: Dingmeng Xue <[email protected]>

Author: v-sapanchal

src/Network/Network/ChangeLog.md

@@ -24,7 +24,8 @@
 * Updated mapping in `AzPublicIpAddress` to always show/create DdosSettings
 * Fixed a bug that added Ddos related properties when viewing PublicIpAddress and DdosProtectionPlan objects
 * Fixed a Bug for Set-AzIpGroup cmdlet to support the `-WhatIf` parameter
-* Fixed a Bug for `Add-AzLoadBalancerFrontendIpConfig`, `Add-AzLoadBalancerProbeConfig`, `Add-AzLoadBalancerBackendAddressPoolConfig`, `Set-AzLoadBalancer`, `New-AzLoadBalancerRuleConfig`, `Remove-AzLoadBalancerInboundNatRuleConfig` cmdlets to support the `-WhatIf` parameter. Fix [#20416]
+* Fixed a Bug for `Add-AzLoadBalancerFrontendIpConfig`, `Add-AzLoadBalancerProbeConfig`, `Add-AzLoadBalancerBackendAddressPoolConfig`, `Set-AzLoadBalancer`, `New-AzLoadBalancerRuleConfig`, `Remove-AzLoadBalancerInboundNatRuleConfig` cmdlets to support the `-WhatIf` parameter. [#20416]
+* Fixed a bug for DestinationPortBehavior in `Get-AzNetworkWatcherConnectionMonitor`, `New-AzNetworkWatcherConnectionMonitor` powershell command by adding this properties to get and set the DestinationPortBehavior information. [#15996]
 
 ## Version 5.2.0
 * Added optional parameters `CustomBlockResponseStatusCode` and `CustomBlockResponseBody` parameter to `AzApplicationGatewayFirewallPolicySettings`

src/Network/Network/NetworkWatcher/ConnectionMonitor/ConnectionMonitorBaseCmdlet.cs

@@ -195,7 +195,7 @@ public PSConnectionMonitorResultV2 MapConnectionMonitorResultToPSConnectionMonit
                                 Name = testConfiguration.Name,
                                 PreferredIPVersion = testConfiguration.PreferredIPVersion,
                                 TestFrequencySec = testConfiguration.TestFrequencySec,
-                                SuccessThreshold = testConfiguration.SuccessThreshold == null ? null : 
+                                SuccessThreshold = testConfiguration.SuccessThreshold == null ? null :
                                     new PSNetworkWatcherConnectionMonitorSuccessThreshold()
                                     {
                                         ChecksFailedPercent = testConfiguration.SuccessThreshold.ChecksFailedPercent,
@@ -271,8 +271,8 @@ public MNM.ConnectionMonitorEndpoint GetEndpoinByName(IList<ConnectionMonitorEnd
         }
 
         public ConnectionMonitor PopulateConnectionMonitorParametersFromV2Request(
-            PSNetworkWatcherConnectionMonitorTestGroupObject[] testGroups, 
-            PSNetworkWatcherConnectionMonitorOutputObject[] outputs, 
+            PSNetworkWatcherConnectionMonitorTestGroupObject[] testGroups,
+            PSNetworkWatcherConnectionMonitorOutputObject[] outputs,
             string notes)
         {
             ConnectionMonitor connectionMonitor = new ConnectionMonitor()
@@ -621,7 +621,8 @@ private void AddTestConfigurationsToConnectionMonitorTestGroup(
                     cmTestConfiguration.TcpConfiguration = new ConnectionMonitorTcpConfiguration()
                     {
                         Port = tcpConfiguration.Port,
-                        DisableTraceRoute = tcpConfiguration.DisableTraceRoute
+                        DisableTraceRoute = tcpConfiguration.DisableTraceRoute,
+                        DestinationPortBehavior = tcpConfiguration.DestinationPortBehavior,
                     };
                 }
                 else if (testConfiguration.ProtocolConfiguration is PSNetworkWatcherConnectionMonitorHttpConfiguration httpConfiguration)
@@ -667,13 +668,13 @@ private List<ConnectionMonitorOutput> GetOutputs(PSNetworkWatcherConnectionMonit
             {
                 cmOutputs.Add(
                     new ConnectionMonitorOutput()
+                    {
+                        Type = output.Type,
+                        WorkspaceSettings = new ConnectionMonitorWorkspaceSettings()
                         {
-                            Type = output.Type,
-                            WorkspaceSettings = new ConnectionMonitorWorkspaceSettings()
-                            {
-                                WorkspaceResourceId = output.WorkspaceSettings.WorkspaceResourceId
-                            },
-                        });
+                            WorkspaceResourceId = output.WorkspaceSettings.WorkspaceResourceId
+                        },
+                    });
             }
 
             return cmOutputs;
@@ -849,13 +850,13 @@ private void ValidateEndpointResourceId(PSNetworkWatcherConnectionMonitorEndpoin
             }
             else if (string.Equals(endpoint.Type, "AzureSubnet", StringComparison.OrdinalIgnoreCase))
             {
-                if (!resourceType.Equals("virtualNetworks", StringComparison.OrdinalIgnoreCase) || splittedName.Count() != 11 
+                if (!resourceType.Equals("virtualNetworks", StringComparison.OrdinalIgnoreCase) || splittedName.Count() != 11
                     || splittedName[9].Equals("subnet", StringComparison.OrdinalIgnoreCase))
                 {
                     throw new PSArgumentException(Properties.Resources.InvalidEndpointResourceIdForSpecifiedType, endpoint.Type);
                 }
             }
-            else if ((string.Equals(endpoint.Type, "MMAWorkspaceMachine", StringComparison.OrdinalIgnoreCase) || string.Equals(endpoint.Type, "MMAWorkspaceNetwork", StringComparison.OrdinalIgnoreCase)) 
+            else if ((string.Equals(endpoint.Type, "MMAWorkspaceMachine", StringComparison.OrdinalIgnoreCase) || string.Equals(endpoint.Type, "MMAWorkspaceNetwork", StringComparison.OrdinalIgnoreCase))
                 && !resourceType.Equals("workspaces", StringComparison.OrdinalIgnoreCase))
             {
                 throw new PSArgumentException(Properties.Resources.InvalidEndpointResourceIdForSpecifiedType, endpoint.Type);
@@ -866,7 +867,8 @@ private void ValidateEndpointResourceId(PSNetworkWatcherConnectionMonitorEndpoin
                 {
                     throw new PSArgumentException(Properties.Resources.InvalidEndpointResourceIdForSpecifiedType, endpoint.Type);
                 }
-            } else if (string.Equals(endpoint.Type, "AzureArcVM", StringComparison.OrdinalIgnoreCase))
+            }
+            else if (string.Equals(endpoint.Type, "AzureArcVM", StringComparison.OrdinalIgnoreCase))
             {
                 if (!resourceType.Equals("machines", StringComparison.OrdinalIgnoreCase))
                 {
@@ -882,7 +884,8 @@ private PSNetworkWatcherConnectionMonitorProtocolConfiguration GetPSProtocolConf
                 return new PSNetworkWatcherConnectionMonitorTcpConfiguration()
                 {
                     Port = testConfiguration.TcpConfiguration.Port,
-                    DisableTraceRoute = testConfiguration.TcpConfiguration.DisableTraceRoute
+                    DisableTraceRoute = testConfiguration.TcpConfiguration.DisableTraceRoute,
+                    DestinationPortBehavior = testConfiguration.TcpConfiguration.DestinationPortBehavior
                 };
             }
 
@@ -1000,10 +1003,10 @@ private List<HTTPHeader> GetRequestHeaders(PSNetworkWatcherConnectionMonitorHttp
             {
                 requestHeaders.Add(
                     new HTTPHeader()
-                        {
-                            Name = header.Name,
-                            Value = header.Value
-                        });
+                    {
+                        Name = header.Name,
+                        Value = header.Value
+                    });
             }
 
             return requestHeaders;