Update-AzDiskEncryptionSet bug fix (#25139)

* Autogen code

* changes

* fix code

* changelog and md file

---------

Co-authored-by: github-actions <[email protected]>

Author: grizzlytheodore

src/Compute/Compute/ChangeLog.md

@@ -20,6 +20,7 @@
 
 -->
 ## Upcoming Release
+* Added parameter `-IdentityType` to cmdlet `Update-AzDiskEncryptionSet`. 
 
 ## Version 8.0.0
 * Added new optional parameter `SecureVMGuestStateSAS` to cmdlet `Grant-AzDiskAccess`.

src/Compute/Compute/Generated/DiskEncryptionSet/Config/NewAzureRmDiskEncryptionSetConfigCommand.cs

@@ -51,8 +51,9 @@ public partial class NewAzureRmDiskEncryptionSetConfigCommand : Microsoft.Azure.
         [Parameter(
             Mandatory = false,
             Position = 2,
-            ValueFromPipelineByPropertyName = true)]
-        [PSArgumentCompleter("SystemAssigned")]
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The type of Managed Identity used by the DiskEncryptionSet. Only SystemAssigned is supported for new creations. Disk Encryption Sets can be updated with Identity type None during migration of subscription to a new Azure Active Directory tenant; it will cause the encrypted resources to lose access to the keys.")]
+        [PSArgumentCompleter("SystemAssigned", "UserAssigned", "SystemAssigned, UserAssigned")]
         public string IdentityType { get; set; }
 
         [Parameter(

src/Compute/Compute/Generated/DiskEncryptionSet/DiskEncryptionSetUpdateMethod.cs

@@ -153,6 +153,13 @@ public override void ExecuteCmdlet()
             HelpMessage = "The list of user identities associated with the disk encryption set. The user identity dictionary key references will be ARM resource ids in the form: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{identityName}'.")]
         public Hashtable UserAssignedIdentity { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The type of Managed Identity used by the DiskEncryptionSet. Only SystemAssigned is supported for new creations. Disk Encryption Sets can be updated with Identity type None during migration of subscription to a new Azure Active Directory tenant; it will cause the encrypted resources to lose access to the keys.")]
+        [PSArgumentCompleter("SystemAssigned", "UserAssigned", "SystemAssigned, UserAssigned")]
+        public string IdentityType { get; set; }
+
         private DiskEncryptionSetUpdate DiskEncryptionSetUpdate { get; set; }
 
         private void BuildPatchObject()
@@ -166,7 +173,6 @@ private void BuildPatchObject()
             {
                 if (this.DiskEncryptionSetUpdate.ActiveKey == null)
                 {
-                    //this.DiskEncryptionSetUpdate.ActiveKey = new KeyVaultAndKeyReference();
                     this.DiskEncryptionSetUpdate.ActiveKey = new KeyForDiskEncryptionSet();
                 }
                 this.DiskEncryptionSetUpdate.ActiveKey.KeyUrl = this.KeyUrl;
@@ -176,7 +182,6 @@ private void BuildPatchObject()
             {
                 if (this.DiskEncryptionSetUpdate.ActiveKey == null)
                 {
-                    //this.DiskEncryptionSetUpdate.ActiveKey = new KeyVaultAndKeyReference();
                     this.DiskEncryptionSetUpdate.ActiveKey = new KeyForDiskEncryptionSet();
                 }
                 if (this.DiskEncryptionSetUpdate.ActiveKey.SourceVault == null)
@@ -226,6 +231,15 @@ private void BuildPatchObject()
                     }
                 }
             }
+
+            if (this.IsParameterBound(c => c.IdentityType))
+            {
+                if (this.DiskEncryptionSetUpdate.Identity == null)
+                {
+                    this.DiskEncryptionSetUpdate.Identity = new EncryptionSetIdentity();
+                }
+                this.DiskEncryptionSetUpdate.Identity.Type = this.IdentityType;
+            }
         }
 
         private void BuildPutObject()
@@ -292,6 +306,16 @@ private void BuildPutObject()
                     }
                 }
             }
+
+            if (this.IsParameterBound(c => c.IdentityType))
+            {
+                if (this.InputObject.Identity == null)
+                {
+                    this.InputObject.Identity = new EncryptionSetIdentity();
+                }
+                this.InputObject.Identity.Type = this.IdentityType;
+            }
         }
     }
 }
+

src/Compute/Compute/Generated/Models/PSDiskEncryptionSet.cs

@@ -54,4 +54,4 @@ public string ResourceGroupName
         public string FederatedClientId { get; set; }
 
     }
-}
+}

src/Compute/Compute/help/Update-AzDiskEncryptionSet.md

@@ -16,24 +16,25 @@ Updates a disk encryption set.
 ```
 Update-AzDiskEncryptionSet [-ResourceGroupName] <String> [-Name] <String> [-KeyUrl <String>]
  [-SourceVaultId <String>] [-RotationToLatestKeyVersionEnabled <Boolean>] [[-Tag] <Hashtable>] [-AsJob]
- [-FederatedClientId <String>] [-UserAssignedIdentity <Hashtable>] [-DefaultProfile <IAzureContextContainer>]
- [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-FederatedClientId <String>] [-UserAssignedIdentity <Hashtable>] [-IdentityType <String>]
+ [-DefaultProfile <IAzureContextContainer>] [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm]
+ [<CommonParameters>]
 ```
 
 ### ResourceIdParameter
 ```
 Update-AzDiskEncryptionSet [-ResourceId] <String> [-KeyUrl <String>] [-SourceVaultId <String>]
  [-RotationToLatestKeyVersionEnabled <Boolean>] [[-Tag] <Hashtable>] [-AsJob] [-FederatedClientId <String>]
- [-UserAssignedIdentity <Hashtable>] [-DefaultProfile <IAzureContextContainer>]
- [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-UserAssignedIdentity <Hashtable>] [-IdentityType <String>] [-DefaultProfile <IAzureContextContainer>]
+ [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ### ObjectParameter
 ```
 Update-AzDiskEncryptionSet [-InputObject] <PSDiskEncryptionSet> [-KeyUrl <String>] [-SourceVaultId <String>]
  [-RotationToLatestKeyVersionEnabled <Boolean>] [[-Tag] <Hashtable>] [-AsJob] [-FederatedClientId <String>]
- [-UserAssignedIdentity <Hashtable>] [-DefaultProfile <IAzureContextContainer>]
- [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-UserAssignedIdentity <Hashtable>] [-IdentityType <String>] [-DefaultProfile <IAzureContextContainer>]
+ [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -95,6 +96,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -IdentityType
+The type of Managed Identity used by the DiskEncryptionSet. Only SystemAssigned is supported for new creations. Disk Encryption Sets can be updated with Identity type None during migration of subscription to a new Azure Active Directory tenant; it will cause the encrypted resources to lose access to the keys.
+
+```yaml
+Type: System.String
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: True (ByPropertyName)
+Accept wildcard characters: False
+```
+
 ### -InputObject
 The local object of the disk encryption set.