[Monitor]add parameter dimension for Get-AzMetric (#22478)

* add parameter dimension for Get-AzMetric

* make -metricfilter available for both parameter sets

Author: VeryEarly

src/Monitor/Monitor/ChangeLog.md

@@ -19,6 +19,7 @@
 -->
 
 ## Upcoming Release
+* Added parameter `Dimension` for `Get-AzMetric` to easily filter metrics by dimensions [#22320]
 
 ## Version 4.5.0
 * Added cmdlets for monitor workspace: 

src/Monitor/Monitor/Metrics/GetAzureRmMetricCommand.cs

@@ -22,6 +22,8 @@
 using Microsoft.Azure.Management.Monitor.Models;
 using Microsoft.Rest.Azure.OData;
 using System.Globalization;
+using Microsoft.WindowsAzure.Commands.Utilities.Common;
+using Microsoft.Azure.Commands.Common.Exceptions;
 
 namespace Microsoft.Azure.Commands.Insights.Metrics
 {
@@ -104,9 +106,15 @@ public class GetAzureRmMetricCommand : ManagementCmdletBase
         /// <summary>
         /// Gets or sets the metricfilter parameter of the cmdlet
         /// </summary>
-        [Parameter(ParameterSetName = GetAzureRmAMetricFullParamGroup, Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The metric dimension filter to query metrics for")]
+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The metric dimension filter to query metrics for")]
         public string MetricFilter { get; set; }
 
+        /// <summary>
+        /// Gets or sets the dimension parameter of the cmdlet
+        /// </summary>
+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The metric dimensions to query metrics for")]
+        public string[] Dimension { get; set; }
+
         /// <summary>
         /// Gets or sets the metricnames parameter of the cmdlet
         /// </summary>
@@ -133,6 +141,15 @@ protected override void ProcessRecordInternal()
                 message: "The DetailedOutput parameter will be deprecated in a future breaking change release.");
             bool fullDetails = this.DetailedOutput.IsPresent;
 
+            if (this.IsParameterBound(c => c.Dimension))
+            {
+                if (this.IsParameterBound(c => c.MetricFilter) && !string.IsNullOrEmpty(this.MetricFilter))
+                {
+                    throw new AzPSArgumentException("usage: -Dimension and -MetricFilter parameters are mutually exclusive.", "MetricFilter");
+                }
+                this.MetricFilter = string.Join(" and ", this.Dimension.Select(d => string.Format("{0} eq '*'", d)));
+            }
+
             // EndTime defaults to Now
             if (this.EndTime == default(DateTime))
             {

src/Monitor/Monitor/help/Get-AzMetric.md

@@ -16,15 +16,16 @@ Gets the metric values of a resource.
 ### GetWithDefaultParameters (Default)
 ```
 Get-AzMetric [-ResourceId] <String> [-TimeGrain <TimeSpan>] [-StartTime <DateTime>] [-EndTime <DateTime>]
- [[-MetricName] <String[]>] [-DetailedOutput] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+ [-MetricFilter <String>] [-Dimension <String[]>] [[-MetricName] <String[]>] [-DetailedOutput]
+ [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ### GetWithFullParameters
 ```
 Get-AzMetric [-ResourceId] <String> [-TimeGrain <TimeSpan>] [-AggregationType <AggregationType>]
  [-StartTime <DateTime>] [-EndTime <DateTime>] [-Top <Int32>] [-OrderBy <String>] [-MetricNamespace <String>]
- [-ResultType <ResultType>] [-MetricFilter <String>] [-MetricName] <String[]> [-DetailedOutput]
- [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+ [-ResultType <ResultType>] [-MetricFilter <String>] [-Dimension <String[]>] [-MetricName] <String[]>
+ [-DetailedOutput] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -254,6 +255,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -Dimension
+The metric dimensions to query metrics for
+
+```yaml
+Type: System.String[]
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: True (ByPropertyName)
+Accept wildcard characters: False
+```
+
 ### -EndTime
 Specifies the end time of the query in local time.
 The default is the current time.
@@ -275,7 +291,7 @@ Specifies the metric dimension filter to query metrics for.
 
 ```yaml
 Type: System.String
-Parameter Sets: GetWithFullParameters
+Parameter Sets: (All)
 Aliases:
 
 Required: False