-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Remove Sha256Checksum parameter of example of New-AzImageBuilderCustomizerObject #12203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…needs to remove Sha256Checksum parameter.
…hecksum parameter.
remove Sha256Checksum parameter of New-AzImageBuilderCustomizerObject.
|
Can one of the admins verify this patch? |
| # region Generated | ||
| # Load the private module dll | ||
| $null = Import-Module -PassThru -Name (Join-Path $PSScriptRoot '..\bin\Az.ImageBuilder.private.dll') | ||
| $null = Import-Module -PassThru -Name (Join-Path $PSScriptRoot '../bin/Az.ImageBuilder.private.dll') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file should be changed.
| @@ -1,5 +1,5 @@ | |||
| # Custom | |||
| This directory contains custom implementation for non-generated cmdlets for the `Az.ImageBuilder` module. Both scripts (`.ps1`) and C# files (`.cs`) can be implemented here. They will be used during the build process in `build-module.ps1`, and create cmdlets into the `..\exports` folder. The only generated file into this folder is the `Az.ImageBuilder.custom.psm1`. This file should not be modified. | |||
| This directory contains custom implementation for non-generated cmdlets for the `Az.ImageBuilder` module. Both scripts (`.ps1`) and C# files (`.cs`) can be implemented here. They will be used during the build process in `build-module.ps1`, and create cmdlets into the `../exports` folder. The only generated file into this folder is the `Az.ImageBuilder.custom.psm1`. This file should not be modified. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should not be changed.
| --- | ||
| Module Name: Az.ImageBuilder | ||
| Module Guid: bdedc683-d9b6-41ea-b310-d068b8c72305 | ||
| Module Guid: e90b2588-5031-43ea-81b5-9a419d2fec07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, the GUID is not nessary to be changed in this PR.
| @@ -1,5 +1,5 @@ | |||
| # Docs | |||
| This directory contains the documentation of the cmdlets for the `Az.ImageBuilder` module. To run documentation generation, use the `generate-help.ps1` script at the root module folder. Files in this folder will *always be overriden on regeneration*. To update documentation examples, please use the `..\examples` folder. | |||
| This directory contains the documentation of the cmdlets for the `Az.ImageBuilder` module. To run documentation generation, use the `generate-help.ps1` script at the root module folder. Files in this folder will *always be overriden on regeneration*. To update documentation examples, please use the `../examples` folder. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
his file should not be changed.
Remove Sha256Checksum parameter of example of New-AzImageBuilderCustomizerObject
|
I will open a new PR to fix this issue. @dingmeng-xue & @wyunchi-ms |
Description
Fix #12200