Skip to content

Conversation

@LucasYao93
Copy link
Contributor

@LucasYao93 LucasYao93 commented Jun 18, 2020

Description

Fix #12200

Lucas Yao (Wicresoft North America) and others added 4 commits June 18, 2020 11:29
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@LucasYao93 LucasYao93 changed the title Fix issue #12200 [ImageBuilder]Fix issue #12200 Jun 18, 2020
@dingmeng-xue dingmeng-xue changed the title [ImageBuilder]Fix issue #12200 Remove Sha256Checksum parameter of example of New-AzImageBuilderCustomizerObject Jun 18, 2020
@LucasYao93 LucasYao93 added this to the S172 (2020-07-14) milestone Jun 18, 2020
# region Generated
# Load the private module dll
$null = Import-Module -PassThru -Name (Join-Path $PSScriptRoot '..\bin\Az.ImageBuilder.private.dll')
$null = Import-Module -PassThru -Name (Join-Path $PSScriptRoot '../bin/Az.ImageBuilder.private.dll')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should be changed.

@@ -1,5 +1,5 @@
# Custom
This directory contains custom implementation for non-generated cmdlets for the `Az.ImageBuilder` module. Both scripts (`.ps1`) and C# files (`.cs`) can be implemented here. They will be used during the build process in `build-module.ps1`, and create cmdlets into the `..\exports` folder. The only generated file into this folder is the `Az.ImageBuilder.custom.psm1`. This file should not be modified.
This directory contains custom implementation for non-generated cmdlets for the `Az.ImageBuilder` module. Both scripts (`.ps1`) and C# files (`.cs`) can be implemented here. They will be used during the build process in `build-module.ps1`, and create cmdlets into the `../exports` folder. The only generated file into this folder is the `Az.ImageBuilder.custom.psm1`. This file should not be modified.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be changed.

---
Module Name: Az.ImageBuilder
Module Guid: bdedc683-d9b6-41ea-b310-d068b8c72305
Module Guid: e90b2588-5031-43ea-81b5-9a419d2fec07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be changed?

Copy link
Contributor

@wyunchi-ms wyunchi-ms Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, the GUID is not nessary to be changed in this PR.

@@ -1,5 +1,5 @@
# Docs
This directory contains the documentation of the cmdlets for the `Az.ImageBuilder` module. To run documentation generation, use the `generate-help.ps1` script at the root module folder. Files in this folder will *always be overriden on regeneration*. To update documentation examples, please use the `..\examples` folder.
This directory contains the documentation of the cmdlets for the `Az.ImageBuilder` module. To run documentation generation, use the `generate-help.ps1` script at the root module folder. Files in this folder will *always be overriden on regeneration*. To update documentation examples, please use the `../examples` folder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

his file should not be changed.

Lucas Yao (Wicresoft North America) and others added 2 commits June 22, 2020 14:12
Remove Sha256Checksum parameter of example of New-AzImageBuilderCustomizerObject
@LucasYao93
Copy link
Contributor Author

I will open a new PR to fix this issue. @dingmeng-xue & @wyunchi-ms

@LucasYao93 LucasYao93 closed this Jun 22, 2020
@LucasYao93 LucasYao93 deleted the lucas/generation branch June 22, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

example of New-AzImageBuilderCustomizerObject needs to remove Sha256Checksum parameter

5 participants