Skip to content

First release of Az.HanaOnAzure #12330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dolauli merged 4 commits into from
Jul 7, 2020
Merged

First release of Az.HanaOnAzure #12330

dolauli merged 4 commits into from
Jul 7, 2020

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Jul 6, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@adxsdkps
Copy link
Collaborator

adxsdkps commented Jul 6, 2020

Can one of the admins verify this patch?

@isra-fel isra-fel changed the title Az.HanaOnAzure First release of Az.HanaOnAzure Jul 6, 2020
@isra-fel isra-fel added this to the S172 (2020-07-14) milestone Jul 6, 2020
@isra-fel isra-fel marked this pull request as ready for review July 6, 2020 10:11
dolauli
dolauli reviewed Jul 6, 2020
View reviewed changes
src/HanaOnAzure/custom/New-AzSapMonitorProviderInstance.ps1 Outdated
Creates a provider instance for the specified subscription, resource group, SapMonitor name, and resource name.
.Description
Creates a provider instance for the specified subscription, resource group, SapMonitor name, and resource name.
.Example
Copy link
Contributor

@dolauli dolauli Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Example is not required.

Copy link
Member Author

@isra-fel isra-fel Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks

dolauli
dolauli approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dolauli dolauli merged commit 869e64d into Azure:generation Jul 7, 2020
@isra-fel isra-fel deleted the hanaonazure branch September 19, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolauli dolauli dolauli approved these changes

Assignees

@dolauli dolauli

Labels

needs-review

Projects

None yet

Milestone

S172 (2020-07-14)

Development

Successfully merging this pull request may close these issues.

3 participants

@isra-fel @adxsdkps @dolauli