Skip to content

Conversation

@chenlei-yang
Copy link
Contributor

@chenlei-yang chenlei-yang commented Jul 8, 2020

Description

For #12356
Because of the wrong compare script in the link above, we need to avoid the minor bump when the version of Az.Accounts is 1.9.x.
So we add a special judge for it when the version is 1.9.x and the expect bump type is minor, we will change the type to patch so that it can work until 1.9.9. Once the version is greater or equal than 2.0.0, this special judge will not works anymore.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue self-requested a review July 8, 2020 09:58
@wyunchi-ms wyunchi-ms merged commit b1203db into Azure:release-2020-07-14 Jul 8, 2020
litchiyangMSFT pushed a commit to litchiyangMSFT/azure-powershell that referenced this pull request Aug 4, 2020
* Add a special judge for Az.Accounts when bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants