Skip to content

Add a special judge for Az.Accounts when bump version #12357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyunchi-ms merged 4 commits into from
Jul 8, 2020
Merged

Add a special judge for Az.Accounts when bump version #12357

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e04c0ae
Add a special judge for Az.Accounts when bump version
chenlei-yang Jul 8, 2020
28e38ad
Fix the comment
chenlei-yang Jul 8, 2020
6a70582
Add comments.
chenlei-yang Jul 8, 2020
af3a37e
remove the wrong comment
chenlei-yang Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tools/VersionController/Models/VersionBumper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,15 @@ private string GetBumpedVersion()
{
versionBump = Version.MINOR;
}
// for https://github.com/Azure/azure-powershell/pull/12356
// Because of the wrong compare script in the link above, we need to avoid the minor bump when the version of Az.Accounts is 1.9.x
// So we add a special judge for it when the version is 1.9.x and the expect bump type is minor,
// we will change the type to patch so that it can work until 1.9.9.Once the version is greater or equal than 2.0.0
// this special judge will not works anymore.
if (splitVersion[0] == 1 && splitVersion[1] == 9 && versionBump == Version.MINOR)
{
versionBump = Version.PATCH;
}
}

// PATCH update for preview modules (0.x.x or x.x.x-preview)
Expand Down