Skip to content

Conversation

@wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Sep 7, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms wyunchi-ms added this to the S175 (2020-09-22) Ignite milestone Sep 7, 2020
@wyunchi-ms wyunchi-ms changed the base branch from master to Az.Aks-preview September 7, 2020 09:19
@wyunchi-ms wyunchi-ms linked an issue Sep 8, 2020 that may be closed by this pull request
[PSArgumentCompleter("AvailabilitySet", "VirtualMachineScaleSets")]
public string VmSetType { get; set; }

[Parameter(Mandatory = false, HelpMessage = "Represents types of an node pool. Possible values include: 'VirtualMachineScaleSets', 'AvailabilitySet'")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update help message

@erich-wang erich-wang merged commit f8b8501 into Az.Aks-preview Sep 9, 2020
@wyunchi-ms wyunchi-ms deleted the aks/windowsvhd branch September 16, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AKS] [Preview] Support new Windows VHD image

4 participants