Skip to content

Onboard Migrate to Private Link Common Cmdlets #13403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isra-fel merged 2 commits into from
Nov 10, 2020
Merged

Onboard Migrate to Private Link Common Cmdlets #13403

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb91165
Onboard Migrate to Private Link Common Cmdlets
abhiroop-goyal-ms Nov 3, 2020
be5e048
PR Comments #1
abhiroop-goyal-ms Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Migrate/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Onboard Migrate to Private Link Common Cmdlets
Copy link
Member

@isra-fel isra-fel Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate module does not change a thing, so change log should not be updated. Please remove this.

Copy link
Contributor Author

@abhiroop-goyal abhiroop-goyal Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the changelog


## Version 0.1.0
* First preview release for module Az.Migrate
Expand Down
1 change: 1 addition & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
--->

## Upcoming Release
* Onboard Migrate to Private Link Common Cmdlets
Copy link
Member

@isra-fel isra-fel Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our practice is not to update Network's changelog for private link support, so please remove this.

Copy link
Contributor Author

@abhiroop-goyal abhiroop-goyal Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the changelog


## Version 4.1.0
* [Breaking Change] Removed parameter `HostedSubnet` and added `Subnet` instead
Expand Down
3 changes: 3 additions & 0 deletions src/Network/Network/PrivateLinkService/PrivateLinkServiceProvider/ProviderConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ static ProviderConfiguration()
RegisterConfiguration("Microsoft.EventGrid/domains", "2020-04-01-preview");
RegisterConfiguration("Microsoft.Network/applicationgateways", "2020-05-01");
RegisterConfiguration("Microsoft.SignalRService/signalr", "2020-05-01", false);
RegisterConfiguration("Microsoft.Migrate/assessmentProjects", "2020-05-01-preview", false);
RegisterConfiguration("Microsoft.Migrate/migrateProjects", "2020-06-01-preview", false);
RegisterConfiguration("Microsoft.OffAzure/masterSites", "2020-07-07", false);
}

private static void RegisterConfiguration(string type, string apiVersion, bool hasConnectionsURI = true)
Expand Down