[KeyVault] Redesign HSM cmdlets #13599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
msJinLei
suggested changes
Dec 1, 2020
| if (existingResource == null) | ||
| { | ||
| throw new Exception(string.Format("A managed HSM with name '{0}' in resource group '{1}' does not exist. Please use New-AzManagedHsm to create a managed HSM with these properties.", this.Name, this.ResourceGroupName)); | ||
| throw new Exception(string.Format("A managed HSM with name '{0}' in resource group '{1}' does not exist. Please use New-AzKeyVaultManagedHsm to create a managed HSM with these properties.", this.Name, this.ResourceGroupName)); |
Contributor
There was a problem hiding this comment.
It better to use resource string
| } | ||
| } | ||
|
|
||
| private void NormalizeParameterSets() |
Contributor
There was a problem hiding this comment.
You can put NormalizeParameterSets into base class
Member
Author
There was a problem hiding this comment.
I wish I could, but the logic of this method is slightly different in every cmdlet.
For example, some cmdlets have -ResourceId and some don't, some even have -HsmResourceId as well.
I'm afarid we won't get much benifit to write it in base class.
msJinLei
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to our discussion with KeyVault team, here's the summary of the changes:
(I organized code changes in different commits. I suggest review them one by one.)
New-AzManagedHsmNew-AzKeyVaultManagedHsmAdd-AzKeyVaultKeyandAdd-AzManagedHsmKeyAdd-AzKeyVaultKeyGet-AzManagedHsmRoleDefinitionGet-AzKeyVaultRoleDefinitionBackup-AzManagedHsmBackup-AzKeyVaultBackup-AzManagedHsmSecurityDomainandRestore-AzManagedHsmSecurityDomainExport-AzKeyVaultSecurityDomainandImport-AzKeyVaultSecurityDomainChecklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added