Skip to content

Conversation

ankursood23
Copy link
Contributor

@ankursood23 ankursood23 commented Oct 10, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@ankursood23 ankursood23 requested a review from Copilot October 11, 2025 00:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the RouteTableUsageMode parameter to Azure Network Manager routing configuration cmdlets, allowing users to specify whether the configuration should use managed-only or existing route tables.

  • Added RouteTableUsageMode parameter to both New-AzNetworkManagerRoutingConfiguration and Set-AzNetworkManagerRoutingConfiguration cmdlets
  • Updated the PowerShell model to include the new property with table view support
  • Enhanced test coverage to validate the new parameter functionality across all cmdlet scenarios

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SetAzNetworkManagerRoutingConfigurationCommand.cs Added RouteTableUsageMode parameter with validation and conditional update logic
NewAzNetworkManagerRoutingConfigurationCommand.cs Added RouteTableUsageMode parameter with default value assignment and validation
PSNetworkManagerRoutingConfiguration.cs Added RouteTableUsageMode property with table view formatting
ChangeLog.md Added changelog entry documenting the new parameter
NetworkManagerTests.ps1 Comprehensive test coverage for all RouteTableUsageMode scenarios

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@ankursood23 ankursood23 requested a review from Copilot October 12, 2025 19:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

…uration/NewAzNetworkManagerRoutingConfigurationCommand.cs

Co-authored-by: Copilot <[email protected]>
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@ankursood23 ankursood23 requested a review from Copilot October 12, 2025 19:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

…uration/NewAzNetworkManagerRoutingConfigurationCommand.cs

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants