-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Added support for DPP vault soft delete feature #29064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for the DPP (Data Protection Platform) vault soft delete feature by upgrading the API version from 2025-02-01 to 2025-09-01 and introducing three new cmdlets for managing soft-deleted backup vaults.
Changes:
- Upgraded API version from 2025-02-01 to 2025-09-01 across all DataProtection cmdlets
- Added three new cmdlets:
Get-AzDataProtectionSoftDeletedBackupVault,Undo-AzDataProtectionVaultDeletion, andSearch-AzDataProtectionSoftDeletedVaultBackupInstanceInAzGraph - Updated help documentation, examples, and test files for the new functionality
- Modified existing tests to reflect soft delete behavior changes
Reviewed changes
Copilot reviewed 157 out of 168 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Az.DataProtection.psd1 | Updated module metadata, Az.Accounts dependency, and exported functions list |
| ChangeLog.md | Missing entry for the upcoming release documenting vault soft delete feature |
| Help/*.md | Updated API version references from 2025-02-01 to 2025-09-01 in output types |
| Undo-AzDataProtectionVaultDeletion.md | New comprehensive help documentation for vault undeletion cmdlet |
| Get-AzDataProtectionSoftDeletedBackupVault.md | New help documentation for retrieving soft-deleted vaults |
| Search-AzDataProtectionSoftDeletedVaultBackupInstanceInAzGraph.md | New help for searching soft-deleted backup instances |
| Test files | Added new test files and updated existing tests for soft delete scenarios |
| Examples/*.md | Added example documentation for new cmdlets |
| DataProtection.sln | Updated project GUID reference |
| utils.ps1 | Updated test environment configuration with new subscription IDs and resource details |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vidai-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add test cases for Get-AzDataProtectionSoftDeletedBackupVault and Search-AzDataProtectionSoftDeletedVaultBackupInstanceInAzGraph?
| ## OUTPUTS | ||
| ### Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api20250201.IClientDiscoveryValueForSingleApi | ||
| ### Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api50.IOperation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Api50 correct? Would that cause breaking change since the output types are different?
Description
Added support for DPP vault soft delete feature
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.