Added support for custom Azure Environments #29067
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom Azure Environments that customers might have configured using Add-AzEnvironment. The changes enable Stack HCI registration to work with non-standard Azure cloud environments beyond the built-in ones (Azure Public Cloud, China Cloud, US Government Cloud, German Cloud, etc.).
Changes:
- Added fallback logic to query custom Azure Environments using
Get-AzEnvironmentwhen the environment name doesn't match built-in clouds - Updated four helper functions to retrieve environment-specific endpoints from custom Azure Environments
- Added a default billing service API scope constant for custom environments
- Updated ChangeLog.md with the new capability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/StackHCI/StackHCI/ChangeLog.md | Added changelog entry describing custom Azure Environment support |
| src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1 | Added custom environment support to Get-ManagementUrl, Get-PortalDomain, Get-EnvironmentEndpoints functions and registerArcScript; defined default billing API scope constant |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29067 in repo Azure/azure-powershell |
|
@isra-fel , I am all good to merge this PR from my side. Let me know if you have any questions. If not, please go ahead and merge this. |
vidai-msft
left a comment
vidai-msft
left a comment
There was a problem hiding this comment.
Get-AzEnvironment -Name $EnvironmentName is called multiple times. The result can be saved into a local variable to avoid overhead.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3 participants
Description
This PR adds changes for supporting custom Azure Environments that customers might have added using Add-AzEnvironment
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.