Azure
diff --git a/‎custom-words.txt
Lines changed: 22 additions & 2 deletions b/‎custom-words.txt
Lines changed: 22 additions & 2 deletions
diff --git a/‎documentation/Semantic-and-Model-Violations-Reference.md
Lines changed: 1 addition & 1 deletion b/‎documentation/Semantic-and-Model-Violations-Reference.md
Lines changed: 1 addition & 1 deletion
diff --git a/‎documentation/ci-fix.md
Lines changed: 15 additions & 1 deletion b/‎documentation/ci-fix.md
Lines changed: 15 additions & 1 deletion
diff --git a/‎documentation/typespec-rest-api-dev-process.md
Lines changed: 1 addition & 1 deletion b/‎documentation/typespec-rest-api-dev-process.md
Lines changed: 1 addition & 1 deletion
diff --git a/‎eng/tools/typespec-validation/src/rules/folder-structure.ts
Lines changed: 3 additions & 6 deletions b/‎eng/tools/typespec-validation/src/rules/folder-structure.ts
Lines changed: 3 additions & 6 deletions
diff --git a/‎eng/tools/typespec-validation/src/utils.ts
Lines changed: 7 additions & 3 deletions b/‎eng/tools/typespec-validation/src/utils.ts
Lines changed: 7 additions & 3 deletions
diff --git a/‎eng/tools/typespec-validation/test/folder-structure.test.ts
Lines changed: 50 additions & 0 deletions b/‎eng/tools/typespec-validation/test/folder-structure.test.ts
Lines changed: 50 additions & 0 deletions
diff --git a/‎eng/tools/typespec-validation/test/npm-prefix.test.ts
Lines changed: 68 additions & 0 deletions b/‎eng/tools/typespec-validation/test/npm-prefix.test.ts
Lines changed: 68 additions & 0 deletions
diff --git a/‎eng/tools/typespec-validation/test/tsv-test-host.ts
Lines changed: 10 additions & 1 deletion b/‎eng/tools/typespec-validation/test/tsv-test-host.ts
Lines changed: 10 additions & 1 deletion
diff --git a/‎eng/tools/typespec-validation/test/util.test.ts
Lines changed: 16 additions & 11 deletions b/‎eng/tools/typespec-validation/test/util.test.ts
Lines changed: 16 additions & 11 deletions
@@ -56,6 +56,7 @@ adla
 adlarge
 adls
 adlsgen
+adma
 adminmanagement
 adou
 adsis
@@ -181,6 +182,7 @@ appfigures
 appid
 appinsights
 applynetworkconfigurationupdates
+approveRollingUpgrade
 appservice
 appsettings
 appsource
@@ -570,6 +572,7 @@ Contoso's
 contosodataset
 contosomedia
 contributer
+CONV
 convolutional
 cooldown
 copyid
@@ -710,6 +713,10 @@ deallocated
 deallocates
 deallocating
 deallocation
+decompilation
+decompile
+decompiled
+decompiles
 deboards
 Deboard
 deboard
@@ -1102,6 +1109,7 @@ getdevices
 getent
 getfilestatus
 getikesas
+getitems
 getissuers
 getjob
 getkey
@@ -2673,6 +2681,7 @@ speechservicesmanagement
 speechtotext
 spiffe
 splitallcsvs
+springboot
 spreadsheetml
 springbootsites
 springbootapps
@@ -3905,13 +3914,24 @@ usedCPUMHz
 totalCPUMHz
 docon
 DialOut
+texttospeech
+customvoice
+trainingset
+trainingsets
+modelrecipes
+personalvoice
+personalvoices
+basemodels
+Multistyle
 vectorizers
 ONTAP
 SVM
-SVM's
 Vectorizable
 vectorizers
 Entra
+scheduledevents
+zones
+acknowledge
 virtualendpoints
 switchover
 SwitchOver
@@ -3925,4 +3945,4 @@ capacityreservationgroup
 capacityreservationgroups
 ciam
 CIAM
-msvideo
+msvideo
@@ -850,7 +850,7 @@ This document lists the set of automated rules that can be validated against swa
 
 **Output Message**: Long running operation should return {header} in header but not being provided.
 
-**Description**: Long running operation must return location header or azure-AsyncOperation header in response when this operation is annotated with x-ms-long-running-operation:true.
+**Description**: Long running operation must return `Operation-Id`, `Operation-Location`, or `azure-AsyncOperation` header in response when this operation is annotated with x-ms-long-running-operation:true.
 
 **How to fix the violation**: Adding one of these headers to the response in example or in traffic payload. Refer to this [example](https://github.com/Azure/azure-rest-api-specs/blob/5e638554b6/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2020-07-01/examples/Apps_Update.json#L64) for the fix.
 
 
@@ -114,7 +114,7 @@ Please see [readme](https://github.com/Azure/openapi-diff/blob/main/README.md) f
 Or you can run it in [OpenAPI Hub](https://portal.azure-devex-tools.com/tools/diff).
 Refer to [Oad Docs](https://github.com/Azure/openapi-diff/tree/main/docs) for detailed description of all oad rules.
 
-## LintDiff Validation
+## Swagger LintDiff
 
 The [LintDiff validation tool](https://github.com/Azure/azure-openapi-validator) runs linting rules against specification difference. Two specifications are compared: the specification as it would be when proposed PR is merged, vs the specification as seen before the PR is merged.
 
@@ -123,6 +123,20 @@ If that guidance is not enough, please also refer to the [LintDiff rules.md doc]
 
 To reproduce LintDiff failures locally, see [CONTRIBUTING.md / How to locally reproduce a LintDiff failure occurring on a PR](https://github.com/Azure/azure-openapi-validator/blob/main/CONTRIBUTING.md#how-to-locally-reproduce-a-lintdiff-failure-occurring-on-a-pr).
 
+## Swagger LintDiff for TypeSpec
+
+### `Record<unkown>` causes `AvoidAdditionalProperties` and `PropertiesTypeObjectNoDefinition`
+
+The use of `Record<unkown>` in TypeSpec is discouraged, and there is a TypeSpec lint rule to enforce this.  If you still need to use `Record<unknown>`, the swagger generated will cause many LintDiff errors of types `AvoidAdditionalProperties` and `PropertiesTypeObjectNoDefinition`.  You will need to suppress both the TypeSpec violation (in TypeSpec source code) and the LintDiff violations (in `readme.md`).
+
+### `RequestBodyMustExistForPutPatch`
+
+We believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/641.  Until fixed, spec authors should **not** suppress the violations in `readme.md`, but rather have label `Approved-LintDiff` applied to their PR to ignore the errors.
+
+### `PatchPropertiesCorrespondToPutProperties`
+
+We believe this is a false positive: https://github.com/Azure/azure-openapi-validator/issues/642.  Until fixed, spec authors should **not** suppress the violations in `readme.md`, but rather have label `Approved-LintDiff` applied to their PR to ignore the errors.
+
 ## Avocado
 
 ### Get help fixing Avocado validation failures
 
@@ -20,7 +20,7 @@ If you are developing within your own ADO repo first and then submitting into `a
 
 #### 2.1 With local machine development
 
-- [Node.js LTS](https://nodejs.org/en) version 16 or above. Ensure you can run the npm command in a command prompt:
+- [Node.js LTS](https://nodejs.org/en) version 18 or above (LTS Recommended). Ensure you can run the npm command in a command prompt:
 ```
   npm --version
 ```
 
@@ -31,8 +31,8 @@ export class FolderStructureRule implements Rule {
       }
     });
 
-    // Verify top level folder is lower case
-    let folderStruct = relativePath.split("/");
+    // Verify top level folder is lower case and remove empty entries when splitting by slash
+    let folderStruct = relativePath.split("/").filter(Boolean);
     if (folderStruct[1].match(/[A-Z]/g)) {
       success = false;
       errorOutput += `Invalid folder name. Folders under specification/ must be lower case.\n`;
@@ -47,10 +47,7 @@ export class FolderStructureRule implements Rule {
     }
 
     // Verify second level folder is capitalized after each '.'
-    if (
-      /(^|\. *)([a-z])/g.test(packageFolder) &&
-      !["data-plane", "resource-manager"].includes(packageFolder)
-    ) {
+    if (/(^|\. *)([a-z])/g.test(packageFolder)) {
       success = false;
       errorOutput += `Invalid folder name. Folders under specification/${folderStruct[1]} must be capitalized after each '.'\n`;
     }
 
@@ -1,6 +1,6 @@
 import { access } from "fs/promises";
 import { exec } from "child_process";
-import path from "path";
+import defaultPath, { PlatformPath } from "path";
 
 export async function runCmd(cmd: string, cwd: string) {
   console.log(`run command:${cmd}`);
@@ -22,6 +22,10 @@ export async function checkFileExists(file: string) {
     .catch(() => false);
 }
 
-export function normalizePath(folder: string) {
-  return path.resolve(folder).split(path.sep).join("/");
+export function normalizePath(folder: string, path: PlatformPath = defaultPath) {
+  return path
+    .resolve(folder)
+    .split(path.sep)
+    .join("/")
+    .replace(/^([a-z]):/, (_match, driveLetter) => driveLetter.toUpperCase() + ":");
 }
@@ -28,6 +28,22 @@ describe("folder-structure", function () {
     assert(result.errorOutput.includes("must be lower case"));
   });
 
+  it("should succeed if package folder has trailing slash", async function () {
+    let host = new TsvTestHost();
+    host.globby = async () => {
+      return ["/foo/bar/tspconfig.yaml"];
+    };
+    host.normalizePath = () => {
+      return "/gitroot";
+    };
+
+    const result = await new FolderStructureRule().execute(
+      host,
+      "/gitroot/specification/foo/Foo/Foo/",
+    );
+    assert(result.success);
+  });
+
   it("should fail if package folder is more than 3 levels deep", async function () {
     let host = new TsvTestHost();
     host.globby = async () => {
@@ -62,6 +78,40 @@ describe("folder-structure", function () {
     assert(result.errorOutput.includes("must be capitalized"));
   });
 
+  it("should fail if second level folder is data-plane", async function () {
+    let host = new TsvTestHost();
+    host.globby = async () => {
+      return ["/foo/bar/tspconfig.yaml"];
+    };
+    host.normalizePath = () => {
+      return "/gitroot";
+    };
+
+    const result = await new FolderStructureRule().execute(
+      host,
+      "/gitroot/specification/foo/data-plane",
+    );
+    assert(result.errorOutput);
+    assert(result.errorOutput.includes("must be capitalized"));
+  });
+
+  it("should fail if second level folder is resource-manager", async function () {
+    let host = new TsvTestHost();
+    host.globby = async () => {
+      return ["/foo/bar/tspconfig.yaml"];
+    };
+    host.normalizePath = () => {
+      return "/gitroot";
+    };
+
+    const result = await new FolderStructureRule().execute(
+      host,
+      "/gitroot/specification/foo/resource-manager",
+    );
+    assert(result.errorOutput);
+    assert(result.errorOutput.includes("must be capitalized"));
+  });
+
   it("should fail if Shared does not follow Management ", async function () {
     let host = new TsvTestHost();
     host.globby = async () => {
 
@@ -0,0 +1,68 @@
+import { NpmPrefixRule } from "../src/rules/npm-prefix.js";
+import { IGitOperation, TsvTestHost } from "./tsv-test-host.js";
+import { strict as assert } from "node:assert";
+import path from "path";
+
+describe("npm-prefix", function () {
+  it("should succeed if node returns inconsistent drive letter capitalization", async function () {
+    let host = new TsvTestHost(path.win32);
+    host.runCmd = async (cmd: string, _cwd: string): Promise<[Error | null, string, string]> => {
+      if (cmd.includes("npm prefix")) {
+        return [null, `C:${path.sep}Git${path.sep}azure-rest-api-specs`, ""];
+      } else {
+        return [null, "", ""];
+      }
+    };
+    host.gitOperation = (_folder: string): IGitOperation => {
+      return {
+        status: () => {
+          return Promise.resolve({
+            modified: [],
+            isClean: () => true,
+          });
+        },
+        diff: () => {
+          return Promise.resolve("");
+        },
+        revparse: () => {
+          return Promise.resolve("c:/Git/azure-rest-api-specs");
+        },
+      };
+    };
+
+    const result = await new NpmPrefixRule().execute(host, TsvTestHost.folder);
+
+    assert(result.success);
+  });
+
+  it("should fail if npm prefix mismatch", async function () {
+    let host = new TsvTestHost();
+    host.runCmd = async (cmd: string, _cwd: string): Promise<[Error | null, string, string]> => {
+      if (cmd.includes("npm prefix")) {
+        return [null, "/Git/azure-rest-api-specs/specification/foo", ""];
+      } else {
+        return [null, "", ""];
+      }
+    };
+    host.gitOperation = (_folder: string): IGitOperation => {
+      return {
+        status: () => {
+          return Promise.resolve({
+            modified: [],
+            isClean: () => true,
+          });
+        },
+        diff: () => {
+          return Promise.resolve("");
+        },
+        revparse: () => {
+          return Promise.resolve("/Git/azure-rest-api-specs");
+        },
+      };
+    };
+
+    const result = await new NpmPrefixRule().execute(host, TsvTestHost.folder);
+
+    assert(!result.success);
+  });
+});
@@ -1,7 +1,16 @@
 import { IGitOperation, TsvHost } from "../src/tsv-host.js";
 import { normalizePath } from "../src/utils.js";
+import defaultPath, { PlatformPath } from "path";
+
+export { IGitOperation } from "../src/tsv-host.js";
 
 export class TsvTestHost implements TsvHost {
+  path: PlatformPath;
+
+  constructor(path: PlatformPath = defaultPath) {
+    this.path = path;
+  }
+
   static get folder() {
     return "specification/foo/Foo";
   }
@@ -36,7 +45,7 @@ export class TsvTestHost implements TsvHost {
   }
 
   normalizePath(folder: string): string {
-    return normalizePath(folder);
+    return normalizePath(folder, this.path);
   }
 
   async readTspConfig(_folder: string): Promise<string> {
 
@@ -1,24 +1,29 @@
-import { TsvTestHost } from "./tsv-test-host.js";
+import { normalizePath } from "../src/utils.js";
 import { strict as assert } from "node:assert";
 import process from "process";
+import path from "path";
 
 describe("normalize", function () {
   it("should succeed if normalized . and normalized cwd matches", async function () {
-    let host = new TsvTestHost();
-    const dotResult = host.normalizePath(".");
-    const cwdResult = host.normalizePath(process.cwd());
+    const dotResult = normalizePath(".");
+    const cwdResult = normalizePath(process.cwd());
     assert(dotResult === cwdResult);
   });
 
   it("should succeed if /foo/bar/ is normalized", async function () {
-    let host = new TsvTestHost();
-    const result = host.normalizePath("/foo/bar/").replace(/^[a-zA-Z]:/g, "");
-    assert(result === "/foo/bar");
+    const result = normalizePath("/foo/bar/", path.posix);
+    assert.equal(result, "/foo/bar");
   });
 
-  it("should succeed if /foo/bar is normalized", async function () {
-    let host = new TsvTestHost();
-    const result = host.normalizePath("/foo/bar").replace(/^[a-zA-Z]:/g, "");
-    assert(result === "/foo/bar");
+  it("should normalize windows drive letter", async function () {
+    const lowerResult = normalizePath("c:\\foo\\bar", path.win32);
+    const upperResult = normalizePath("C:\\foo\\bar", path.win32);
+    assert.equal(lowerResult, upperResult);
+  });
+
+  it("should distinguish different windows drive letters", async function () {
+    const lowerResult = normalizePath("c:\\foo\\bar", path.win32);
+    const upperResult = normalizePath("d:\\foo\\bar", path.win32);
+    assert.notEqual(lowerResult, upperResult);
   });
 });