Skip to content

Commit 27489e4

Browse files
chinadragon0515Vincent He
chinadragon0515
and
Vincent He
authored
Remove never used properties (#22423)
Co-authored-by: Vincent He <[email protected]>
1 parent 23e82ab commit 27489e4

File tree

6 files changed

+10
-142
lines changed

6 files changed

+10
-142
lines changed

‎specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json

Lines changed: 2 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,31 +1041,6 @@
10411041
}
10421042
},
10431043
"definitions": {
1044-
"ManagedEnvironmentOutboundSettings": {
1045-
"type": "object",
1046-
"description": "Configuration used to control the Environment Egress outbound traffic",
1047-
"properties": {
1048-
"outBoundType": {
1049-
"$ref": "#/definitions/ManagedEnvironmentOutBoundType"
1050-
},
1051-
"virtualNetworkApplianceIp": {
1052-
"description": "Virtual Appliance IP used as the Egress controller for the Environment",
1053-
"type": "string"
1054-
}
1055-
}
1056-
},
1057-
"ManagedEnvironmentOutBoundType": {
1058-
"enum": [
1059-
"LoadBalancer",
1060-
"UserDefinedRouting"
1061-
],
1062-
"description": "Outbound type for the cluster",
1063-
"type": "string",
1064-
"x-ms-enum": {
1065-
"name": "ManagedEnvironmentOutBoundType",
1066-
"modelAsString": true
1067-
}
1068-
},
10691044
"AppLogsConfiguration": {
10701045
"description": "Configuration of application logs",
10711046
"type": "object",
@@ -1108,23 +1083,15 @@
11081083
"properties": {
11091084
"internal": {
11101085
"type": "boolean",
1111-
"description": "Boolean indicating the environment only has an internal load balancer. These environments do not have a public static IP resource. They must provide runtimeSubnetId and infrastructureSubnetId if enabling this property",
1086+
"description": "Boolean indicating the environment only has an internal load balancer. These environments do not have a public static IP resource. They must provide infrastructureSubnetId if enabling this property",
11121087
"x-ms-mutability": [
11131088
"create",
11141089
"read"
11151090
]
11161091
},
11171092
"infrastructureSubnetId": {
11181093
"type": "string",
1119-
"description": "Resource ID of a subnet for infrastructure components. This subnet must be in the same VNET as the subnet defined in runtimeSubnetId. Must not overlap with any other provided IP ranges.",
1120-
"x-ms-mutability": [
1121-
"create",
1122-
"read"
1123-
]
1124-
},
1125-
"runtimeSubnetId": {
1126-
"type": "string",
1127-
"description": "This field is deprecated and not used. If you wish to provide your own subnet that Container App containers are injected into, then you should leverage the infrastructureSubnetId.",
1094+
"description": "Resource ID of a subnet for infrastructure components. Must not overlap with any other provided IP ranges.",
11281095
"x-ms-mutability": [
11291096
"create",
11301097
"read"
@@ -1153,10 +1120,6 @@
11531120
"create",
11541121
"read"
11551122
]
1156-
},
1157-
"outboundSettings": {
1158-
"$ref": "#/definitions/ManagedEnvironmentOutboundSettings",
1159-
"description": "Configuration used to control the Environment Egress outbound traffic"
11601123
}
11611124
}
11621125
},
@@ -1169,10 +1132,6 @@
11691132
}
11701133
],
11711134
"properties": {
1172-
"sku": {
1173-
"$ref": "#/definitions/EnvironmentSkuProperties",
1174-
"description": "SKU properties of the Environment."
1175-
},
11761135
"kind": {
11771136
"type": "string",
11781137
"description": "Kind of the Environment."
@@ -1370,40 +1329,6 @@
13701329
"maximumCount"
13711330
]
13721331
},
1373-
"EnvironmentSkuProperties": {
1374-
"description": "Managed Environment resource SKU properties.",
1375-
"type": "object",
1376-
"properties": {
1377-
"name": {
1378-
"type": "string",
1379-
"description": "Name of the Sku.",
1380-
"externalDocs": {
1381-
"url": "https://aka.ms/container-apps-pricing"
1382-
},
1383-
"enum": [
1384-
"Consumption",
1385-
"Premium"
1386-
],
1387-
"x-ms-enum": {
1388-
"name": "SkuName",
1389-
"modelAsString": true,
1390-
"values": [
1391-
{
1392-
"value": "Consumption",
1393-
"description": "Consumption SKU of Managed Environment."
1394-
},
1395-
{
1396-
"value": "Premium",
1397-
"description": "Premium SKU of Managed Environment."
1398-
}
1399-
]
1400-
}
1401-
}
1402-
},
1403-
"required": [
1404-
"name"
1405-
]
1406-
},
14071332
"workloadProfileStates": {
14081333
"description": "Collection of all the workload Profile States for a Premium Managed Environment..",
14091334
"type": "object",

‎specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_CreateOrUpdate.json

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
"api-version": "2022-11-01-preview",
77
"environmentEnvelope": {
88
"location": "East US",
9-
"sku": {
10-
"name": "Premium"
11-
},
129
"properties": {
1310
"daprAIConnectionString": "InstrumentationKey=00000000-0000-0000-0000-000000000000;IngestionEndpoint=https://northcentralus-0.in.applicationinsights.azure.com/",
1411
"appLogsConfiguration": {
@@ -19,10 +16,7 @@
1916
},
2017
"zoneRedundant": true,
2118
"vnetConfiguration": {
22-
"outboundSettings": {
23-
"outBoundType": "UserDefinedRouting",
24-
"virtualNetworkApplianceIp": "192.168.1.20"
25-
}
19+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
2620
},
2721
"customDomainConfiguration": {
2822
"dnsSuffix": "www.my-name.com",
@@ -56,9 +50,6 @@
5650
"name": "testcontainerenv",
5751
"type": "Microsoft.App/managedEnvironments",
5852
"location": "East US",
59-
"sku": {
60-
"name": "Premium"
61-
},
6253
"properties": {
6354
"provisioningState": "Succeeded",
6455
"deploymentErrors": null,
@@ -71,10 +62,7 @@
7162
},
7263
"zoneRedundant": true,
7364
"vnetConfiguration": {
74-
"outboundSettings": {
75-
"outBoundType": "UserDefinedRouting",
76-
"virtualNetworkApplianceIp": "192.168.1.20"
77-
}
65+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
7866
},
7967
"customDomainConfiguration": {
8068
"customDomainVerificationId": "custom domain verification id",
@@ -110,9 +98,6 @@
11098
"name": "testcontainerenv",
11199
"type": "Microsoft.App/managedEnvironments",
112100
"location": "East US",
113-
"sku": {
114-
"name": "Premium"
115-
},
116101
"properties": {
117102
"provisioningState": "InitializationInProgress",
118103
"deploymentErrors": null,
@@ -125,10 +110,7 @@
125110
},
126111
"zoneRedundant": true,
127112
"vnetConfiguration": {
128-
"outboundSettings": {
129-
"outBoundType": "UserDefinedRouting",
130-
"virtualNetworkApplianceIp": "192.168.1.20"
131-
}
113+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
132114
},
133115
"customDomainConfiguration": {
134116
"customDomainVerificationId": "custom domain verification id",

‎specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_Get.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,14 @@
1313
"type": "Microsoft.App/managedEnvironments",
1414
"location": "North Central US",
1515
"tags": {},
16-
"sku": {
17-
"name": "Premium"
18-
},
1916
"properties": {
2017
"provisioningState": "Succeeded",
2118
"deploymentErrors": null,
2219
"defaultDomain": "jlaw-demo1.k4apps.io",
2320
"staticIp": "20.42.33.145",
2421
"zoneRedundant": true,
2522
"vnetConfiguration": {
26-
"outboundSettings": {
27-
"outBoundType": "UserDefinedRouting",
28-
"virtualNetworkApplianceIp": "192.168.1.20"
29-
}
23+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
3024
},
3125
"customDomainConfiguration": {
3226
"customDomainVerificationId": "custom domain verification id",

‎specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_ListByResourceGroup.json

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
"type": "Microsoft.App/managedEnvironments",
1515
"location": "North Central US",
1616
"tags": {},
17-
"sku": {
18-
"name": "Premium"
19-
},
2017
"properties": {
2118
"provisioningState": "Succeeded",
2219
"deploymentErrors": null,
@@ -25,10 +22,7 @@
2522
"appLogsConfiguration": null,
2623
"zoneRedundant": true,
2724
"vnetConfiguration": {
28-
"outboundSettings": {
29-
"outBoundType": "UserDefinedRouting",
30-
"virtualNetworkApplianceIp": "192.168.1.20"
31-
}
25+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
3226
},
3327
"customDomainConfiguration": {
3428
"customDomainVerificationId": "custom domain verification id",
@@ -63,9 +57,6 @@
6357
"type": "Microsoft.App/managedEnvironments",
6458
"location": "North Central US",
6559
"tags": {},
66-
"sku": {
67-
"name": "Consumption"
68-
},
6960
"properties": {
7061
"provisioningState": "Succeeded",
7162
"deploymentErrors": null,
@@ -82,10 +73,7 @@
8273
},
8374
"eventStreamEndpoint": "testEndpoint",
8475
"vnetConfiguration": {
85-
"outboundSettings": {
86-
"outBoundType": "UserDefinedRouting",
87-
"virtualNetworkApplianceIp": "192.168.1.20"
88-
}
76+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
8977
}
9078
}
9179
}

‎specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_ListBySubscription.json

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313
"type": "Microsoft.App/managedEnvironments",
1414
"location": "North Central US",
1515
"tags": {},
16-
"sku": {
17-
"name": "Premium"
18-
},
1916
"properties": {
2017
"provisioningState": "Succeeded",
2118
"deploymentErrors": null,
@@ -24,10 +21,7 @@
2421
"appLogsConfiguration": null,
2522
"zoneRedundant": true,
2623
"vnetConfiguration": {
27-
"outboundSettings": {
28-
"outBoundType": "UserDefinedRouting",
29-
"virtualNetworkApplianceIp": "192.168.1.20"
30-
}
24+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
3125
},
3226
"customDomainConfiguration": {
3327
"customDomainVerificationId": "custom domain verification id",
@@ -62,9 +56,6 @@
6256
"type": "Microsoft.App/managedEnvironments",
6357
"location": "North Central US",
6458
"tags": {},
65-
"sku": {
66-
"name": "Consumption"
67-
},
6859
"properties": {
6960
"provisioningState": "Succeeded",
7061
"deploymentErrors": null,
@@ -73,10 +64,7 @@
7364
"appLogsConfiguration": null,
7465
"zoneRedundant": true,
7566
"vnetConfiguration": {
76-
"outboundSettings": {
77-
"outBoundType": "UserDefinedRouting",
78-
"virtualNetworkApplianceIp": "192.168.1.20"
79-
}
67+
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
8068
},
8169
"customDomainConfiguration": {
8270
"customDomainVerificationId": "custom domain verification id",

‎specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_Patch.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,12 @@
2020
"type": "Microsoft.App/managedEnvironments",
2121
"location": "North Central US",
2222
"tags": {},
23-
"sku": {
24-
"name": "Premium"
25-
},
2623
"properties": {
2724
"provisioningState": "Succeeded",
2825
"deploymentErrors": null,
2926
"defaultDomain": "jlaw-demo1.k4apps.io",
3027
"staticIp": "20.42.33.145",
3128
"zoneRedundant": true,
32-
"vnetConfiguration": {
33-
"outboundSettings": {
34-
"outBoundType": "UserDefinedRouting",
35-
"virtualNetworkApplianceIp": "192.168.1.20"
36-
}
37-
},
3829
"customDomainConfiguration": {
3930
"customDomainVerificationId": "custom domain verification id",
4031
"dnsSuffix": "www.my-name.com",

0 commit comments

Comments
 (0)