Skip to content

Commit 406c7b7

Browse files
authored
Purview add "x-ms-secret" attribute to ListKeys response (#15700)
* Purview add "x-ms-secret" attribute to ListKeys response Purview add "x-ms-secret" attribute to ListKeys response * move supressions to top level readme * Add suppressions to top level readme.md Add suppressions to top level readme.md for easier discovery * fix indentation of readme.md
1 parent ebbb4a9 commit 406c7b7

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

specification/purview/resource-manager/Microsoft.Purview/stable/2021-07-01/purview.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1424,10 +1424,12 @@
14241424
"type": "object",
14251425
"properties": {
14261426
"atlasKafkaPrimaryEndpoint": {
1427+
"x-ms-secret": true,
14271428
"description": "Gets or sets the primary connection string.",
14281429
"type": "string"
14291430
},
14301431
"atlasKafkaSecondaryEndpoint": {
1432+
"x-ms-secret": true,
14311433
"description": "Gets or sets the secondary connection string.",
14321434
"type": "string"
14331435
}

specification/purview/resource-manager/readme.go.md

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,6 @@ go:
88
namespace: purview
99
clear-output-folder: true
1010
```
11-
## Suppression
12-
13-
``` yaml
14-
directive:
15-
- suppress: R3018 # EnumInsteadOfBoolean
16-
where:
17-
- $.definitions.CheckNameAvailabilityResult.properties.nameAvailable
18-
- $.definitions.DimensionProperties.properties.toBeExportedForCustomer
19-
reason:
20-
- Check name model is set by ARM team https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/proxy-api-reference.md#check-name-availability-requests
21-
```
2211
2312
### Go multi-api
2413

specification/purview/resource-manager/readme.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,20 @@ See configuration in [readme.python.md](./readme.python.md)
8787
## Go
8888

8989
See configuration in [readme.go.md](./readme.go.md)
90+
91+
## Suppression
92+
93+
``` yaml
94+
directive:
95+
- suppress: SECRET_PROPERTY
96+
where:
97+
- $.definitions.AccessKeys.properties.atlasKafkaPrimaryEndpoint
98+
- $.definitions.AccessKeys.properties.atlasKafkaSecondaryEndpoint
99+
reason: Secrets are OK to return in a POST response.
100+
- suppress: R3018 # EnumInsteadOfBoolean
101+
where:
102+
- $.definitions.CheckNameAvailabilityResult.properties.nameAvailable
103+
- $.definitions.DimensionProperties.properties.toBeExportedForCustomer
104+
reason:
105+
- Check name model is set by ARM team https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/proxy-api-reference.md#check-name-availability-requests
106+
```

0 commit comments

Comments
 (0)