[BreakingChanges] Always set required outputs head_sha and issue_number (#36607)

Author: mikeharder

.github/workflows/src/breaking-change-add-label-artifacts.js

@@ -15,6 +15,10 @@ export const CROSS_VERSION_BREAKING_CHANGE_WORKFLOW_NAME =
  */
 export default async function getLabelActions({ github, context, core }) {
   const { owner, repo, head_sha, issue_number } = await extractInputs(github, context, core);
+
+  core.setOutput("head_sha", head_sha);
+  core.setOutput("issue_number", issue_number);
+
   const workflowRuns = await github.paginate(github.rest.actions.listWorkflowRunsForRepo, {
     owner,
     repo,
@@ -74,9 +78,6 @@ export default async function getLabelActions({ github, context, core }) {
     })
   ).map((a) => a.name);
 
-  core.setOutput("head_sha", head_sha);
-  core.setOutput("issue_number", issue_number);
-
   if (
     breakingChangesArtifactNames.length === 0 &&
     crossVersionBreakingChangesArtifactNames.length === 0

.github/workflows/test/breaking-change-add-label-artifacts.test.js

@@ -73,9 +73,14 @@ describe("breaking-change-add-label-artifacts", () => {
     createMockWorkflowRun(CROSS_VERSION_BREAKING_CHANGE_WORKFLOW_NAME, "completed", "success", 2),
   ];
 
-  const expectStandardOutputs = (breakingChangeValue, versioningValue) => {
+  const expectRequiredOutputs = () => {
     expect(mockCore.setOutput).toHaveBeenCalledWith("head_sha", mockInputs.head_sha);
     expect(mockCore.setOutput).toHaveBeenCalledWith("issue_number", mockInputs.issue_number);
+  };
+
+  const expectStandardOutputs = (breakingChangeValue, versioningValue) => {
+    expectRequiredOutputs();
+
     expect(mockCore.setOutput).toHaveBeenCalledWith(
       "breakingChangeReviewLabelName",
       REVIEW_REQUIRED_LABELS.BREAKING_CHANGE,
@@ -92,9 +97,13 @@ describe("breaking-change-add-label-artifacts", () => {
   };
 
   const expectEarlyReturn = (infoMessage) => {
+    expectRequiredOutputs();
+
+    // Ensure setOutput was *only* called with the two required outputs
+    expect(mockCore.setOutput).toHaveBeenCalledTimes(2);
+
     expect(mockCore.info).toHaveBeenCalledWith(infoMessage);
     expect(mockGithub.rest.actions.listWorkflowRunArtifacts).not.toHaveBeenCalled();
-    expect(mockCore.setOutput).not.toHaveBeenCalled();
   };
 
   describe("successful execution with both workflows completed", () => {