Skip to content

Commit 4cf6f80

Browse files
authored
Flipped .net required settings to false (#36465)
1 parent de5e378 commit 4cf6f80

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

eng/tools/spec-gen-sdk-runner/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export const SpecGenSdkRequiredSettings: Record<SdkName, PlaneTypeSettings> = {
9393
},
9494
"azure-sdk-for-net": {
9595
dataPlane: false,
96-
managementPlane: true,
96+
managementPlane: false,
9797
},
9898
"azure-sdk-for-python": {
9999
dataPlane: true,

eng/tools/spec-gen-sdk-runner/test/command-helpers.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,8 @@ describe("commands.ts", () => {
604604
expect(result).toBe(true);
605605

606606
const result2 = getRequiredSettingValue(true, true, "azure-sdk-for-net");
607-
// When hasTypeSpecProjects is true, .NET SDK follows normal rules (managementPlane: true)
608-
expect(result2).toBe(true);
607+
// .NET SDK set (managementPlane: false)
608+
expect(result2).toBe(false);
609609
});
610610

611611
test("should return dataPlane setting when hasManagementPlaneSpecs is false", () => {
@@ -616,6 +616,10 @@ describe("commands.ts", () => {
616616
const result2 = getRequiredSettingValue(false, true, "azure-sdk-for-js");
617617
// Based on the constants in types.ts, JS SDK does not require check for data plane
618618
expect(result2).toBe(false);
619+
620+
const result3 = getRequiredSettingValue(false, true, "azure-sdk-for-net");
621+
// .NET SDK set (dataplane: false)
622+
expect(result3).toBe(false);
619623
});
620624

621625
test("should return false for azure-sdk-for-net when hasTypeSpecProjects is false", () => {

0 commit comments

Comments
 (0)