Check issue_number in status script (#36427)

* Check issue_number in status script

* Throw error when issue_number is invalid

* Update .github/workflows/src/set-status.js

Co-authored-by: Mike Harder <[email protected]>

---------

Co-authored-by: Mike Harder <[email protected]>

Author: raych1

.github/workflows/src/set-status.js

@@ -71,6 +71,10 @@ export async function setStatusImpl({
   requiredStatusName,
   overridingLabel,
 }) {
+  if (!Number.isInteger(issue_number) || issue_number <= 0) {
+    throw new Error(`issue_number must be a positive integer: ${issue_number}`);
+  }
+
   core.setOutput("issue_number", issue_number);
 
   // TODO: Try to extract labels from context (when available) to avoid unnecessary API call

.github/workflows/test/set-status.test.js

@@ -19,6 +19,93 @@ describe("setStatusImpl", () => {
     await expect(setStatusImpl({})).rejects.toThrow();
   });
 
+  it("throws when issue_number is null", async () => {
+    await expect(
+      setStatusImpl({
+        owner: "test-owner",
+        repo: "test-repo",
+        head_sha: "test-head-sha",
+        // @ts-expect-error - Testing invalid input
+        issue_number: null,
+        target_url: "https://test.com/set_status_url",
+        github,
+        core,
+        monitoredWorkflowName: "test-workflow",
+        requiredStatusName: "test-status",
+        overridingLabel: "test-label",
+      }),
+    ).rejects.toThrow("issue_number must be a positive integer");
+  });
+
+  it("throws when issue_number is undefined", async () => {
+    await expect(
+      setStatusImpl({
+        owner: "test-owner",
+        repo: "test-repo",
+        head_sha: "test-head-sha",
+        // @ts-expect-error - Testing invalid input
+        issue_number: undefined,
+        target_url: "https://test.com/set_status_url",
+        github,
+        core,
+        monitoredWorkflowName: "test-workflow",
+        requiredStatusName: "test-status",
+        overridingLabel: "test-label",
+      }),
+    ).rejects.toThrow("issue_number must be a positive integer");
+  });
+
+  it("throws when issue_number is NaN", async () => {
+    await expect(
+      setStatusImpl({
+        owner: "test-owner",
+        repo: "test-repo",
+        head_sha: "test-head-sha",
+        issue_number: NaN,
+        target_url: "https://test.com/set_status_url",
+        github,
+        core,
+        monitoredWorkflowName: "test-workflow",
+        requiredStatusName: "test-status",
+        overridingLabel: "test-label",
+      }),
+    ).rejects.toThrow("issue_number must be a positive integer");
+  });
+
+  it("throws when issue_number is zero", async () => {
+    await expect(
+      setStatusImpl({
+        owner: "test-owner",
+        repo: "test-repo",
+        head_sha: "test-head-sha",
+        issue_number: 0,
+        target_url: "https://test.com/set_status_url",
+        github,
+        core,
+        monitoredWorkflowName: "test-workflow",
+        requiredStatusName: "test-status",
+        overridingLabel: "test-label",
+      }),
+    ).rejects.toThrow("issue_number must be a positive integer");
+  });
+
+  it("throws when issue_number is negative", async () => {
+    await expect(
+      setStatusImpl({
+        owner: "test-owner",
+        repo: "test-repo",
+        head_sha: "test-head-sha",
+        issue_number: -1,
+        target_url: "https://test.com/set_status_url",
+        github,
+        core,
+        monitoredWorkflowName: "test-workflow",
+        requiredStatusName: "test-status",
+        overridingLabel: "test-label",
+      }),
+    ).rejects.toThrow("issue_number must be a positive integer");
+  });
+
   it("sets success if approved by label", async () => {
     github.rest.issues.listLabelsOnIssue.mockResolvedValue({
       data: [{ name: "test" }, { name: "Approved-Avocado" }],