Mark dictionaries as readonly for new csharp emitter (#36490)

* Mark dictionaries as readonly

* more

* more

Author: JoshLove-msft

specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.AVS/AVS.tsp

@@ -51,6 +51,7 @@ model AvsScriptExecutionStartedEventData extends AvsScriptExecutionEventData {}
 #suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "Maintain compatibility with existing models."
 model AvsScriptExecutionFinishedEventData extends AvsScriptExecutionEventData {
   /** Named outputs of completed execution, if any. */
+  @visibility(Lifecycle.Read)
   namedOutputs: Record<string>;
 }
 

specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp

@@ -183,6 +183,7 @@ model AcsChatThreadPropertiesUpdatedPerUserEventData
   editTime: utcDateTime;
 
   /** The thread metadata */
+  @visibility(Lifecycle.Read)
   metadata?: Record<string>;
 
   /** The updated thread properties */
@@ -644,15 +645,19 @@ model AcsRouterWorkerOfferAcceptedEventData extends AcsRouterWorkerEventData {
   jobPriority?: int32;
 
   /** Router Worker Offer Accepted Worker Labels */
+  @visibility(Lifecycle.Read)
   workerLabels: Record<string>;
 
   /** Router Worker Offer Accepted Worker Tags */
+  @visibility(Lifecycle.Read)
   workerTags: Record<string>;
 
   /** Router Worker Offer Accepted Job Labels */
+  @visibility(Lifecycle.Read)
   jobLabels: Record<string>;
 
   /** Router Worker Offer Accepted Job Tags */
+  @visibility(Lifecycle.Read)
   jobTags: Record<string>;
 }
 
@@ -692,6 +697,7 @@ model AcsRouterWorkerOfferIssuedEventData extends AcsRouterWorkerEventData {
   jobPriority?: int32;
 
   /** Router Worker Offer Issued Worker Labels */
+  @visibility(Lifecycle.Read)
   workerLabels: Record<string>;
 
   /** Router Worker Offer Issued Time in UTC */
@@ -705,12 +711,15 @@ model AcsRouterWorkerOfferIssuedEventData extends AcsRouterWorkerEventData {
   expiresOn: utcDateTime;
 
   /** Router Worker Offer Issued Worker Tags */
+  @visibility(Lifecycle.Read)
   workerTags: Record<string>;
 
   /** Router Worker Offer Issued Job Labels */
+  @visibility(Lifecycle.Read)
   jobLabels: Record<string>;
 
   /** Router Worker Offer Issued Job Tags */
+  @visibility(Lifecycle.Read)
   jobTags: Record<string>;
 }
 
@@ -743,9 +752,11 @@ model AcsRouterWorkerRegisteredEventData {
   totalCapacity?: int32;
 
   /** Router Worker Registered Labels */
+  @visibility(Lifecycle.Read)
   labels: Record<string>;
 
   /** Router Worker Registered Tags */
+  @visibility(Lifecycle.Read)
   tags: Record<string>;
 }
 
@@ -757,9 +768,11 @@ model AcsRouterJobEventData extends AcsRouterEventData {
   queueId?: string;
 
   /** Router Job events Labels */
+  @visibility(Lifecycle.Read)
   labels: Record<string>;
 
   /** Router Jobs events Tags */
+  @visibility(Lifecycle.Read)
   tags: Record<string>;
 }
 
@@ -804,6 +817,7 @@ model AcsRouterQueueDetails {
   name?: string;
 
   /** Router Queue Labels */
+  @visibility(Lifecycle.Read)
   labels: Record<string>;
 }
 
@@ -856,6 +870,7 @@ alias AcsChatMessageBaseEventData = {
   messageBody: string;
 
   /** The chat message metadata */
+  @visibility(Lifecycle.Read)
   metadata?: Record<string>;
 };
 
@@ -868,6 +883,7 @@ alias AcsChatThreadBaseEventData = {
   properties: Record<unknown>;
 
   /** The thread metadata */
+  @visibility(Lifecycle.Read)
   metadata?: Record<string>;
 
   /** The list of properties of participants who are part of the thread */
@@ -897,6 +913,7 @@ alias AcsChatThreadPropertiesBaseEventData = {
   properties: Record<unknown>;
 
   /** The thread metadata */
+  @visibility(Lifecycle.Read)
   metadata: Record<string>;
 };
 
@@ -1204,6 +1221,7 @@ model AcsChatThreadParticipantProperties {
   participantCommunicationIdentifier: CommunicationIdentifierModel;
 
   /** The metadata of the user */
+  @visibility(Lifecycle.Read)
   metadata?: Record<string>;
 }
 
@@ -1265,9 +1283,11 @@ model AcsRecordingChunkInfoProperties {
 /** Custom Context of Incoming Call */
 model AcsIncomingCallCustomContext {
   /** Sip Headers for incoming call */
+  @visibility(Lifecycle.Read)
   sipHeaders: Record<string>;
 
   /** Voip Headers for incoming call */
+  @visibility(Lifecycle.Read)
   voipHeaders: Record<string>;
 }
 
@@ -1376,9 +1396,11 @@ model AcsRouterWorkerUpdatedEventData {
   totalCapacity?: int32;
 
   /** Router Worker Updated Labels */
+  @visibility(Lifecycle.Read)
   labels: Record<string>;
 
   /** Router Worker Updated Tags */
+  @visibility(Lifecycle.Read)
   tags: Record<string>;
 
   /** Router Worker Properties Updated */

specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.Devices/IotHub.tsp

@@ -97,9 +97,11 @@ model DeviceTelemetryEventProperties {
   body: Record<unknown>;
 
   /** Application properties are user-defined strings that can be added to the message. These fields are optional. */
+  @visibility(Lifecycle.Read)
   properties: Record<string>;
 
   /** System properties help identify contents and source of the messages. */
+  @visibility(Lifecycle.Read)
   systemProperties: Record<string>;
 }
 

specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.EventGrid/EventGrid.tsp

@@ -100,14 +100,15 @@ model EventGridMQTTClientCreatedOrUpdatedEventData
   createdOn: utcDateTime;
 
   /** 
-Time the client resource is last updated based on the provider's UTC time. If
-the client resource was never updated, this value is identical to the value of
-the 'createdOn' property.
-*/
+  Time the client resource is last updated based on the provider's UTC time. If
+  the client resource was never updated, this value is identical to the value of
+  the 'createdOn' property.
+  */
   @madeRequired(ServiceApiVersions.v2024_01_01)
   updatedOn: utcDateTime;
 
   /** The key-value attributes that are assigned to the client resource. */
+  @visibility(Lifecycle.Read)
   attributes: Record<string>;
 }
 

specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.ResourceNotifications/common.tsp

@@ -24,10 +24,12 @@ model ResourceNotificationsResourceUpdatedDetails {
   location?: string;
 
   /** the tags on the resource for which the event is being emitted */
+  @visibility(Lifecycle.Read)
   tags?: Record<string>;
 
   /** properties in the payload of the resource for which the event is being emitted */
   #suppress "@azure-tools/typespec-azure-core/bad-record-type" "The type of properties is object with additionalProperties object"
+  @visibility(Lifecycle.Read)
   properties?: Record<unknown>;
 }
 

specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.Resources/Resources.tsp

@@ -69,6 +69,7 @@ namespace Microsoft.EventGrid.SystemEvents {
     action?: string;
 
     /** The evidence for the authorization. */
+    @visibility(Lifecycle.Read)
     evidence: Record<string>;
   }
 
@@ -98,6 +99,7 @@ namespace Microsoft.EventGrid.SystemEvents {
     authorization: ResourceAuthorization;
 
     /** The properties of the claims. */
+    @visibility(Lifecycle.Read)
     claims: Record<string>;
 
     /** An operation ID used for troubleshooting. */