Try moving extra parameters. Change Parameters back to unknown

trangevi · trangevi · commit 7b1e6e1bd99f · 2024-08-13T13:45:49.000-07:00
Signed-off-by: Travis Angevine &lt;trangevi@microsoft.com&gt;
diff --git a/specification/ai/ModelClient/models/chat_completions.tsp b/specification/ai/ModelClient/models/chat_completions.tsp
@@ -120,6 +120,8 @@ model ChatCompletionsOptions {
     """)
   `model`?: string;
 
+  ...AdditionalRequestHeaders;
+
   ...Record<unknown>;
 }
 
@@ -462,7 +464,7 @@ model FunctionDefinition {
 
   #suppress "@azure-tools/typespec-azure-core/bad-record-type"
   @doc("The parameters the function accepts, described as a JSON Schema object.")
-  parameters?: Record<unknown>;
+  parameters?: unknown;
 }
 
 @doc("""
diff --git a/specification/ai/ModelClient/routes.tsp b/specification/ai/ModelClient/routes.tsp
@@ -45,8 +45,6 @@ op getChatCompletions is Azure.Core.RpcOperation<
 op getChatCompletions is Azure.Core.RpcOperation<
   {
     chatCompletionsOptions: ChatCompletionsOptions,
-    @header("extra-parameters")
-    extraParams?: ExtraParameters,
   },
   ChatCompletions
 >;

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,8 @@ model ChatCompletionsOptions {`
`120`	`120`	`""")`
`121`	`121`	`model`?: string;
`122`	`122`
	`123`	`+ ...AdditionalRequestHeaders;`
	`124`	`+`
`123`	`125`	`...Record<unknown>;`
`124`	`126`	`}`
`125`	`127`
`@@ -462,7 +464,7 @@ model FunctionDefinition {`
`462`	`464`
`463`	`465`	`#suppress "@azure-tools/typespec-azure-core/bad-record-type"`
`464`	`466`	`@doc("The parameters the function accepts, described as a JSON Schema object.")`
`465`		`- parameters?: Record<unknown>;`
	`467`	`+ parameters?: unknown;`
`466`	`468`	`}`
`467`	`469`
`468`	`470`	`@doc("""`
Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,6 @@ op getChatCompletions is Azure.Core.RpcOperation<`
`45`	`45`	`op getChatCompletions is Azure.Core.RpcOperation<`
`46`	`46`	`{`
`47`	`47`	`chatCompletionsOptions: ChatCompletionsOptions,`
`48`		`- @header("extra-parameters")`
`49`		`- extraParams?: ExtraParameters,`
`50`	`48`	`},`
`51`	`49`	`ChatCompletions`
`52`	`50`	`>;`