Skip to content

Commit 7c840ca

Browse files
authored
SDK client library review feedback (#20482)
1 parent b2fac42 commit 7c840ca

8 files changed

+20
-36
lines changed

specification/deviceupdate/data-plane/Microsoft.DeviceUpdate/stable/2022-10-01/deviceupdate.json

Lines changed: 16 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,6 @@
184184
"$ref": "#/definitions/Update"
185185
}
186186
},
187-
"304": {
188-
"description": "Not modified."
189-
},
190187
"default": {
191188
"description": "Default response.",
192189
"schema": {
@@ -467,9 +464,6 @@
467464
"$ref": "#/definitions/UpdateFile"
468465
}
469466
},
470-
"304": {
471-
"description": "Not modified."
472-
},
473467
"default": {
474468
"description": "Default response.",
475469
"schema": {
@@ -484,11 +478,11 @@
484478
"tags": [
485479
"Update management"
486480
],
487-
"operationId": "DeviceUpdate_ListOperations",
481+
"operationId": "DeviceUpdate_ListOperationStatuses",
488482
"description": "Get a list of all import update operations. Completed operations are kept for 7 days before auto-deleted. Delete operations are not returned by this API version.",
489483
"x-ms-examples": {
490-
"DeviceUpdate_ListOperations": {
491-
"$ref": "./examples/DeviceUpdate_ListOperations.json"
484+
"DeviceUpdate_ListOperationStatuses": {
485+
"$ref": "./examples/DeviceUpdate_ListOperationStatuses.json"
492486
}
493487
},
494488
"parameters": [
@@ -539,11 +533,11 @@
539533
"tags": [
540534
"Update management"
541535
],
542-
"operationId": "DeviceUpdate_GetOperation",
536+
"operationId": "DeviceUpdate_GetOperationStatus",
543537
"description": "Retrieve operation status.",
544538
"x-ms-examples": {
545-
"DeviceUpdate_GetOperation": {
546-
"$ref": "./examples/DeviceUpdate_GetOperation.json"
539+
"DeviceUpdate_GetOperationStatus": {
540+
"$ref": "./examples/DeviceUpdate_GetOperationStatus.json"
547541
}
548542
},
549543
"parameters": [
@@ -573,9 +567,6 @@
573567
"$ref": "#/definitions/UpdateOperation"
574568
}
575569
},
576-
"304": {
577-
"description": "Not modified."
578-
},
579570
"default": {
580571
"description": "Default response.",
581572
"schema": {
@@ -1980,11 +1971,11 @@
19801971
"tags": [
19811972
"Device and deployment management"
19821973
],
1983-
"operationId": "DeviceManagement_GetOperation",
1974+
"operationId": "DeviceManagement_GetOperationStatus",
19841975
"description": "Retrieve operation status.",
19851976
"x-ms-examples": {
1986-
"DeviceManagement_GetOperation": {
1987-
"$ref": "./examples/DeviceManagement_GetOperation.json"
1977+
"DeviceManagement_GetOperationStatus": {
1978+
"$ref": "./examples/DeviceManagement_GetOperationStatus.json"
19881979
}
19891980
},
19901981
"parameters": [
@@ -2014,9 +2005,6 @@
20142005
"$ref": "#/definitions/DeviceOperation"
20152006
}
20162007
},
2017-
"304": {
2018-
"description": "Not modified."
2019-
},
20202008
"default": {
20212009
"description": "Default response.",
20222010
"schema": {
@@ -2031,11 +2019,11 @@
20312019
"tags": [
20322020
"Device and deployment management"
20332021
],
2034-
"operationId": "DeviceManagement_ListOperations",
2022+
"operationId": "DeviceManagement_ListOperationStatuses",
20352023
"description": "Get a list of all device import operations. Completed operations are kept for 7 days before auto-deleted.",
20362024
"x-ms-examples": {
2037-
"DeviceManagement_ListOperations": {
2038-
"$ref": "./examples/DeviceManagement_ListOperations.json"
2025+
"DeviceManagement_ListOperationStatuses": {
2026+
"$ref": "./examples/DeviceManagement_ListOperationStatuses.json"
20392027
}
20402028
},
20412029
"parameters": [
@@ -2222,7 +2210,7 @@
22222210
"$ref": "#/parameters/InstanceIdParameter"
22232211
},
22242212
{
2225-
"$ref": "#/parameters/OperationIdParameter"
2213+
"$ref": "#/parameters/LogCollectionIdParameter"
22262214
},
22272215
{
22282216
"$ref": "#/parameters/ApiVersionParameter"
@@ -2249,11 +2237,11 @@
22492237
"tags": [
22502238
"Device and deployment management"
22512239
],
2252-
"operationId": "DeviceManagement_ListDeviceHealth",
2240+
"operationId": "DeviceManagement_ListHealthOfDevices",
22532241
"description": "Get list of device health",
22542242
"x-ms-examples": {
2255-
"DeviceManagement_ListDeviceHealth": {
2256-
"$ref": "./examples/DeviceManagement_ListDeviceHealth.json"
2243+
"DeviceManagement_ListHealthOfDevices": {
2244+
"$ref": "./examples/DeviceManagement_ListHealthOfDevices.json"
22572245
}
22582246
},
22592247
"parameters": [
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"lastActionDateTime": "2020-04-22T21:01:43.9401420+00:00",
1616
"etag": "\"a0f7b6f2-3f6c-4eb6-8a59-2f5411c23888\""
1717
}
18-
},
19-
"304": {}
18+
}
2019
}
2120
}

specification/deviceupdate/data-plane/Microsoft.DeviceUpdate/stable/2022-10-01/examples/DeviceUpdate_GetFile.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"mimeType": "application/BuildAsync-s4jwikgq.44h",
2121
"etag": "\"26bd8eba-4bb2-4960-a357-ca4d60b5fb4b\""
2222
}
23-
},
24-
"304": {}
23+
}
2524
}
2625
}
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"lastActionDateTime": "2020-04-22T21:01:43.9401420+00:00",
2525
"etag": "\"a0f7b6f2-3f6c-4eb6-8a59-2f5411c23888\""
2626
}
27-
},
28-
"304": {}
27+
}
2928
}
3029
}

specification/deviceupdate/data-plane/Microsoft.DeviceUpdate/stable/2022-10-01/examples/DeviceUpdate_GetUpdate.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"createdDateTime": "2019-09-12T00:00:00.0000000+00:00",
5151
"etag": "\"3fed3378-0c67-47d2-b796-296962c66cbb\""
5252
}
53-
},
54-
"304": {}
53+
}
5554
}
5655
}

0 commit comments

Comments
 (0)