[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-04-16 (#15072)

* Added suppression for R4005 linting error

* Using Pascal case for resource provider

* Added all missing type:object

* Added supperssion for R3016 - camel case for odata.type

Co-authored-by: Avi Jerafi <[email protected]>

Author: avjerafi

specification/monitor/resource-manager/Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json

@@ -34,7 +34,7 @@
     }
   },
   "paths": {
-    "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules/{ruleName}": {
+    "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Insights/scheduledQueryRules/{ruleName}": {
       "put": {
         "description": "Creates or updates an log search rule.",
         "tags": [
@@ -226,7 +226,7 @@
         }
       }
     },
-    "/subscriptions/{subscriptionId}/providers/microsoft.insights/scheduledQueryRules": {
+    "/subscriptions/{subscriptionId}/providers/Microsoft.Insights/scheduledQueryRules": {
       "get": {
         "tags": [
           "scheduledQueryRules"
@@ -269,7 +269,7 @@
         "x-ms-odata": "#/definitions/LogSearchRuleResource"
       }
     },
-    "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules": {
+    "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Insights/scheduledQueryRules": {
       "get": {
         "tags": [
           "scheduledQueryRules"
@@ -318,6 +318,7 @@
   },
   "definitions": {
     "Resource": {
+      "type": "object",
       "properties": {
         "id": {
           "type": "string",
@@ -343,6 +344,7 @@
           ]
         },
         "tags": {
+          "type": "object",
           "additionalProperties": {
             "type": "string"
           },
@@ -385,8 +387,10 @@
       "description": "The Log Search Rule resource."
     },
     "LogSearchRuleResourcePatch": {
+      "type": "object",
       "properties": {
         "tags": {
+          "type": "object",
           "additionalProperties": {
             "type": "string"
           },
@@ -401,6 +405,7 @@
       "description": "The log search rule resource for patch operations."
     },
     "LogSearchRuleResourceCollection": {
+      "type": "object",
       "properties": {
         "value": {
           "type": "array",
@@ -583,6 +588,7 @@
       "description": "Set value to 'ResultAccount'"
     },
     "LogSearchRule": {
+      "type": "object",
       "description": "Log Search Rule Definition",
       "properties": {
         "createdWithApiVersion": {
@@ -660,6 +666,7 @@
       ]
     },
     "LogSearchRulePatch": {
+      "type": "object",
       "description": "Log Search Rule Definition for Patching",
       "properties": {
         "enabled": {

specification/monitor/resource-manager/readme.md

@@ -721,6 +721,13 @@ directive:
     where: $.paths
     from: scheduledQueryRule_API.json
     reason: 'Operations API is defined in a separate swagger spec for Microsoft.Insights namespace (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json)'
+  - suppress: R4005
+    where: $.definitions.Dimension.properties.operator
+    from: scheduledQueryRule_API.json
+    reason: 'The discrepancy in the enum values is with an enum which is defined for a different service of a different team'
+  - suppress: R3016
+    where: $.definitions.Action.properties["odata.type"]
+    reason: 'This is an old field in a stable api version which is not camel cased'
   - suppress: EnumInsteadOfBoolean
     where: $.definitions.AlertRuleProperties.properties.enabled
     from: activityLogAlerts_API.json