Skip to content

Commit a07a5c2

Browse files
authored
Added more information to SDK PR description and updatedthe PR creation parameter (#36502)
* Added more info to output and print the sdk repo git diff * Updated createPullRequest parameter * remove diff print step * upgrade spec-gen-sdk
1 parent 881ba93 commit a07a5c2

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

eng/pipelines/spec-gen-sdk.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ parameters:
2525
- 'stable'
2626
default: 'beta'
2727
displayName: 'SDK release type'
28-
- name: SkipPullRequestCreation
28+
- name: CreatePullRequest
2929
type: boolean
3030
default: false
31-
displayName: 'Skip SDK pull request creation'
32-
31+
displayName: 'Create SDK pull request'
32+
3333
trigger: none
3434

3535
extends:
@@ -42,4 +42,4 @@ extends:
4242
ConfigPath: ${{ parameters.ConfigPath }}
4343
ApiVersion: ${{ parameters.ApiVersion }}
4444
SdkReleaseType: ${{ parameters.SdkReleaseType }}
45-
SkipPullRequestCreation: ${{ parameters.SkipPullRequestCreation }}
45+
CreatePullRequest: ${{ parameters.CreatePullRequest }}

eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ parameters:
2222
type: string
2323
default: ''
2424
displayName: 'SDK release type'
25-
- name: SkipPullRequestCreation
25+
- name: CreatePullRequest
2626
type: boolean
2727
default: false
2828
- name: SpecBatchTypes
@@ -171,6 +171,11 @@ stages:
171171
sdk_gen_info="$sdk_gen_info API Version: ${{ parameters.ApiVersion }}, SDK Release Type: ${{ parameters.SdkReleaseType }},"
172172
fi
173173
sdk_gen_info="$sdk_gen_info and CommitSHA: '$updatedSpecRepoCommit' in SpecRepo: '${{ parameters.SpecRepoUrl }}'"
174+
175+
if [ "$(Build.Reason)" = "Manual" ]; then
176+
sdk_gen_info="$sdk_gen_info Pipeline run: $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId)"
177+
sdk_gen_info="$sdk_gen_info Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release."
178+
fi
174179
echo "##vso[task.setvariable variable=GeneratedSDKInformation]$sdk_gen_info"
175180
echo "$sdk_gen_info"
176181
@@ -200,7 +205,7 @@ stages:
200205
ArtifactPath: $(StagedArtifactsFolder)
201206
CustomCondition: and(succeededOrFailed(), ne(variables['StagedArtifactsFolder'], ''))
202207

203-
- ${{ if and(eq(variables['System.TeamProject'], 'internal'), eq(parameters.SkipPullRequestCreation, false), ne(variables['Build.Reason'], 'PullRequest')) }}:
208+
- ${{ if and(eq(variables['System.TeamProject'], 'internal'), eq(parameters.CreatePullRequest, true), ne(variables['Build.Reason'], 'PullRequest')) }}:
204209
- template: /eng/common/pipelines/templates/steps/git-push-changes.yml
205210
parameters:
206211
BaseRepoBranch: $(PrBranch)-$(Build.BuildId)

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "azure-rest-api-specs",
33
"devDependencies": {
4-
"@azure-tools/spec-gen-sdk": "~0.9.0",
4+
"@azure-tools/spec-gen-sdk": "~0.9.1",
55
"@azure-tools/specs-shared": "file:.github/shared",
66
"@azure-tools/typespec-apiview": "0.7.2",
77
"@azure-tools/typespec-autorest": "0.58.1",

0 commit comments

Comments
 (0)