[summarize-checks] Switch to GitHub Actions (#36570)

mikeharder · web-flow · commit af8eab53472c · 2025-08-13T14:31:42.000-07:00
diff --git a/.github/workflows/src/summarize-checks/summarize-checks.js b/.github/workflows/src/summarize-checks/summarize-checks.js
@@ -19,12 +19,12 @@
 */
 
 // #region imports/constants
-import { extractInputs } from "../context.js";
-// import { commentOrUpdate } from "../comment.js";
 import { execFile } from "../../../shared/src/exec.js";
 import { CheckConclusion, PER_PAGE_MAX } from "../../../shared/src/github.js";
 import { intersect } from "../../../shared/src/set.js";
 import { byDate, invert } from "../../../shared/src/sort.js";
+import { commentOrUpdate } from "../comment.js";
+import { extractInputs } from "../context.js";
 import {
   brChRevApproval,
   getViolatedRequiredLabelsRules,
@@ -141,7 +141,8 @@ const FYI_CHECK_NAMES = [
   "Swagger BreakingChange",
   "Swagger PrettierCheck",
 ];
-const AUTOMATED_CHECK_NAME = "[TEST-IGNORE] Automated merging requirements met";
+const AUTOMATED_CHECK_NAME = "Automated merging requirements met";
+const IMPACT_CHECK_NAME = "Summarize PR Impact";
 const NEXT_STEPS_COMMENT_ID = "NextStepsToMerge";
 
 /** @type {CheckMetadata[]} */
@@ -403,24 +404,24 @@ export async function summarizeChecksImpl(
 
   for (const label of labelContext.toRemove) {
     core.info(`Removing label: ${label} from ${owner}/${repo}#${issue_number}.`);
-    // await github.rest.issues.removeLabel({
-    //   owner: owner,
-    //   repo: repo,
-    //   issue_number: issue_number,
-    //   name: label,
-    // });
+    await github.rest.issues.removeLabel({
+      owner: owner,
+      repo: repo,
+      issue_number: issue_number,
+      name: label,
+    });
   }
 
   if (labelContext.toAdd.size > 0) {
     core.info(
       `Adding labels: ${Array.from(labelContext.toAdd).join(", ")} to ${owner}/${repo}#${issue_number}.`,
     );
-    // await github.rest.issues.addLabels({
-    //   owner: owner,
-    //   repo: repo,
-    //   issue_number: issue_number,
-    //   labels: Array.from(labelContext.toAdd),
-    // });
+    await github.rest.issues.addLabels({
+      owner: owner,
+      repo: repo,
+      issue_number: issue_number,
+      labels: Array.from(labelContext.toAdd),
+    });
   }
 
   // adjust labelNames based on labelsToAdd/labelsToRemove
@@ -451,20 +452,21 @@ export async function summarizeChecksImpl(
   core.summary.write();
 
   // this will remain commented until we're comfortable with the change.
-  // await commentOrUpdate(
-  //   { github, context, core },
-  //   owner,
-  //   repo,
-  //   issue_number,
-  //   commentName,
-  //   commentBody
-  // )
+  await commentOrUpdate(
+    github,
+    core,
+    owner,
+    repo,
+    issue_number,
+    commentBody,
+    NEXT_STEPS_COMMENT_ID,
+  );
 
   // finally, update the "Automated merging requirements met" commit status
   await updateCommitStatus(github, core, owner, repo, head_sha, automatedChecksMet);
 
   core.info(
-    `Summarize checks has identified that status of "[TEST-IGNORE] Automated merging requirements met" commit status should be updated to: ${JSON.stringify(automatedChecksMet)}.`,
+    `Summarize checks has identified that status of "${AUTOMATED_CHECK_NAME}" commit status should be updated to: ${JSON.stringify(automatedChecksMet)}.`,
   );
   core.summary.addHeading("Automated Checks Met", 2);
   core.summary.addCodeBlock(JSON.stringify(automatedChecksMet, null, 2));
@@ -517,9 +519,6 @@ export async function updateCommitStatus(github, core, owner, repo, head_sha, ch
  * @param {string} owner
  * @param {string} repo
  * @param {number} issue_number
- * @param {*} owner
- * @param {*} repo
- * @param {*} issue_number
  * @return {Promise<string[]>}
  */
 export async function getExistingLabels(github, owner, repo, issue_number) {
@@ -731,10 +730,8 @@ export async function getCheckRunTuple(
 
     const latestCheck = sortedChecks[0];
 
-    // just handling both names for ease of integration testing
     if (
-      (latestCheck.name === "[TEST-IGNORE] Summarize PR Impact" ||
-        latestCheck.name === "Summarize PR Impact") &&
+      latestCheck.name === IMPACT_CHECK_NAME &&
       latestCheck.status === "completed" &&
       latestCheck.conclusion === "success"
     ) {
@@ -805,7 +802,7 @@ export async function getCheckRunTuple(
       );
     }
   } else {
-    requiredCheckNames = ["Summarize PR Impact", "[TEST-IGNORE] Summarize PR Impact"];
+    requiredCheckNames = [IMPACT_CHECK_NAME];
   }
 
   const filteredReqCheckRuns = unifiedCheckRuns.filter(
diff --git a/.github/workflows/summarize-checks.yaml b/.github/workflows/summarize-checks.yaml
@@ -1,11 +1,11 @@
-name: "[TEST-IGNORE] Summarize Checks"
+name: "Summarize Checks"
 
 on:
   workflow_run:
     workflows:
-      - "\\[TEST-IGNORE\\] Swagger SemanticValidation - Set Status"
-      - "\\[TEST-IGNORE\\] Swagger ModelValidation - Set Status"
-      - "\\[TEST-IGNORE\\] Summarize PR Impact"
+      - "Swagger SemanticValidation - Set Status"
+      - "Swagger ModelValidation - Set Status"
+      - "Summarize PR Impact"
       - "Swagger Avocado - Set Status"
       - "Swagger LintDiff - Set Status"
       - "SDK Validation Status"
@@ -34,7 +34,7 @@ permissions:
 jobs:
   run-summarize-checks:
     if: ${{ github.event_name == 'pull_request_target' || github.event.workflow_run.conclusion != 'skipped' }}
-    name: "[TEST-IGNORE] Summarize Checks"
+    name: "Summarize Checks"
     runs-on: ubuntu-24.04
 
     steps:
diff --git a/.github/workflows/summarize-impact.yaml b/.github/workflows/summarize-impact.yaml
@@ -1,4 +1,4 @@
-name: "[TEST-IGNORE] Summarize PR Impact"
+name: "Summarize PR Impact"
 
 on:
   pull_request:
@@ -16,7 +16,7 @@ permissions:
 
 jobs:
   impact:
-    name: "[TEST-IGNORE] Summarize PR Impact"
+    name: "Summarize PR Impact"
     runs-on: ubuntu-24.04
 
     steps:
diff --git a/.github/workflows/swagger-modelvalidation-code.yaml b/.github/workflows/swagger-modelvalidation-code.yaml
@@ -1,4 +1,4 @@
-name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code"
+name: "Swagger ModelValidation - Analyze Code"
 
 on: pull_request
 
@@ -7,7 +7,7 @@ permissions:
 
 jobs:
   oav:
-    name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code"
+    name: "Swagger ModelValidation - Analyze Code"
     runs-on: ubuntu-24.04
 
     steps:
diff --git a/.github/workflows/swagger-modelvalidation-status.yaml b/.github/workflows/swagger-modelvalidation-status.yaml
@@ -1,4 +1,4 @@
-name: "[TEST-IGNORE] Swagger ModelValidation - Set Status"
+name: "Swagger ModelValidation - Set Status"
 
 on:
   # Must run on pull_request_target instead of pull_request, since the latter cannot trigger on
@@ -15,7 +15,7 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["\\[TEST-IGNORE\\] Swagger ModelValidation - Analyze Code"]
+    workflows: ["Swagger ModelValidation - Analyze Code"]
     types: [completed]
 
 permissions:
@@ -30,6 +30,6 @@ jobs:
     name: Set ModelValidation Status
     uses: ./.github/workflows/_reusable-set-check-status.yaml
     with:
-      monitored_workflow_name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code"
-      required_check_name: "[TEST-IGNORE] Swagger ModelValidation"
+      monitored_workflow_name: "Swagger ModelValidation - Analyze Code"
+      required_check_name: "Swagger ModelValidation"
       overriding_label: "Approved-ModelValidation"
diff --git a/.github/workflows/swagger-semanticvalidation-code.yaml b/.github/workflows/swagger-semanticvalidation-code.yaml
@@ -1,4 +1,4 @@
-name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code"
+name: "Swagger SemanticValidation - Analyze Code"
 
 on: pull_request
 
@@ -7,7 +7,7 @@ permissions:
 
 jobs:
   oav:
-    name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code"
+    name: "Swagger SemanticValidation - Analyze Code"
     runs-on: ubuntu-24.04
 
     steps:
diff --git a/.github/workflows/swagger-semanticvalidation-status.yaml b/.github/workflows/swagger-semanticvalidation-status.yaml
@@ -1,4 +1,4 @@
-name: "[TEST-IGNORE] Swagger SemanticValidation - Set Status"
+name: "Swagger SemanticValidation - Set Status"
 
 on:
   # Must run on pull_request_target instead of pull_request, since the latter cannot trigger on
@@ -15,7 +15,7 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["\\[TEST-IGNORE\\] Swagger SemanticValidation - Analyze Code"]
+    workflows: ["Swagger SemanticValidation - Analyze Code"]
     types: [completed]
 
 permissions:
@@ -30,6 +30,6 @@ jobs:
     name: Set SemanticValidation Status
     uses: ./.github/workflows/_reusable-set-check-status.yaml
     with:
-      monitored_workflow_name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code"
-      required_check_name: "[TEST-IGNORE] Swagger SemanticValidation"
+      monitored_workflow_name: "Swagger SemanticValidation - Analyze Code"
+      required_check_name: "Swagger SemanticValidation"
       overriding_label: "Approved-SemanticValidation"
diff --git a/.github/workflows/test/set-status.test.js b/.github/workflows/test/set-status.test.js
@@ -72,8 +72,8 @@ describe("setStatusImpl", () => {
         target_url: "https://test.com/set_status_url",
         github,
         core,
-        monitoredWorkflowName: "[TEST-IGNORE] Swagger Avocado - Analyze Code",
-        requiredStatusName: "[TEST-IGNORE] Swagger Avocado",
+        monitoredWorkflowName: "Swagger Avocado - Analyze Code",
+        requiredStatusName: "Swagger Avocado",
         overridingLabel: "Approved-Avocado",
       }),
     ).resolves.toBeUndefined();
@@ -83,7 +83,7 @@ describe("setStatusImpl", () => {
       repo: "test-repo",
       sha: fullGitSha,
       state: CommitStatusState.SUCCESS,
-      context: "[TEST-IGNORE] Swagger Avocado",
+      context: "Swagger Avocado",
       description: "Found label 'Approved-Avocado'",
       target_url: "https://test.com/set_status_url",
     });
@@ -103,8 +103,8 @@ describe("setStatusImpl", () => {
         target_url: "https://test.com/set_status_url",
         github,
         core,
-        monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code",
-        requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange",
+        monitoredWorkflowName: "Swagger BreakingChange - Analyze Code",
+        requiredStatusName: "Swagger BreakingChange",
         overridingLabel:
           "BreakingChange-Approved-Benign,BreakingChange-Approved-BugFix,BreakingChange-Approved-UserImpact",
       }),
@@ -115,7 +115,7 @@ describe("setStatusImpl", () => {
       repo: "test-repo",
       sha: fullGitSha,
       state: CommitStatusState.SUCCESS,
-      context: "[TEST-IGNORE] Swagger BreakingChange",
+      context: "Swagger BreakingChange",
       description: "Found label 'BreakingChange-Approved-Benign'",
       target_url: "https://test.com/set_status_url",
     });
@@ -138,8 +138,8 @@ describe("setStatusImpl", () => {
         target_url: "https://test.com/set_status_url",
         github,
         core,
-        monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code",
-        requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange",
+        monitoredWorkflowName: "Swagger BreakingChange - Analyze Code",
+        requiredStatusName: "Swagger BreakingChange",
         overridingLabel:
           "BreakingChange-Approved-Benign, BreakingChange-Approved-BugFix , BreakingChange-Approved-UserImpact",
       }),
@@ -150,7 +150,7 @@ describe("setStatusImpl", () => {
       repo: "test-repo",
       sha: fullGitSha,
       state: CommitStatusState.SUCCESS,
-      context: "[TEST-IGNORE] Swagger BreakingChange",
+      context: "Swagger BreakingChange",
       description: "Found label 'BreakingChange-Approved-UserImpact'",
       target_url: "https://test.com/set_status_url",
     });
@@ -170,8 +170,8 @@ describe("setStatusImpl", () => {
         target_url: "https://test.com/set_status_url",
         github,
         core,
-        monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code",
-        requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange",
+        monitoredWorkflowName: "Swagger BreakingChange - Analyze Code",
+        requiredStatusName: "Swagger BreakingChange",
         overridingLabel: "BreakingChange-Approved-Benign,,BreakingChange-Approved-Security,",
       }),
     ).resolves.toBeUndefined();
@@ -181,7 +181,7 @@ describe("setStatusImpl", () => {
       repo: "test-repo",
       sha: fullGitSha,
       state: CommitStatusState.SUCCESS,
-      context: "[TEST-IGNORE] Swagger BreakingChange",
+      context: "Swagger BreakingChange",
       description: "Found label 'BreakingChange-Approved-Security'",
       target_url: "https://test.com/set_status_url",
     });
@@ -205,8 +205,8 @@ describe("setStatusImpl", () => {
         target_url: "https://test.com/set_status_url",
         github,
         core,
-        monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code",
-        requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange",
+        monitoredWorkflowName: "Swagger BreakingChange - Analyze Code",
+        requiredStatusName: "Swagger BreakingChange",
         overridingLabel:
           "BreakingChange-Approved-Benign,BreakingChange-Approved-BugFix,BreakingChange-Approved-UserImpact",
       }),
@@ -217,7 +217,7 @@ describe("setStatusImpl", () => {
       repo: "test-repo",
       sha: fullGitSha,
       state: CommitStatusState.PENDING,
-      context: "[TEST-IGNORE] Swagger BreakingChange",
+      context: "Swagger BreakingChange",
       target_url: "https://test.com/set_status_url",
     });
   });
@@ -240,8 +240,8 @@ describe("setStatusImpl", () => {
         target_url: "https://test.com/set_status_url",
         github,
         core,
-        monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code",
-        requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange",
+        monitoredWorkflowName: "Swagger BreakingChange - Analyze Code",
+        requiredStatusName: "Swagger BreakingChange",
         overridingLabel: "",
       }),
     ).resolves.toBeUndefined();
@@ -251,7 +251,7 @@ describe("setStatusImpl", () => {
       repo: "test-repo",
       sha: fullGitSha,
       state: CommitStatusState.PENDING,
-      context: "[TEST-IGNORE] Swagger BreakingChange",
+      context: "Swagger BreakingChange",
       target_url: "https://test.com/set_status_url",
     });
   });
@@ -294,7 +294,7 @@ describe("setStatusImpl", () => {
         github.rest.actions.listWorkflowRunsForRepo.mockResolvedValue({
           data: [
             {
-              name: "[TEST-IGNORE] Swagger Avocado - Analyze Code",
+              name: "Swagger Avocado - Analyze Code",
               status: checkStatus,
               conclusion: checkConclusion,
               updated_at: "2025-01-01",
@@ -333,8 +333,8 @@ describe("setStatusImpl", () => {
           target_url: "https://test.com/set_status_url",
           github,
           core,
-          monitoredWorkflowName: "[TEST-IGNORE] Swagger Avocado - Analyze Code",
-          requiredStatusName: "[TEST-IGNORE] Swagger Avocado",
+          monitoredWorkflowName: "Swagger Avocado - Analyze Code",
+          requiredStatusName: "Swagger Avocado",
           overridingLabel: "Approved-Avocado",
         }),
       ).resolves.toBeUndefined();
@@ -344,7 +344,7 @@ describe("setStatusImpl", () => {
         repo: "test-repo",
         sha: fullGitSha,
         state: commitStatusState,
-        context: "[TEST-IGNORE] Swagger Avocado",
+        context: "Swagger Avocado",
         target_url: targetUrl,
       });
     },
diff --git a/.github/workflows/test/summarize-checks/summarize-checks.test.js b/.github/workflows/test/summarize-checks/summarize-checks.test.js
diff --git a/.github/workflows/watch-modelvalidation.yaml b/.github/workflows/watch-modelvalidation.yaml
diff --git a/.github/workflows/watch-semanticvalidation.yaml b/.github/workflows/watch-semanticvalidation.yaml
