Skip to content

Commit cd8e47b

Browse files
committed
PR comments
1 parent e25cda5 commit cd8e47b

File tree

4 files changed

+8
-14
lines changed

4 files changed

+8
-14
lines changed

specification/containerregistry/data-plane/Registry/client.tsp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ import "@azure-tools/typespec-client-generator-core";
44

55
using Azure.ClientGenerator.Core;
66

7+
// TCGC usage decorators for output-only types
8+
@@usage(ContainerRegistry.TokenGrantType, Usage.output);
9+
@@usage(ContainerRegistry.AcrErrors, Usage.output);
10+
711
@@clientName(ContainerRegistry, "ContainerRegistry");
812
// Rename ChangeableAttributes models to WriteableProperties for Python SDK backward compatibility
913
@@clientName(ContainerRegistry.ManifestChangeableAttributes,

specification/containerregistry/data-plane/Registry/models.tsp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
import "@typespec/rest";
22
import "@typespec/http";
33
import "@azure-tools/typespec-azure-core";
4-
import "@azure-tools/typespec-client-generator-core";
54

6-
using TypeSpec.Rest;
75
using TypeSpec.Http;
86
using Azure.Core;
9-
using Azure.ClientGenerator.Core;
107

118
namespace ContainerRegistry;
129

@@ -180,7 +177,6 @@ union PostContentSchemaGrantType {
180177
/**
181178
* Grant type is expected to be refresh_token
182179
*/
183-
@usage(Usage.output)
184180
union TokenGrantType {
185181
string,
186182

@@ -242,7 +238,6 @@ union ArtifactManifestOrder {
242238
/**
243239
* Acr error response describing why the operation failed
244240
*/
245-
@usage(Usage.output)
246241
@error
247242
model AcrErrors {
248243
/**

specification/containerregistry/data-plane/Registry/routes.tsp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
import "@azure-tools/typespec-azure-core";
22
import "@typespec/rest";
33
import "./models.tsp";
4-
import "@typespec/openapi";
54

6-
using TypeSpec.Rest;
75
using TypeSpec.Http;
8-
using TypeSpec.OpenAPI;
96
using Azure.Core;
107
using Azure.Core.Foundations;
118

@@ -129,9 +126,7 @@ interface ContainerRegistry {
129126
@path
130127
reference: string;
131128
},
132-
{
133-
@statusCode statusCode: 202;
134-
} | NotFoundResponse
129+
TypeSpec.Http.AcceptedResponse | NotFoundResponse
135130
>;
136131

137132
/**

specification/containerregistry/data-plane/Registry/tspconfig.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ linter:
1212
options:
1313
"@azure-tools/typespec-autorest":
1414
azure-resource-provider-folder: "data-plane"
15-
emitter-output-dir: "{project-root}/.."
15+
emitter-output-dir: "{project-root}"
1616
examples-dir: "{project-root}/examples"
17-
output-file: "Registry/{version-status}/{version}/containerregistry.json"
17+
output-file: "{version-status}/{version}/containerregistry.json"
1818
"@azure-tools/typespec-python":
1919
emitter-output-dir: "{output-dir}/{service-dir}/azure-containerregistry"
2020
package-name: "azure-containerregistry"
2121
package-pprint-name: "Azure Container Registry"
22-
namespace: "azure.containerregistry"
22+
namespace: "azure.containerregistry._generated"
2323
package-version: "1.2.0"
2424
flavor: "azure"
2525
generate-test: false

0 commit comments

Comments
 (0)