Skip to content

Commit dbd7b63

Browse files
tdarolyTaher Darolywala
andauthored
Resolve Comments for Event driven jobs (#23729)
* Resolve Comments for Event driven jobs * change scaling rule to azure-servicebus * update example --------- Co-authored-by: Taher Darolywala <[email protected]>
1 parent f8b4b9a commit dbd7b63

File tree

2 files changed

+39
-9
lines changed

2 files changed

+39
-9
lines changed

specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
"Create or Update Container Apps Job": {
201201
"$ref": "./examples/Job_CreateorUpdate.json"
202202
},
203-
"Create or Update Container Apps Job With Event Driver Trigger": {
203+
"Create or Update Container Apps Job With Event Driven Trigger": {
204204
"$ref": "./examples/Job_CreateorUpdate_EventTrigger.json"
205205
}
206206
},

specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/Job_CreateorUpdate_EventTrigger.json

Lines changed: 38 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
"maxReplicas": 5,
2020
"rules": [
2121
{
22-
"name": "httpscalingrule",
22+
"name": "servicebuscalingrule",
2323
"custom": {
24-
"type": "http",
24+
"type": "azure-servicebus",
2525
"metadata": {
2626
"concurrentRequests": "50"
2727
}
@@ -91,11 +91,26 @@
9191
"configuration": {
9292
"replicaTimeout": 10,
9393
"replicaRetryLimit": 10,
94-
"manualTriggerConfig": {
94+
"eventTriggerConfig": {
9595
"replicaCompletionCount": 1,
96-
"parallelism": 4
96+
"parallelism": 4,
97+
"scale": {
98+
"minReplicas": 1,
99+
"maxReplicas": 5,
100+
"rules": [
101+
{
102+
"name": "servicebuscalingrule",
103+
"custom": {
104+
"type": "azure-servicebus",
105+
"metadata": {
106+
"concurrentRequests": "50"
107+
}
108+
}
109+
}
110+
]
111+
}
97112
},
98-
"triggerType": "Manual"
113+
"triggerType": "Event"
99114
},
100115
"template": {
101116
"containers": [
@@ -162,11 +177,26 @@
162177
"configuration": {
163178
"replicaTimeout": 10,
164179
"replicaRetryLimit": 10,
165-
"manualTriggerConfig": {
180+
"eventTriggerConfig": {
166181
"replicaCompletionCount": 1,
167-
"parallelism": 4
182+
"parallelism": 4,
183+
"scale": {
184+
"minReplicas": 1,
185+
"maxReplicas": 5,
186+
"rules": [
187+
{
188+
"name": "servicebuscalingrule",
189+
"custom": {
190+
"type": "azure-servicebus",
191+
"metadata": {
192+
"concurrentRequests": "50"
193+
}
194+
}
195+
}
196+
]
197+
}
168198
},
169-
"triggerType": "Manual"
199+
"triggerType": "Event"
170200
},
171201
"template": {
172202
"containers": [

0 commit comments

Comments
 (0)