Skip to content

Commit ead7d7e

Browse files
[Confidential Ledger] Post Board Review Changes (#19752)
* beginning updates * updating stable version * post -> create * fixing next link setup * prettier fix * Update specification/confidentialledger/data-plane/Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json Co-authored-by: Mike Kistler <[email protected]> * collection array revert * update list collections example * identity service update * add x-ms-pageable to consortium * revert resource manager changes * add pagination to collections * lyndon edits * laurent fix Co-authored-by: Mike Kistler <[email protected]>
1 parent 61c0292 commit ead7d7e

File tree

6 files changed

+60
-32
lines changed

6 files changed

+60
-32
lines changed

specification/confidentialledger/data-plane/Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json

Lines changed: 41 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
"description": "The ConfidentialLedgerClient writes and retrieves ledger entries against the Confidential Ledger service."
77
},
88
"x-ms-parameterized-host": {
9-
"hostTemplate": "{ledgerUri}",
9+
"hostTemplate": "{ledgerEndpoint}",
1010
"useSchemePrefix": false,
1111
"positionInOperation": "first",
1212
"parameters": [
1313
{
14-
"name": "ledgerUri",
14+
"name": "ledgerEndpoint",
1515
"description": "The Confidential Ledger URL, for example https://contoso.confidentialledger.azure.com",
1616
"required": true,
1717
"type": "string",
@@ -62,13 +62,17 @@
6262
},
6363
"/app/governance/members": {
6464
"get": {
65-
"operationId": "GetConsortiumMembers",
65+
"operationId": "ListConsortiumMembers",
6666
"x-ms-examples": {
67-
"GetConsortiumMembers": {
68-
"$ref": "./examples/ledger/GetConsortiumMembers.json"
67+
"ListConsortiumMembers": {
68+
"$ref": "./examples/ledger/ListConsortiumMembers.json"
6969
}
7070
},
71-
"summary": "Gets the consortium members.",
71+
"x-ms-pageable": {
72+
"itemName": "members",
73+
"nextLinkName": "nextLink"
74+
},
75+
"summary": "Lists the consortium members.",
7276
"description": "Consortium members can manage the Confidential Ledger.",
7377
"parameters": [
7478
{
@@ -130,6 +134,10 @@
130134
"$ref": "./examples/ledger/ListCollections.json"
131135
}
132136
},
137+
"x-ms-pageable": {
138+
"itemName": "collections",
139+
"nextLinkName": "nextLink"
140+
},
133141
"summary": "Retrieves a list of collection ids present in the Confidential Ledger",
134142
"description": "Collection ids are user-created collections of ledger entries",
135143
"parameters": [
@@ -141,7 +149,7 @@
141149
"200": {
142150
"description": "List of collections",
143151
"schema": {
144-
"$ref": "#/definitions/CollectionArray"
152+
"$ref": "#/definitions/PagedCollections"
145153
}
146154
},
147155
"default": {
@@ -157,7 +165,7 @@
157165
"get": {
158166
"operationId": "ListLedgerEntries",
159167
"x-ms-examples": {
160-
"GetLedgerEntries": {
168+
"ListLedgerEntries": {
161169
"$ref": "./examples/ledger/ListLedgerEntries.json"
162170
}
163171
},
@@ -197,10 +205,10 @@
197205
}
198206
},
199207
"post": {
200-
"operationId": "PostLedgerEntry",
208+
"operationId": "CreateLedgerEntry",
201209
"x-ms-examples": {
202-
"PostLedgerEntry": {
203-
"$ref": "./examples/ledger/PostLedgerEntry.json"
210+
"CreateLedgerEntry": {
211+
"$ref": "./examples/ledger/CreateLedgerEntry.json"
204212
}
205213
},
206214
"summary": "Writes a ledger entry.",
@@ -510,6 +518,10 @@
510518
"items": {
511519
"$ref": "#/definitions/ConsortiumMember"
512520
}
521+
},
522+
"nextLink": {
523+
"description": "Path from which to retrieve the next page of results.",
524+
"type": "string"
513525
}
514526
},
515527
"type": "object"
@@ -826,12 +838,24 @@
826838
},
827839
"type": "object"
828840
},
829-
"CollectionArray": {
830-
"description": "A list of identifiers for ledger collections.",
831-
"items": {
832-
"$ref": "#/definitions/Collection"
833-
},
834-
"type": "array"
841+
"PagedCollections": {
842+
"description": "Paginated collections returned in response to a query.",
843+
"type": "object",
844+
"required": [
845+
"collections"
846+
],
847+
"properties": {
848+
"collections": {
849+
"items": {
850+
"$ref": "#/definitions/Collection"
851+
},
852+
"type": "array"
853+
},
854+
"nextLink": {
855+
"description": "Path from which to retrieve the next page of results.",
856+
"type": "string"
857+
}
858+
}
835859
},
836860
"TransactionId": {
837861
"description": "A unique identifier for the state of the ledger. If returned as part of a LedgerEntry, it indicates the state from which the entry was read.",

specification/confidentialledger/data-plane/Microsoft.ConfidentialLedger/stable/2022-05-13/examples/identity/GetLedgerIdentity.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"parameters": {
33
"api-version": "2022-05-13",
44
"ledgerId": "contoso-ledger-12345",
5-
"identityServiceUri": "identity.accledger.azure.com"
5+
"certificateClientEndpoint": "identity.confidential-ledger.core.azure.com"
66
},
77
"responses": {
88
"200": {

specification/confidentialledger/data-plane/Microsoft.ConfidentialLedger/stable/2022-05-13/examples/ledger/ListCollections.json

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,17 @@
55
},
66
"responses": {
77
"200": {
8-
"body": [
9-
{
10-
"collectionId": "first"
11-
},
12-
{
13-
"collectionId": "second"
14-
}
15-
]
8+
"body": {
9+
"collections": [
10+
{
11+
"collectionId": "first"
12+
},
13+
{
14+
"collectionId": "second"
15+
}
16+
]
17+
},
18+
"nextLink": "<link>"
1619
}
1720
}
1821
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"certificate": "<PEM certificate>",
1212
"id": "0"
1313
}
14-
]
14+
],
15+
"nextLink": "<link>"
1516
}
1617
}
1718
}

specification/confidentialledger/data-plane/Microsoft.ConfidentialLedger/stable/2022-05-13/identityservice.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"swagger": "2.0",
33
"info": {
44
"version": "2022-05-13",
5-
"title": "ConfidentialLedgerIdentityServiceClient",
6-
"description": "The ConfidentialLedgerIdentityServiceClient is used to retrieve the TLS certificate required for connecting to a Confidential Ledger."
5+
"title": "ConfidentialLedgerCertificateClient",
6+
"description": "The ConfidentialLedgerCertificateClient is used to retrieve the TLS certificate required for connecting to a Confidential Ledger."
77
},
88
"x-ms-parameterized-host": {
9-
"hostTemplate": "{identityServiceUri}",
9+
"hostTemplate": "{certificateClientEndpoint}",
1010
"useSchemePrefix": false,
1111
"positionInOperation": "first",
1212
"parameters": [
1313
{
14-
"name": "identityServiceUri",
15-
"description": "The Identity Service URL, for example https://identity.accledger.azure.com",
14+
"name": "certificateClientEndpoint",
15+
"description": "The certificate client endpoint, for example https://identity.confidential-ledger.core.azure.com",
1616
"required": true,
1717
"type": "string",
1818
"in": "path",

0 commit comments

Comments
 (0)