[Key Vault] Optional parameter support in TSP (#34032)

Author: mccoyp

specification/keyvault/Security.KeyVault.Certificates/client.tsp

@@ -2,8 +2,8 @@ import "./main.tsp";
 import "@azure-tools/typespec-client-generator-core";
 
 using Azure.ClientGenerator.Core;
-using TypeSpec.Versioning;
 using TypeSpec.Http;
+using TypeSpec.Versioning;
 
 @versioned(KeyVault.Versions)
 namespace Customizations;
@@ -14,6 +14,71 @@ namespace Customizations;
 
 using KeyVault;
 
+// Make optional path parameter required for all languages
+
+/**
+ * The UpdateCertificate operation applies the specified update on the given certificate; the only elements updated are the certificate's attributes. This operation requires the certificates/update permission.
+ */
+#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Foundations.Operation is necessary for Key Vault"
+@summary("Updates the specified attributes associated with the given certificate.")
+@route("/certificates/{certificate-name}/{certificate-version}")
+@patch(#{ implicitOptionality: true })
+op updateCertificate is KeyVaultOperation<
+  {
+    /**
+     * The name of the certificate in the given key vault.
+     */
+    @path("certificate-name")
+    @clientName("name", "go")
+    certificateName: string;
+
+    /**
+     * The version of the certificate.
+     */
+    @path("certificate-version")
+    @clientName("version", "go")
+    certificateVersion: string;
+
+    /**
+     * The parameters for certificate update.
+     */
+    #suppress "deprecated" "Property flattening is supported for legacy scenarios like Key Vault's"
+    @body
+    @flattenProperty
+    parameters: CertificateUpdateParameters;
+  },
+  CertificateBundle
+>;
+
+/**
+ * Gets information about a specific certificate. This operation requires the certificates/get permission.
+ */
+#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Foundations.Operation is necessary for Key Vault"
+@summary("Gets information about a certificate.")
+@route("/certificates/{certificate-name}/{certificate-version}")
+@get
+op getCertificate is KeyVaultOperation<
+  {
+    /**
+     * The name of the certificate in the given vault.
+     */
+    @path("certificate-name")
+    @clientName("name", "go")
+    certificateName: string;
+
+    /**
+     * The version of the certificate. This URI fragment is optional. If not specified, the latest version of the certificate is returned.
+     */
+    @path("certificate-version")
+    @clientName("version", "go")
+    certificateVersion: string;
+  },
+  CertificateBundle
+>;
+
+@@override(KeyVault.updateCertificate, updateCertificate);
+@@override(KeyVault.getCertificate, getCertificate);
+
 // Java configuration
 @@usage(CertificateIssuerItem, Usage.input, "java");
 @@usage(CertificateOperation, Usage.input, "java");

specification/keyvault/Security.KeyVault.Certificates/routes.tsp

@@ -336,6 +336,7 @@ op updateCertificatePolicy is KeyVaultOperation<
  * The UpdateCertificate operation applies the specified update on the given certificate; the only elements updated are the certificate's attributes. This operation requires the certificates/update permission.
  */
 #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Foundations.Operation is necessary for Key Vault"
+#suppress "@azure-tools/typespec-autorest/unsupported-optional-path-param" "Intentionally optional"
 @summary("Updates the specified attributes associated with the given certificate.")
 @route("/certificates/{certificate-name}/{certificate-version}")
 @patch(#{ implicitOptionality: true })
@@ -353,7 +354,7 @@ op updateCertificate is KeyVaultOperation<
      */
     @path("certificate-version")
     @clientName("version", "go")
-    certificateVersion: string;
+    certificateVersion?: string;
 
     /**
      * The parameters for certificate update.
@@ -370,6 +371,7 @@ op updateCertificate is KeyVaultOperation<
  * Gets information about a specific certificate. This operation requires the certificates/get permission.
  */
 #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Foundations.Operation is necessary for Key Vault"
+#suppress "@azure-tools/typespec-autorest/unsupported-optional-path-param" "Intentionally optional"
 @summary("Gets information about a certificate.")
 @route("/certificates/{certificate-name}/{certificate-version}")
 @get
@@ -387,7 +389,7 @@ op getCertificate is KeyVaultOperation<
      */
     @path("certificate-version")
     @clientName("version", "go")
-    certificateVersion: string;
+    certificateVersion?: string;
   },
   CertificateBundle
 >;

specification/keyvault/Security.KeyVault.Common/common.tsp

@@ -2,13 +2,11 @@ import "@azure-tools/typespec-azure-core";
 import "@typespec/openapi";
 
 using Azure.Core;
-using TypeSpec.OpenAPI;
 
 alias KeyVaultOperation<
   TParams extends Reflection.Model,
   TResponse,
-  Traits extends Reflection.Model = {},
-  TError = Error
+  Traits extends Reflection.Model = {}
 > = Foundations.Operation<TParams, TResponse, Traits, KeyVaultError>;
 
 /**