Skip to content

Commit f8b4543

Browse files
authored
Add Pre-approved supressions for July Preview (#29010)
1 parent 89a696e commit f8b4543

File tree

1 file changed

+43
-0
lines changed
  • specification/machinelearningservices/resource-manager

1 file changed

+43
-0
lines changed

specification/machinelearningservices/resource-manager/readme.md

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,49 @@ input-file:
4040
- Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json
4141
- Microsoft.MachineLearningServices/preview/2024-07-01-preview/registries.json
4242
- Microsoft.MachineLearningServices/preview/2024-07-01-preview/workspaceFeatures.json
43+
suppressions:
44+
- code: AvoidAdditionalProperties
45+
reason: As discussed In office hour this conf property is string dictionary and passed by user as per there requirements depending on runtime version. This passed to downstream and we have multiple validation on all required configuration before passing it downstream, All optional property passed as user wants and any failure due to that considered as user error.
46+
where:
47+
- $.definitions["SparkJob"].properties["conf"]
48+
- code: AvoidAdditionalProperties
49+
reason: This is for feature parity with other job type like commandjob, sweepjob etc. We have one interface for all type of job and other job take environment variable like this to match with them we also pass environment variable in this format. please check existing "CommandJob" in same file.
50+
where:
51+
- $.definitions["SparkJob"].properties["environmentVariables"]
52+
- code: PatchBodyParametersSchema
53+
reason: This is already exist in preview version api version, the reason we have required mark for the property inside is those are the only format we allow user to update this whole encryption property.
54+
where:
55+
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}"].patch.parameters[4].schema.properties.properties
56+
- code: AvoidAdditionalProperties
57+
reason: These schemas are already in production use,.
58+
where:
59+
- $.definitions.WorkspaceUpdateParameters.properties.properties.properties.managedNetwork.properties.outboundRules
60+
- $.definitions.WorkspacePropertiesUpdateParameters.properties.managedNetwork.properties.outboundRules
61+
- $.definitions.EndpointModels.properties.value.items.properties.capabilities
62+
- $.definitions.AccountModel.properties.finetuneCapabilities
63+
- $.definitions.AccountModel.properties.capabilities
64+
- $.definitions.EndpointModels.properties.value.items.properties.finetuneCapabilities
65+
- $.definitions.CustomKeysWorkspaceConnectionProperties.properties.credentials.properties.keys
66+
- $.definitions.CustomKeys.properties.keys
67+
- $.definitions.WorkspaceConnectionPropertiesV2.properties.metadata
68+
- $.definitions.PATAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
69+
- $.definitions.SASAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
70+
- $.definitions.UsernamePasswordAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
71+
- $.definitions.NoneAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
72+
- $.definitions.ManagedIdentityAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
73+
- $.definitions.WorkspaceConnectionPropertiesV2BasicResource.properties.properties.properties.metadata
74+
- $.definitions.WorkspaceConnectionPropertiesV2BasicResourceArmPaginatedResult.properties.value.items.properties.properties.properties.metadata
75+
- $.definitions.AADAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
76+
- $.definitions.AccessKeyAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
77+
- $.definitions.AccountKeyAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
78+
- $.definitions.ApiKeyAuthWorkspaceConnectionProperties.allOf[0].properties.metadata
79+
- $.definitions.CustomKeysWorkspaceConnectionProperties.allOf[0].properties.metadata
80+
- $.definitions.OAuth2AuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
81+
- $.definitions.ServicePrincipalAuthTypeWorkspaceConnectionProperties.allOf[0].properties.metadata
82+
- code: GuidUsage
83+
reason: This property has always been a GUID, we just didn't mark its format before, this can't be change without breaking the customer.
84+
where:
85+
- $.definitions.WorkspaceConnectionOAuth2.properties.clientId.format
4386
```
4487

4588
### Tag: package-2024-04

0 commit comments

Comments
 (0)