[Azure SignalR Service - Azure Web PubSub] API Review

[azure-sdk]

New API Review meeting has been requested.

Service Name: Azure SignalR Service - Azure Web PubSub
Review Created By: Siyuan Xing
Review Date: 06/14/2023 09:00 AM PT
Onboarding Record:
PR: #23927
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: add new version stable/2023-07-01

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

[mikekistler]

Notes from API Review meeting 6/14/23

• Unclear how "connectionFilter" works for addToGroups.
• Should rename "filter" to "connectionFilter"? Maybe not.
• Maybe improve the description to explain how connectionFilter is used to get a filtered list of connections, and these are added to the groups.
• Add a link to the OData filter conceptual docs
• But the EBNF in the Syntax section has great potential for confusion -- should probably remove it. The full formal grammar is shown later in the page.
• Search team made their EBNF interactive -- and it looks like that's also the case here
• AddTo and RemoveFrom should be idempotent ... seems like they are. Good.
• Min and max values on messageTtlSeconds. Better to just put these in the description and not as formal attributes.

This looks good for GA after addressing the above.