From 5b5323d9ddd3dcb492e27c11194ad5322ae2f2c1 Mon Sep 17 00:00:00 2001 From: David Tran Date: Wed, 4 May 2022 10:33:30 -0700 Subject: [PATCH 1/4] fix description for maintenance window time zone --- .../preview/2022-02-10-preview/desktopvirtualization.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json index 2715e90f34ea..3f263977f685 100644 --- a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json +++ b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json @@ -3787,7 +3787,7 @@ }, "maintenanceWindowTimeZone": { "type": "string", - "description": "Time zone for maintenance as defined in https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. Must be set if useLocalTime is true." + "description": "Time zone for maintenance as defined in https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. Must be set if useSessionHostLocalTime is false." }, "maintenanceWindows": { "type": "array", @@ -3859,7 +3859,7 @@ }, "maintenanceWindowTimeZone": { "type": "string", - "description": "Time zone for maintenance as defined in https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. Must be set if useLocalTime is true." + "description": "Time zone for maintenance as defined in https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. Must be set if useSessionHostLocalTime is false." }, "maintenanceWindows": { "type": "array", From 99d5b94ec0768e392c82f75558296ce92ced1200 Mon Sep 17 00:00:00 2001 From: David Tran Date: Wed, 4 May 2022 10:53:59 -0700 Subject: [PATCH 2/4] more description updates --- .../desktopvirtualization.json | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json index 3f263977f685..f08b251de17f 100644 --- a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json +++ b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json @@ -3541,7 +3541,7 @@ }, "agentUpdate": { "$ref": "#/definitions/AgentUpdateProperties", - "description": "The session host configuration for updating agent, monitoring agent, and stack component." + "description": "The preferred settings for updating the agent components (RDAgent, Geneva Monitoring agent, and side-by-side stack) on session hosts." }, "privateEndpointConnections": { "readOnly": true, @@ -3698,7 +3698,7 @@ }, "agentUpdate": { "$ref": "#/definitions/AgentUpdatePatchProperties", - "description": "The session host configuration for updating agent, monitoring agent, and stack component." + "description": "The preferred settings for updating the agent components (RDAgent, Geneva Monitoring agent, and side-by-side stack) on session hosts." } } }, @@ -3756,12 +3756,12 @@ } }, "AgentUpdateProperties": { - "description": "The session host configuration for updating agent, monitoring agent, and stack component.", + "description": "The preferred settings for updating the agent components (RDAgent, Geneva Monitoring agent, and side-by-side stack) on session hosts.", "type": "object", "properties": { "type": { "type": "string", - "description": "The type of maintenance for session host components.", + "description": "The preferred mechanism for updating the agent components. This is either Scheduled or Default.", "enum": [ "Default", "Scheduled" @@ -3772,26 +3772,26 @@ "values": [ { "value": "Default", - "description": "Agent and other agent side components are delivery schedule is controlled by WVD Infra." + "description": "The agent components are updated according to the AVD infrastructure flighting. For more information, see https://aka.ms/avdagent." }, { "value": "Scheduled", - "description": "TenantAdmin have opted in for Scheduled Component Update feature." + "description": "This enables the Scheduled Agent Updates feature which allows the agent components to get updated according to the schedule that the admin define For more information, see https://aka.ms/avdsau." } ] } }, "useSessionHostLocalTime": { "type": "boolean", - "description": "Whether to use localTime of the virtual machine." + "description": "Boolean indicating whether to update the agent components in the local time zone of each session host in the host pool. By default, this is false." }, "maintenanceWindowTimeZone": { "type": "string", - "description": "Time zone for maintenance as defined in https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. Must be set if useSessionHostLocalTime is false." + "description": "The time zone for updating the agent components. Valid time zones can be found here: https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. A time zone must be specified if useSessionHostLocalTime is false." }, "maintenanceWindows": { "type": "array", - "description": "List of maintenance windows. Maintenance windows are 2 hours long.", + "description": "The maintenance windows (day and time) for updating the agent components. At least 1 window must be specified. Optionally, a 2nd window can be specified.", "items": { "$ref": "#/definitions/MaintenanceWindowProperties" }, @@ -3806,11 +3806,11 @@ "hour": { "format": "int32", "type": "integer", - "description": "The update start hour of the day. (0 - 23)" + "description": "The starting hour of the maintenance window (0-23). Note that maintenance windows are 2 hours long. This means that updates can be applied anytime from the specified start hour to 2 hours after." }, "dayOfWeek": { "type": "string", - "description": "Day of the week.", + "description": "The day of the week (Monday-Sunday).", "enum": [ "Monday", "Tuesday", @@ -3828,12 +3828,12 @@ } }, "AgentUpdatePatchProperties": { - "description": "The session host configuration for updating agent, monitoring agent, and stack component.", + "description": "The preferred settings for updating the agent components (RDAgent, Geneva Monitoring agent, and side-by-side stack) on session hosts.", "type": "object", "properties": { "type": { "type": "string", - "description": "The type of maintenance for session host components.", + "description": "The preferred mechanism for updating the agent components. This is either Scheduled or Default.", "enum": [ "Default", "Scheduled" @@ -3844,26 +3844,26 @@ "values": [ { "value": "Default", - "description": "Agent and other agent side components are delivery schedule is controlled by WVD Infra." + "description": "The agent components are updated according to the AVD infrastructure flighting. For more information, see https://aka.ms/avdagent." }, { "value": "Scheduled", - "description": "TenantAdmin have opted in for Scheduled Component Update feature." + "description": "This enables the Scheduled Agent Updates feature which allows the agent components to get updated according to the schedule that the admin define For more information, see https://aka.ms/avdsau." } ] } }, "useSessionHostLocalTime": { "type": "boolean", - "description": "Whether to use localTime of the virtual machine." + "description": "Boolean indicating whether to update the agent components in the local time zone of each session host in the host pool. By default, this is false." }, "maintenanceWindowTimeZone": { "type": "string", - "description": "Time zone for maintenance as defined in https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. Must be set if useSessionHostLocalTime is false." + "description": "The time zone for updating the agent components. Valid time zones can be found here: https://docs.microsoft.com/en-us/dotnet/api/system.timezoneinfo.findsystemtimezonebyid?view=net-5.0. A time zone must be specified if useSessionHostLocalTime is false." }, "maintenanceWindows": { "type": "array", - "description": "List of maintenance windows. Maintenance windows are 2 hours long.", + "description": "The maintenance windows (day and time) for updating the agent components. At least 1 window must be specified. Optionally, a 2nd window can be specified.", "items": { "$ref": "#/definitions/MaintenanceWindowPatchProperties" }, @@ -3878,11 +3878,11 @@ "hour": { "format": "int32", "type": "integer", - "description": "The update start hour of the day. (0 - 23)" + "description": "The starting hour of the maintenance window (0-23). Note that maintenance windows are 2 hours long. This means that updates can be applied anytime from the specified start hour to 2 hours after." }, "dayOfWeek": { "type": "string", - "description": "Day of the week.", + "description": "The day of the week (Monday-Sunday).", "enum": [ "Monday", "Tuesday", From 4f363e68f2264abd7a479e596a7414b94301c2f2 Mon Sep 17 00:00:00 2001 From: datr93 <43795914+datr93@users.noreply.github.com> Date: Wed, 4 May 2022 11:03:50 -0700 Subject: [PATCH 3/4] Update specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json Co-authored-by: sefriend <73497825+sefriend@users.noreply.github.com> --- .../preview/2022-02-10-preview/desktopvirtualization.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json index f08b251de17f..b19b51b88a11 100644 --- a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json +++ b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json @@ -3776,7 +3776,7 @@ }, { "value": "Scheduled", - "description": "This enables the Scheduled Agent Updates feature which allows the agent components to get updated according to the schedule that the admin define For more information, see https://aka.ms/avdsau." + "description": "This enables the Scheduled Agent Updates feature which allows the agent components to get updated according to the schedule that the admin define. For more information, see https://aka.ms/avdsau." } ] } From 793c4ad8dc4190f92f17abe14b569d854ff0c71d Mon Sep 17 00:00:00 2001 From: datr93 <43795914+datr93@users.noreply.github.com> Date: Wed, 4 May 2022 11:03:55 -0700 Subject: [PATCH 4/4] Update specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json Co-authored-by: sefriend <73497825+sefriend@users.noreply.github.com> --- .../preview/2022-02-10-preview/desktopvirtualization.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json index b19b51b88a11..d50450be4188 100644 --- a/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json +++ b/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2022-02-10-preview/desktopvirtualization.json @@ -3848,7 +3848,7 @@ }, { "value": "Scheduled", - "description": "This enables the Scheduled Agent Updates feature which allows the agent components to get updated according to the schedule that the admin define For more information, see https://aka.ms/avdsau." + "description": "This enables the Scheduled Agent Updates feature which allows the agent components to get updated according to the schedule that the admin define. For more information, see https://aka.ms/avdsau." } ] }