From 4c21b4b5e76ad4c6379399fe404dd38541a86ce9 Mon Sep 17 00:00:00 2001 From: xwang971 Date: Wed, 15 Feb 2023 16:10:44 -0800 Subject: [PATCH 1/3] add properties for secrets from KV --- .../preview/2022-11-01-preview/CommonDefinitions.json | 8 ++++++++ .../preview/2022-11-01-preview/ContainerApps.json | 10 ++++++++++ .../examples/ContainerApps_ListSecrets.json | 5 ++++- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/CommonDefinitions.json b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/CommonDefinitions.json index b9c0c9cb47cf..ae5206975f3a 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/CommonDefinitions.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/CommonDefinitions.json @@ -555,6 +555,14 @@ "update" ], "x-ms-secret": true + }, + "identity": { + "description": "Resource ID of a managed identity to authenticate with Azure Key Vault, or System to use a system-assigned identity.", + "type": "string" + }, + "keyVaultUrl": { + "description": "Azure Key Vault URL pointing to the secret referenced by the container app.", + "type": "string" } } }, diff --git a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json index 089fb59476e5..53568624e61c 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json @@ -818,6 +818,16 @@ "type": "string", "x-ms-secret": true, "readOnly": true + }, + "identity": { + "description": "Resource ID of a managed identity to authenticate with Azure Key Vault, or System to use a system-assigned identity.", + "type": "Identity", + "readOnly": true + }, + "keyVaultUrl": { + "description": "Azure Key Vault URL pointing to the secret referenced by the container app.", + "type": "string", + "readOnly": true } } }, diff --git a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json index 5ee83f926c5d..2b8732954dd5 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json @@ -14,7 +14,10 @@ "name": "secret1" }, { - "name": "secret2" + "name": "secret2", + "value": "value2", + "identity": "SYSTEM", + "keyVaultUrl": "kvurl" } ] } From 6ef490a0c8be7d3a72fd91ea4eeec3d35a3c22a8 Mon Sep 17 00:00:00 2001 From: xwang971 Date: Wed, 15 Feb 2023 16:36:49 -0800 Subject: [PATCH 2/3] typo --- .../Microsoft.App/preview/2022-11-01-preview/ContainerApps.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json index 53568624e61c..3e68e46e96ab 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json @@ -821,7 +821,7 @@ }, "identity": { "description": "Resource ID of a managed identity to authenticate with Azure Key Vault, or System to use a system-assigned identity.", - "type": "Identity", + "type": "string", "readOnly": true }, "keyVaultUrl": { From 4d4395b74f4a3cbc5dc7b6e47aab065e2dd6d041 Mon Sep 17 00:00:00 2001 From: xwang971 Date: Wed, 15 Feb 2023 16:42:07 -0800 Subject: [PATCH 3/3] remove unnecessay examples --- .../examples/ContainerApps_ListSecrets.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json index 2b8732954dd5..5ee83f926c5d 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/ContainerApps_ListSecrets.json @@ -14,10 +14,7 @@ "name": "secret1" }, { - "name": "secret2", - "value": "value2", - "identity": "SYSTEM", - "keyVaultUrl": "kvurl" + "name": "secret2" } ] }