From e20fbe33dd7a64a55e17e601c327b3d2a1498f51 Mon Sep 17 00:00:00 2001 From: Salam Bashir Date: Thu, 24 Aug 2023 11:25:11 +0300 Subject: [PATCH 1/4] add scanResultsEventGridTopicResourceId --- .../2022-12-01-preview/defenderForStorageSettings.json | 5 +++++ .../GetDefenderForStorageSettings_example.json | 5 +++-- .../PutDefenderForStorageSettings_example.json | 4 +++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json index efbb5a165e0d..c00820da5fce 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json @@ -165,6 +165,11 @@ "x-ms-client-flatten": true, "$ref": "#/definitions/OnUploadProperties" }, + "scanResultsEventGridTopicResourceId":{ + "type": "string", + "required": false, + "description": "Optional. Resouce id of an Event Grid Topic to send scan results to." + }, "operationStatus": { "type": "object", "$ref": "#/definitions/OperationStatus", diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/GetDefenderForStorageSettings_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/GetDefenderForStorageSettings_example.json index 1f963d43149e..fed23dcf02cb 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/GetDefenderForStorageSettings_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/GetDefenderForStorageSettings_example.json @@ -14,9 +14,10 @@ "isEnabled": true, "malwareScanning": { "onUpload": { - "isEnabled": false, + "isEnabled": true, "capGBPerMonth": -1 - } + }, + "scanResultsEventGridTopicResourceId": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/SampleRG/providers/Microsoft.EventGrid/topics/sampletopic" }, "sensitiveDataDiscovery": { "isEnabled": false diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/PutDefenderForStorageSettings_example.json b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/PutDefenderForStorageSettings_example.json index 8aa49929b77b..e214e5ed48e0 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/PutDefenderForStorageSettings_example.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/examples/DefenderForStorage/PutDefenderForStorageSettings_example.json @@ -10,7 +10,8 @@ "onUpload": { "isEnabled": true, "capGBPerMonth": -1 - } + }, + "scanResultsEventGridTopicResourceId": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/SampleRG/providers/Microsoft.EventGrid/topics/sampletopic" }, "sensitiveDataDiscovery": { "isEnabled": true @@ -32,6 +33,7 @@ "isEnabled": true, "capGBPerMonth": -1 }, + "scanResultsEventGridTopicResourceId": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/SampleRG/providers/Microsoft.EventGrid/topics/sampletopic", "operationStatus": { "code": "Succeeded" } From 0e4ee2c44d6bda7a86a63b5c4b3007c4c695c648 Mon Sep 17 00:00:00 2001 From: Salam Bashir Date: Thu, 24 Aug 2023 15:10:44 +0300 Subject: [PATCH 2/4] fix typo --- .../preview/2022-12-01-preview/defenderForStorageSettings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json index c00820da5fce..105ec3e43c15 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json @@ -168,7 +168,7 @@ "scanResultsEventGridTopicResourceId":{ "type": "string", "required": false, - "description": "Optional. Resouce id of an Event Grid Topic to send scan results to." + "description": "Optional. Resource id of an Event Grid Topic to send scan results to." }, "operationStatus": { "type": "object", From 95453f0aac3abd4c55c58f307b723289edac43cf Mon Sep 17 00:00:00 2001 From: Salam Bashir Date: Thu, 24 Aug 2023 15:12:38 +0300 Subject: [PATCH 3/4] prettier --- .../preview/2022-12-01-preview/defenderForStorageSettings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json index 105ec3e43c15..ad2c7d367d1f 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json @@ -165,7 +165,7 @@ "x-ms-client-flatten": true, "$ref": "#/definitions/OnUploadProperties" }, - "scanResultsEventGridTopicResourceId":{ + "scanResultsEventGridTopicResourceId": { "type": "string", "required": false, "description": "Optional. Resource id of an Event Grid Topic to send scan results to." From 80a8cfe0940e73c70475e8a3da43ea8d079e4683 Mon Sep 17 00:00:00 2001 From: Salam Bashir Date: Thu, 24 Aug 2023 15:25:05 +0300 Subject: [PATCH 4/4] remove "required": false, --- .../preview/2022-12-01-preview/defenderForStorageSettings.json | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json index ad2c7d367d1f..c10845476167 100644 --- a/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json +++ b/specification/security/resource-manager/Microsoft.Security/preview/2022-12-01-preview/defenderForStorageSettings.json @@ -167,7 +167,6 @@ }, "scanResultsEventGridTopicResourceId": { "type": "string", - "required": false, "description": "Optional. Resource id of an Event Grid Topic to send scan results to." }, "operationStatus": {