From 83735df29776ac9e6eb7253cb5e71c0716d236ae Mon Sep 17 00:00:00 2001 From: wiboris Date: Mon, 28 Aug 2023 15:03:05 -0700 Subject: [PATCH 1/2] Updating BatchManagement.json to call out default values that caused Get responses to contain values that the Put requests did not have that got identified by S360 https://openapihub.azure-devex-tools.com/amekpis/correctness/detail?errorId=95CCEFF6-39EC-450A-8C82-E94C9382B314 and https://openapihub.azure-devex-tools.com/amekpis/correctness/detail?errorId=D50E2596-9471-40E1-8767-892023E02014 --- .../stable/2023-05-01/BatchManagement.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json b/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json index 02239c9c5499..f325971a5c02 100644 --- a/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json +++ b/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json @@ -4177,6 +4177,7 @@ "taskSlotsPerNode": { "type": "integer", "format": "int32", + "default": 1, "title": "The number of task slots that can be used to run concurrent tasks on a single compute node in the pool.", "description": "The default value is 1. The maximum value is the smaller of 4 times the number of cores of the vmSize of the pool or 256." }, @@ -4363,6 +4364,7 @@ "resizeTimeout": { "type": "string", "format": "duration", + "default": "PT15M", "title": "The timeout for allocation of compute nodes to the pool.", "description": "The default value is 15 minutes. Timeout values use ISO 8601 format. For example, use PT10M for 10 minutes. The minimum value is 5 minutes. If you specify a value less than 5 minutes, the Batch service rejects the request with an error; if you are calling the REST API directly, the HTTP status code is 400 (Bad Request)." }, @@ -4594,6 +4596,7 @@ }, "NodeCommunicationMode": { "type": "string", + "default": "Default", "title": "Determines how a pool communicates with the Batch service.", "enum": [ "Default", @@ -4922,6 +4925,7 @@ }, "version": { "type": "string", + "default": "latest", "title": "The version of the Azure Virtual Machines Marketplace image.", "description": "A value of 'latest' can be specified to select the latest version of an image. If omitted, the default is 'latest'." }, @@ -4969,6 +4973,7 @@ "properties": { "nodeFillType": { "type": "string", + "default": "Spread", "title": "How tasks should be distributed across compute nodes.", "enum": [ "Spread", @@ -5118,8 +5123,9 @@ "maxTaskRetryCount": { "type": "integer", "format": "int32", + "default": 0, "title": "The maximum number of times the task may be retried.", - "description": "The Batch service retries a task if its exit code is nonzero. Note that this value specifically controls the number of retries. The Batch service will try the task once, and may then retry up to this limit. For example, if the maximum retry count is 3, Batch tries the task up to 4 times (one initial try and 3 retries). If the maximum retry count is 0, the Batch service does not retry the task. If the maximum retry count is -1, the Batch service retries the task without limit." + "description": "The Batch service retries a task if its exit code is nonzero. Note that this value specifically controls the number of retries. The Batch service will try the task once, and may then retry up to this limit. For example, if the maximum retry count is 3, Batch tries the task up to 4 times (one initial try and 3 retries). If the maximum retry count is 0, the Batch service does not retry the task. If the maximum retry count is -1, the Batch service retries the task without limit. Default is 0." }, "waitForSuccess": { "type": "boolean", @@ -5486,6 +5492,7 @@ }, "dynamicVnetAssignmentScope": { "type": "string", + "default": "none", "title": "The scope of dynamic vnet assignment.", "enum": [ "none", From 73f8081a33109306fde7eb576df6030896bc9557 Mon Sep 17 00:00:00 2001 From: wiboris Date: Mon, 28 Aug 2023 17:28:16 -0700 Subject: [PATCH 2/2] remove of one default value --- .../Microsoft.Batch/stable/2023-05-01/BatchManagement.json | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json b/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json index f325971a5c02..3771b5fe97f7 100644 --- a/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json +++ b/specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/BatchManagement.json @@ -4596,7 +4596,6 @@ }, "NodeCommunicationMode": { "type": "string", - "default": "Default", "title": "Determines how a pool communicates with the Batch service.", "enum": [ "Default",