Skip to content

Conversation

@Aman-Jain-14
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Aman Jain added 3 commits April 30, 2024 07:34
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-03-01 to stable/2024-07-01.
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 30, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 30, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 13 Warnings warning [Detail]
Compared specs (v0.10.12) new version base version
amlfilesystem.json 2024-07-01(882059f) 2024-03-01(main)
amlfilesystem.json 2024-07-01(882059f) 2023-11-01-preview(main)
storagecache.json 2024-07-01(882059f) 2024-03-01(main)
storagecache.json 2024-07-01(882059f) 2023-11-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
⚠️ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L465:5
⚠️ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L722:5
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'importedFiles' in response that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1971:15
Old: Microsoft.StorageCache/stable/2024-03-01/amlfilesystem.json#L1446:15
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'importedDirectories' in response that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1971:15
Old: Microsoft.StorageCache/stable/2024-03-01/amlfilesystem.json#L1446:15
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'importedSymlinks' in response that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1971:15
Old: Microsoft.StorageCache/stable/2024-03-01/amlfilesystem.json#L1446:15
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'preexistingFiles' in response that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1971:15
Old: Microsoft.StorageCache/stable/2024-03-01/amlfilesystem.json#L1446:15
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'preexistingDirectories' in response that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1971:15
Old: Microsoft.StorageCache/stable/2024-03-01/amlfilesystem.json#L1446:15
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'preexistingSymlinks' in response that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1971:15
Old: Microsoft.StorageCache/stable/2024-03-01/amlfilesystem.json#L1446:15


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L2006:9
Old: Microsoft.StorageCache/preview/2023-11-01-preview/storagecache.json#L2006:9
⚠️ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L465:5
⚠️ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L722:5
⚠️ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L770:5
⚠️ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1027:5
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-07 package-2024-07(882059f) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1684


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L126
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L167
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L281
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L320
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:keyUrl.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L325
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:sourceVault.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L325
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L353
PostResponseCodes Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1076
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L1100
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.StorageCache/stable/2024-07-01/amlfilesystem.json#L2196
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L52
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L297
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L342
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L343
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L384
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L443
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L486
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L492
UnSupportedPatchProperties Mark the top-level property 'id', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L531
UnSupportedPatchProperties Mark the top-level property 'name', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L531
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:mtu.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:ntpServer.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:keyUrl.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:sourceVault.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:primaryDnsIpAddress.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:domainName.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:domainNetBiosName.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:cacheNetBiosName.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:username.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:usernameSource.
Location: Microsoft.StorageCache/stable/2024-07-01/storagecache.json#L535
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 30, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from ad5b8a6919bb674dd6760aae5df786ac4e1362d3. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-storagecache [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group AutoExportJobsOperations
    info	[Changelog]   - Model ImportJob has a new parameter admin_status
    info	[Changelog]   - Model ImportJob has a new parameter imported_directories
    info	[Changelog]   - Model ImportJob has a new parameter imported_files
    info	[Changelog]   - Model ImportJob has a new parameter imported_symlinks
    info	[Changelog]   - Model ImportJob has a new parameter preexisting_directories
    info	[Changelog]   - Model ImportJob has a new parameter preexisting_files
    info	[Changelog]   - Model ImportJob has a new parameter preexisting_symlinks
️🔄 azure-sdk-for-net-track2 inProgress [Detail]
️🔄 azure-sdk-for-java inProgress [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from ad5b8a6919bb674dd6760aae5df786ac4e1362d3. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/storagecache/armstoragecache [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `AutoExportJobAdminStatus` with values `AutoExportJobAdminStatusDisable`, `AutoExportJobAdminStatusEnable`
    info	[Changelog] - New enum type `AutoExportJobProvisioningStateType` with values `AutoExportJobProvisioningStateTypeCanceled`, `AutoExportJobProvisioningStateTypeCreating`, `AutoExportJobProvisioningStateTypeDeleting`, `AutoExportJobProvisioningStateTypeFailed`, `AutoExportJobProvisioningStateTypeSucceeded`, `AutoExportJobProvisioningStateTypeUpdating`
    info	[Changelog] - New enum type `AutoExportStatusType` with values `AutoExportStatusTypeDisableFailed`, `AutoExportStatusTypeDisabled`, `AutoExportStatusTypeDisabling`, `AutoExportStatusTypeFailed`, `AutoExportStatusTypeInProgress`
    info	[Changelog] - New enum type `ImportJobAdminStatus` with values `ImportJobAdminStatusDisable`, `ImportJobAdminStatusEnable`
    info	[Changelog] - New function `NewAutoExportJobsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AutoExportJobsClient, error)`
    info	[Changelog] - New function `*AutoExportJobsClient.BeginCreateOrUpdate(context.Context, string, string, string, AutoExportJob, *AutoExportJobsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AutoExportJobsClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*AutoExportJobsClient.BeginDelete(context.Context, string, string, string, *AutoExportJobsClientBeginDeleteOptions) (*runtime.Poller[AutoExportJobsClientDeleteResponse], error)`
    info	[Changelog] - New function `*AutoExportJobsClient.Get(context.Context, string, string, string, *AutoExportJobsClientGetOptions) (AutoExportJobsClientGetResponse, error)`
    info	[Changelog] - New function `*AutoExportJobsClient.NewListByAmlFilesystemPager(string, string, *AutoExportJobsClientListByAmlFilesystemOptions) *runtime.Pager[AutoExportJobsClientListByAmlFilesystemResponse]`
    info	[Changelog] - New function `*AutoExportJobsClient.BeginUpdate(context.Context, string, string, string, AutoExportJobUpdate, *AutoExportJobsClientBeginUpdateOptions) (*runtime.Poller[AutoExportJobsClientUpdateResponse], error)`
    info	[Changelog] - New function `*ClientFactory.NewAutoExportJobsClient() *AutoExportJobsClient`
    info	[Changelog] - New struct `AutoExportJob`
    info	[Changelog] - New struct `AutoExportJobProperties`
    info	[Changelog] - New struct `AutoExportJobPropertiesStatus`
    info	[Changelog] - New struct `AutoExportJobUpdate`
    info	[Changelog] - New struct `AutoExportJobsListResult`
    info	[Changelog] - New field `AdminStatus` in struct `ImportJobProperties`
    info	[Changelog] - New field `ImportedDirectories`, `ImportedFiles`, `ImportedSymlinks`, `PreexistingDirectories`, `PreexistingFiles`, `PreexistingSymlinks` in struct `ImportJobPropertiesStatus`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 38 additive change(s).
️🔄 azure-sdk-for-js inProgress [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from ad5b8a6919bb674dd6760aae5df786ac4e1362d3. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️🔄 azure-powershell inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@Aman-Jain-14 Aman-Jain-14 force-pushed the Aman-Jain-14/auto-export-spec-24-07-01 branch from 49c5bed to 5c23139 Compare May 28, 2024 20:53
@Aman-Jain-14 Aman-Jain-14 force-pushed the Aman-Jain-14/auto-export-spec-24-07-01 branch from 92be441 to 2df3c09 Compare May 29, 2024 18:26
@Aman-Jain-14 Aman-Jain-14 marked this pull request as ready for review May 30, 2024 02:23
@Aman-Jain-14 Aman-Jain-14 requested a review from brpanask May 30, 2024 02:24
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Jun 24, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jul 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Sep 2, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 17, 2024
@Aman-Jain-14 Aman-Jain-14 removed the request for review from brpanask September 18, 2024 18:44
@Aman-Jain-14 Aman-Jain-14 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Dec 9, 2024
@Aman-Jain-14 Aman-Jain-14 removed the no-recent-activity There has been no recent activity on this issue. label Dec 9, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.StorageCache

@Aman-Jain-14 Aman-Jain-14 force-pushed the Aman-Jain-14/auto-export-spec-24-07-01 branch from c698b58 to 2df3c09 Compare December 10, 2024 17:37
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Dec 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Dec 30, 2024
@Aman-Jain-14 Aman-Jain-14 removed the no-recent-activity There has been no recent activity on this issue. label Dec 30, 2024
@Aman-Jain-14 Aman-Jain-14 merged commit ef6d118 into Azure:main Feb 4, 2025
29 checks passed
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-07-01

Updated the API version from stable/2024-03-01 to stable/2024-07-01.

* Added tag for 2024-07-01 in readme file

* Adding 2024-07-01 stable specification for auto export feature

* Addressing lint errors

* Fixing spell check error

* Fixing prettier errors

* Addressing prettier errors

* Amending incorrect AutoExport tags

* Fixing prettier checks errors

---------

Co-authored-by: Aman Jain <[email protected]>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-07-01

Updated the API version from stable/2024-03-01 to stable/2024-07-01.

* Added tag for 2024-07-01 in readme file

* Adding 2024-07-01 stable specification for auto export feature

* Addressing lint errors

* Fixing spell check error

* Fixing prettier errors

* Addressing prettier errors

* Amending incorrect AutoExport tags

* Fixing prettier checks errors

---------

Co-authored-by: Aman Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk-Approved brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants